| Message ID | 20220628194526.111501-2-phil.edworthy@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | i2c: Add new driver for Renesas RZ/V2M controller | expand |
On Tue, 28 Jun 2022 20:45:25 +0100, Phil Edworthy wrote: > Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v2: > - Use an enum and set the default for clock-frequency > - Add resets property > --- > .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to match any schema with compatible: ['adi,ltc2983'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, On Wed, Jun 29, 2022 at 4:09 AM Rob Herring <robh@kernel.org> wrote: > On Tue, 28 Jun 2022 20:45:25 +0100, Phil Edworthy wrote: > > Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v2: > > - Use an enum and set the default for clock-frequency > > - Add resets property > > --- > > .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const': '$ref'} > hint: Standard unit suffix properties don't need a type $ref > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp > Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to match any schema with compatible: ['adi,ltc2983'] All of these look like false-positives, i.e. not related to this patch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 29/06/2022 08:53, Geert Uytterhoeven wrote: > Hi Rob, > > On Wed, Jun 29, 2022 at 4:09 AM Rob Herring <robh@kernel.org> wrote: >> On Tue, 28 Jun 2022 20:45:25 +0100, Phil Edworthy wrote: >>> Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. >>> >>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> >>> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> >>> --- >>> v2: >>> - Use an enum and set the default for clock-frequency >>> - Add resets property >>> --- >>> .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ >>> 1 file changed, 80 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const': '$ref'} >> hint: Standard unit suffix properties don't need a type $ref >> from schema $id: http://devicetree.org/meta-schemas/core.yaml# >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp >> Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to match any schema with compatible: ['adi,ltc2983'] > > All of these look like false-positives, i.e. not related to this patch? Few other patches also got it, I think the bot got some problem. Best regards, Krzysztof
On 28/06/2022 21:45, Phil Edworthy wrote: > Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v2: > - Use an enum and set the default for clock-frequency > - Add resets property > --- > .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > new file mode 100644 > index 000000000000..7f6d2bb4ecb3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/renesas,rzv2m.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/V2M I2C Bus Interface > + > +maintainers: > + - Phil Edworthy <phil.edworthy@renesas.com> > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,i2c-r9a09g011 # RZ/V2M > + - const: renesas,rzv2m-i2c > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Data transmission/reception interrupt > + - description: Status interrupt > + > + interrupt-names: > + items: > + - const: tia > + - const: tis > + > + clock-frequency: > + default: 100000 > + enum: [ 100000, 400000 ] > + description: > + Desired I2C bus clock frequency in Hz. > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - power-domains > + - resets > + - '#address-cells' > + - '#size-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r9a09g011-cpg.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + i2c0: i2c@a4030000 { > + compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c"; I missed that part in last version - you have some weird indentation here. Use 4 spaces for DTS example. Best regards, Krzysztof
On Wed, Jun 29, 2022 at 2:15 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 29/06/2022 08:53, Geert Uytterhoeven wrote: > > Hi Rob, > > > > On Wed, Jun 29, 2022 at 4:09 AM Rob Herring <robh@kernel.org> wrote: > >> On Tue, 28 Jun 2022 20:45:25 +0100, Phil Edworthy wrote: > >>> Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > >>> > >>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > >>> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > >>> --- > >>> v2: > >>> - Use an enum and set the default for clock-frequency > >>> - Add resets property > >>> --- > >>> .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ > >>> 1 file changed, 80 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const': '$ref'} > >> hint: Standard unit suffix properties don't need a type $ref > >> from schema $id: http://devicetree.org/meta-schemas/core.yaml# > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring, error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp > >> Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to match any schema with compatible: ['adi,ltc2983'] > > > > All of these look like false-positives, i.e. not related to this patch? > > Few other patches also got it, I think the bot got some problem. Yes, and the bot's overlord failed to see that too. A change yesterday in dtschema main branch introduced a new warning and that requires clearing the CI cache which I didn't do til now. Rob
Hi Krzysztof, On 29 June 2022 09:23, Krzysztof Kozlowski wrote: > On 28/06/2022 21:45, Phil Edworthy wrote: > > Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v2: > > - Use an enum and set the default for clock-frequency > > - Add resets property > > --- > > .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml ... > > +examples: > > + - | > > + #include <dt-bindings/clock/r9a09g011-cpg.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + > > + i2c0: i2c@a4030000 { > > + compatible = "renesas,i2c-r9a09g011", > > + "renesas,rzv2m-i2c"; > > I missed that part in last version - you have some weird indentation here. > Use 4 spaces for DTS example. Will do! Thanks Phil
diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml new file mode 100644 index 000000000000..7f6d2bb4ecb3 --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/renesas,rzv2m.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas RZ/V2M I2C Bus Interface + +maintainers: + - Phil Edworthy <phil.edworthy@renesas.com> + +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +properties: + compatible: + items: + - enum: + - renesas,i2c-r9a09g011 # RZ/V2M + - const: renesas,rzv2m-i2c + + reg: + maxItems: 1 + + interrupts: + items: + - description: Data transmission/reception interrupt + - description: Status interrupt + + interrupt-names: + items: + - const: tia + - const: tis + + clock-frequency: + default: 100000 + enum: [ 100000, 400000 ] + description: + Desired I2C bus clock frequency in Hz. + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + + resets: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - interrupt-names + - clocks + - power-domains + - resets + - '#address-cells' + - '#size-cells' + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/r9a09g011-cpg.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + i2c0: i2c@a4030000 { + compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c"; + reg = <0xa4030000 0x80>; + interrupts = <GIC_SPI 232 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 236 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "tia", "tis"; + clocks = <&cpg CPG_MOD R9A09G011_IIC_PCLK0>; + resets = <&cpg R9A09G011_IIC_GPA_PRESETN>; + power-domains = <&cpg>; + clock-frequency = <100000>; + #address-cells = <1>; + #size-cells = <0>; + };