| Message ID | 20220629092435.496051-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [-next] net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get() | expand |
Le Wed, 29 Jun 2022 17:24:35 +0800, Yang Yingliang <yangyingliang@huawei.com> a écrit : > of_parse_phandle() will increase the refcount of 'pcs_node', so add > of_node_put() before return from a5psw_pcs_get(). > > Fixes: 888cdb892b61 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/dsa/rzn1_a5psw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c > index 3e910da98ae2..301171ee1061 100644 > --- a/drivers/net/dsa/rzn1_a5psw.c > +++ b/drivers/net/dsa/rzn1_a5psw.c > @@ -923,6 +923,7 @@ static int a5psw_pcs_get(struct a5psw *a5psw) > return 0; > > free_pcs: > + of_node_put(pcs_node); of_node_put(pcs_node) should probably also be called after miic_create(a5psw->dev, pcs_node); since it is not needed anymore. Clément > of_node_put(port); > of_node_put(ports); > a5psw_pcs_free(a5psw);
diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c index 3e910da98ae2..301171ee1061 100644 --- a/drivers/net/dsa/rzn1_a5psw.c +++ b/drivers/net/dsa/rzn1_a5psw.c @@ -923,6 +923,7 @@ static int a5psw_pcs_get(struct a5psw *a5psw) return 0; free_pcs: + of_node_put(pcs_node); of_node_put(port); of_node_put(ports); a5psw_pcs_free(a5psw);
of_parse_phandle() will increase the refcount of 'pcs_node', so add of_node_put() before return from a5psw_pcs_get(). Fixes: 888cdb892b61 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/rzn1_a5psw.c | 1 + 1 file changed, 1 insertion(+)