diff mbox series

[kms-test,9/7] kmstest: Raise clear exception when property is not found

Message ID 20220731185237.11151-1-laurent.pinchart@ideasonboard.com (mailing list archive)
State New
Delegated to: Kieran Bingham
Headers show
Series Miscellaneous fixes and improvements | expand

Commit Message

Laurent Pinchart July 31, 2022, 6:52 p.m. UTC
When converting a property value string to an integer, if the property
is not found, an AttributeError exception is raised and reports that
"'NoneType' object has no attribute 'type'". This isn't very clear,
replace it with a RuntimeError with a proper message.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 tests/kmstest.py | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/tests/kmstest.py b/tests/kmstest.py
index e84d8fe859f4..3e53defc1dae 100755
--- a/tests/kmstest.py
+++ b/tests/kmstest.py
@@ -268,6 +268,8 @@  class AtomicRequest(pykms.AtomicReq):
             if isinstance(v, str):
                 if v.endswith('%'):
                     prop = obj.get_prop(k)
+                    if not prop:
+                        raise RuntimeError(f'Property {k} not supported by object {obj}')
                     if prop.type not in (pykms.PropertyType.Range, pykms.PropertyType.SignedRange):
                         raise RuntimeError(f'Unsupported property type {prop.type} for value {v}')