| Message ID | 20220829214730.5752-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings | expand |
On Mon, Aug 29, 2022 at 11:47 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > With 'unevaluatedProperties' support implemented, there's a number of > warnings when running dtbs_check: > > arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected) > From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > The main problem is that bindings schema marks resets as a required > property for RZ/G2L (and alike) SoC's but resets property is not part > of schema. So to fix this just add a resets property with maxItems > set to 1. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 30/08/2022 00:47, Lad Prabhakar wrote: > With 'unevaluatedProperties' support implemented, there's a number of > warnings when running dtbs_check: > > arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected) > From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > The main problem is that bindings schema marks resets as a required > property for RZ/G2L (and alike) SoC's but resets property is not part > of schema. So to fix this just add a resets property with maxItems > set to 1. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Aug 29, 2022 at 10:47:30PM +0100, Lad Prabhakar wrote: > With 'unevaluatedProperties' support implemented, there's a number of > warnings when running dtbs_check: > > arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected) > From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > The main problem is that bindings schema marks resets as a required > property for RZ/G2L (and alike) SoC's but resets property is not part > of schema. So to fix this just add a resets property with maxItems > set to 1. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Applied to for-current, thanks!
diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml index bb1f3c7e0e6a..2291a7cd619b 100644 --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml @@ -60,6 +60,9 @@ properties: power-domains: maxItems: 1 + resets: + maxItems: 1 + required: - compatible - reg
With 'unevaluatedProperties' support implemented, there's a number of warnings when running dtbs_check: arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected) From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml The main problem is that bindings schema marks resets as a required property for RZ/G2L (and alike) SoC's but resets property is not part of schema. So to fix this just add a resets property with maxItems set to 1. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 3 +++ 1 file changed, 3 insertions(+)