From patchwork Tue Oct 18 18:18:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 13010886 X-Patchwork-Delegate: kieran@bingham.xyz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8325C433FE for ; Tue, 18 Oct 2022 18:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiJRSSn (ORCPT ); Tue, 18 Oct 2022 14:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbiJRSSm (ORCPT ); Tue, 18 Oct 2022 14:18:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91DE180F4E; Tue, 18 Oct 2022 11:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=u1jSsa7KqxmCrkOFvnCR72ZfQLGaAXjkoUkUU1lr3G8=; b=KJi6nSw4Ag2zEO7s5ov0ONErxv fGEmJ9nNV38vIpdnD8BPWG8CEY/cFTNQ8G2Lyt0q3Qbn+JcyFAkEC09BjAGh6JLQhmm31W0Vidb2g rqe1daF/U/g1Z+D1X9f3jelTyP8XHMVgd5h1qDpf2MfEbDsA2KLSx4LVt9VS8nwBNmRo5DE/2F2uL xNS8KFJtysjer8qzcMw8dcB1va8LBi45n2sSKJF3f142famaY51K9ky6UgVOxVAyZ6AMI6PkF4whT +kGGGTsmnq9BOab4VZofipUqypVmeZcDzWICjJ951bpTSx9B27+EqObVuANkLjFczLufynTP+vXxH dOcDlTYw==; Received: from [2601:1c2:d80:3110::a2e7] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1okrAk-00AvHD-HN; Tue, 18 Oct 2022 18:18:40 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Tomi Valkeinen , Laurent Pinchart , Kieran Bingham , LUU HOAI , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, David Airlie , Daniel Vetter Subject: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI Date: Tue, 18 Oct 2022 11:18:28 -0700 Message-Id: <20221018181828.19528-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org When CONFIG_DRM_RCAR_DU=y and CONFIG_DRM_RCAR_MIPI_DSI=m, calls from the builtin driver to the mipi driver fail due to linker errors. Since the RCAR_MIPI_DSI driver is not always required, fix the build error by making DRM_RCAR_DU optionally depend on the RCAR_MIPI_DSI Kconfig symbol. This prevents the problematic kconfig combination without requiring that RCAR_MIPI_DSI always be enabled. aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': rcar_du_crtc.c:(.text+0x3a18): undefined reference to `rcar_mipi_dsi_pclk_enable' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': rcar_du_crtc.c:(.text+0x47cc): undefined reference to `rcar_mipi_dsi_pclk_disable' Fixes: 957fe62d7d15 ("drm: rcar-du: Fix DSI enable & disable sequence") Signed-off-by: Randy Dunlap Cc: Tomi Valkeinen Cc: Laurent Pinchart Cc: Kieran Bingham Cc: LUU HOAI Cc: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -4,6 +4,7 @@ config DRM_RCAR_DU depends on DRM && OF depends on ARM || ARM64 depends on ARCH_RENESAS || COMPILE_TEST + depends on DRM_RCAR_MIPI_DSI || DRM_RCAR_MIPI_DSI=n select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER select VIDEOMODE_HELPERS