| Message ID | 20230214003736.18871-2-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c95e2ad9594adf1e8088ead38420179942b5c264 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: rcar-du: Fix vblank wait timeout when stopping LVDS output | expand |
On 14/02/2023 02:37, Laurent Pinchart wrote: > When disabling the companion bridge in rcar_lvds_atomic_disable(), > there's no need to go through the bridge's operations to call > .atomic_disable(). Call rcar_lvds_atomic_disable() on the companion > directly. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 260ea5d8624e..61de18af62e6 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -582,8 +582,7 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge, > > /* Disable the companion LVDS encoder in dual-link mode. */ > if (lvds->link_type != RCAR_LVDS_SINGLE_LINK && lvds->companion) > - lvds->companion->funcs->atomic_disable(lvds->companion, > - old_bridge_state); > + rcar_lvds_atomic_disable(lvds->companion, old_bridge_state); > > pm_runtime_put_sync(lvds->dev); > } Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> Tomi
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 260ea5d8624e..61de18af62e6 100644 --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c @@ -582,8 +582,7 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge, /* Disable the companion LVDS encoder in dual-link mode. */ if (lvds->link_type != RCAR_LVDS_SINGLE_LINK && lvds->companion) - lvds->companion->funcs->atomic_disable(lvds->companion, - old_bridge_state); + rcar_lvds_atomic_disable(lvds->companion, old_bridge_state); pm_runtime_put_sync(lvds->dev); }
When disabling the companion bridge in rcar_lvds_atomic_disable(), there's no need to go through the bridge's operations to call .atomic_disable(). Call rcar_lvds_atomic_disable() on the companion directly. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)