From patchwork Tue Mar 14 13:14:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13174422 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E32C6FD1C for ; Tue, 14 Mar 2023 13:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232378AbjCNNTa (ORCPT ); Tue, 14 Mar 2023 09:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbjCNNSz (ORCPT ); Tue, 14 Mar 2023 09:18:55 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13AE2AB8BE for ; Tue, 14 Mar 2023 06:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=VjTn3E20TaRsaW HsM1MQTWl0oPBdqH1Fh0HrLM/sBLQ=; b=EQCfCw6pYRkDgljCsJYRNtEbYyyLTu go8Oyi1uENTxLGwzL8K5CG5Jl+he9MDhaqZsFZB78NH8WB6/Kn3YzIFuVdktfoqG 3WVDlFSuzWysobydUzl2tABDGnX05VuRwysFwLgGQKCk8YHpomsGfkx807wSDVK9 1QH62rX1QU9FM= Received: (qmail 3111673 invoked from network); 14 Mar 2023 14:14:57 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 14 Mar 2023 14:14:57 +0100 X-UD-Smtp-Session: l3s3148p1@5b2gA9z2ps0ujnvb From: Wolfram Sang To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Wolfram Sang , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to probe Date: Tue, 14 Mar 2023 14:14:41 +0100 Message-Id: <20230314131443.46342-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> References: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Renesas hardware, we had issues because the above flag was set during 'open'. It was concluded that it needs to be set during 'probe'. It looks like FEC needs the same fix but I can't test it because I don't have the hardware. At least, leave a note about the issue. Signed-off-by: Wolfram Sang --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index c73e25f8995e..b16f56208d66 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2318,6 +2318,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) fep->link = 0; fep->full_duplex = 0; + /* FIXME: should be set right after mdiobus is registered */ phy_dev->mac_managed_pm = true; phy_attached_info(phy_dev);