| Message ID | 20230620121202.28263-4-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm/gem-dma: Remove unnecessary calls | expand |
Hi Thomas, Thank you for the patch. On Tue, Jun 20, 2023 at 02:03:23PM +0200, Thomas Zimmermann wrote: > There are no external users of drm_gem_dma_vm_ops. Unexport the symbol. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/drm_gem_dma_helper.c | 11 +++++------ > include/drm/drm_gem_dma_helper.h | 2 -- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_dma_helper.c b/drivers/gpu/drm/drm_gem_dma_helper.c > index e9aa3ac140654..d8a415c3d156c 100644 > --- a/drivers/gpu/drm/drm_gem_dma_helper.c > +++ b/drivers/gpu/drm/drm_gem_dma_helper.c > @@ -45,6 +45,11 @@ > * drm_gem_dma_vmap()). These helpers perform the necessary type conversion. > */ > > +static const struct vm_operations_struct drm_gem_dma_vm_ops = { > + .open = drm_gem_vm_open, > + .close = drm_gem_vm_close, > +}; > + > static const struct drm_gem_object_funcs drm_gem_dma_default_funcs = { > .free = drm_gem_dma_object_free, > .print_info = drm_gem_dma_object_print_info, > @@ -315,12 +320,6 @@ int drm_gem_dma_dumb_create(struct drm_file *file_priv, > } > EXPORT_SYMBOL_GPL(drm_gem_dma_dumb_create); > > -const struct vm_operations_struct drm_gem_dma_vm_ops = { > - .open = drm_gem_vm_open, > - .close = drm_gem_vm_close, > -}; > -EXPORT_SYMBOL_GPL(drm_gem_dma_vm_ops); > - > #ifndef CONFIG_MMU > /** > * drm_gem_dma_get_unmapped_area - propose address for mapping in noMMU cases > diff --git a/include/drm/drm_gem_dma_helper.h b/include/drm/drm_gem_dma_helper.h > index 3877cbf0e927c..88a810f954fce 100644 > --- a/include/drm/drm_gem_dma_helper.h > +++ b/include/drm/drm_gem_dma_helper.h > @@ -45,8 +45,6 @@ int drm_gem_dma_vmap(struct drm_gem_dma_object *dma_obj, > struct iosys_map *map); > int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj, struct vm_area_struct *vma); > > -extern const struct vm_operations_struct drm_gem_dma_vm_ops; > - > /* > * GEM object functions > */
diff --git a/drivers/gpu/drm/drm_gem_dma_helper.c b/drivers/gpu/drm/drm_gem_dma_helper.c index e9aa3ac140654..d8a415c3d156c 100644 --- a/drivers/gpu/drm/drm_gem_dma_helper.c +++ b/drivers/gpu/drm/drm_gem_dma_helper.c @@ -45,6 +45,11 @@ * drm_gem_dma_vmap()). These helpers perform the necessary type conversion. */ +static const struct vm_operations_struct drm_gem_dma_vm_ops = { + .open = drm_gem_vm_open, + .close = drm_gem_vm_close, +}; + static const struct drm_gem_object_funcs drm_gem_dma_default_funcs = { .free = drm_gem_dma_object_free, .print_info = drm_gem_dma_object_print_info, @@ -315,12 +320,6 @@ int drm_gem_dma_dumb_create(struct drm_file *file_priv, } EXPORT_SYMBOL_GPL(drm_gem_dma_dumb_create); -const struct vm_operations_struct drm_gem_dma_vm_ops = { - .open = drm_gem_vm_open, - .close = drm_gem_vm_close, -}; -EXPORT_SYMBOL_GPL(drm_gem_dma_vm_ops); - #ifndef CONFIG_MMU /** * drm_gem_dma_get_unmapped_area - propose address for mapping in noMMU cases diff --git a/include/drm/drm_gem_dma_helper.h b/include/drm/drm_gem_dma_helper.h index 3877cbf0e927c..88a810f954fce 100644 --- a/include/drm/drm_gem_dma_helper.h +++ b/include/drm/drm_gem_dma_helper.h @@ -45,8 +45,6 @@ int drm_gem_dma_vmap(struct drm_gem_dma_object *dma_obj, struct iosys_map *map); int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj, struct vm_area_struct *vma); -extern const struct vm_operations_struct drm_gem_dma_vm_ops; - /* * GEM object functions */
There are no external users of drm_gem_dma_vm_ops. Unexport the symbol. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/drm_gem_dma_helper.c | 11 +++++------ include/drm/drm_gem_dma_helper.h | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-)