diff mbox series

[2/3] dt-bindings: PCI: rcar-gen4-pcie: Fix minor issues

Message ID 20230901131711.2861283-3-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series dt-bindings: PCI: Revise dwc and rcar-gen4-pcie | expand

Commit Message

Yoshihiro Shimoda Sept. 1, 2023, 1:17 p.m. UTC 
Fix minor issues of rcar-gen4-pci-host.yaml.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---

This patch will be squashed into the following commit on the pci.git /
controller/rcar branch so that many fixes into a patch:

dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=af285bc39885eaeed434c607a977d664916681a7
---
 .../bindings/pci/rcar-gen4-pci-host.yaml      | 36 ++++++++++---------
 1 file changed, 20 insertions(+), 16 deletions(-)

Comments

Geert Uytterhoeven Sept. 4, 2023, 8:44 a.m. UTC | #1 
On Sun, Sep 3, 2023 at 2:35 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Fix minor issues of rcar-gen4-pci-host.yaml.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>
> This patch will be squashed into the following commit on the pci.git /
> controller/rcar branch so that many fixes into a patch:
>
> dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=af285bc39885eaeed434c607a977d664916681a7

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
index 513a3416dd8e..ffb34339b637 100644
--- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
@@ -20,7 +20,7 @@  properties:
       - const: renesas,rcar-gen4-pcie  # R-Car Gen4
 
   reg:
-    maxItems: 6
+    maxItems: 7
 
   reg-names:
     items:
@@ -29,6 +29,7 @@  properties:
       - const: atu
       - const: dma
       - const: app
+      - const: phy
       - const: config
 
   interrupts:
@@ -55,7 +56,7 @@  properties:
   resets:
     maxItems: 1
 
-  resets-names:
+  reset-names:
     items:
       - const: pwr
 
@@ -68,7 +69,9 @@  properties:
 required:
   - compatible
   - reg
+  - reg-names
   - interrupts
+  - interrupt-names
   - clocks
   - clock-names
   - power-domains
@@ -91,8 +94,21 @@  examples:
             compatible = "renesas,r8a779f0-pcie", "renesas,rcar-gen4-pcie";
             reg = <0 0xe65d0000 0 0x1000>, <0 0xe65d2000 0 0x0800>,
                   <0 0xe65d3000 0 0x2000>, <0 0xe65d5000 0 0x1200>,
-                  <0 0xe65d6200 0 0x0e00>, <0 0xfe000000 0 0x400000>;
-            reg-names = "dbi", "dbi2", "atu", "dma", "app", "config";
+                  <0 0xe65d6200 0 0x0e00>, <0 0xe65d7000 0 0x0400>,
+                  <0 0xfe000000 0 0x400000>;
+            reg-names = "dbi", "dbi2", "atu", "dma", "app", "phy", "config";
+            interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
+                         <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
+                         <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
+                         <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>;
+            interrupt-names = "msi", "dma", "sft_ce", "app";
+            clocks = <&cpg CPG_MOD 624>, <&pcie0_clkref>;
+            clock-names = "core", "ref";
+            power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+            resets = <&cpg 624>;
+            reset-names = "pwr";
+            max-link-speed = <4>;
+            num-lanes = <2>;
             #address-cells = <3>;
             #size-cells = <2>;
             bus-range = <0x00 0xff>;
@@ -100,24 +116,12 @@  examples:
             ranges = <0x01000000 0 0x00000000 0 0xfe000000 0 0x00400000>,
                      <0x02000000 0 0x30000000 0 0x30000000 0 0x10000000>;
             dma-ranges = <0x42000000 0 0x00000000 0 0x00000000 1 0x00000000>;
-            interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>;
-            interrupt-names = "msi", "dma", "sft_ce", "app";
             #interrupt-cells = <1>;
             interrupt-map-mask = <0 0 0 7>;
             interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
                             <0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
                             <0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
                             <0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>;
-            clocks = <&cpg CPG_MOD 624>, <&clkref>;
-            clock-names = "core", "ref";
-            power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
-            resets = <&cpg 624>;
-            reset-names = "pwr";
-            num-lanes = <2>;
             snps,enable-cdm-check;
-            max-link-speed = <4>;
         };
     };