| Message ID | 20230906094346.38759-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video() | expand |
On Wed, Sep 6, 2023 at 11:44 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Add missing space in the comment in rzg2l_mipi_dsi_start_video(). > > Reported-by: Pavel Machek <pavel@denx.de> > Closes: https://lore.kernel.org/all/ZPg7STHDn4LbLy7f@duo.ucw.cz/ > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Biju, Thank you for the patch. On Wed, Sep 06, 2023 at 10:43:46AM +0100, Biju Das wrote: > Add missing space in the comment in rzg2l_mipi_dsi_start_video(). > > Reported-by: Pavel Machek <pavel@denx.de> > Closes: https://lore.kernel.org/all/ZPg7STHDn4LbLy7f@duo.ucw.cz/ > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > This issue is noticed while backporting this driver to 6.1.y-cip [1]. > > [1] https://lore.kernel.org/all/20230905160737.167877-1-biju.das.jz@bp.renesas.com/ > --- > drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > index 10febea473cd..9b5cfdd3e1c5 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct rzg2l_mipi_dsi *dsi) > u32 status; > int ret; > > - /* Configuration for Blanking sequence and start video input*/ > + /* Configuration for Blanking sequence and start video input */ > vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP | > VICH1SET0R_HSANOLP | VICH1SET0R_VSTART; > rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
Hi Biju, On Thu, Nov 16, 2023 at 10:58:56AM +0000, Biju Das wrote: > Hi All, > > Gentle ping. It is reviewed by both Laurent and Geert. > > Can it be applied to drm-misc-next, if everyone is happy with this patch? Yes, now that v6.7-rc1 is out I'll send pull requests shortly. > > From: Biju Das <biju.das.jz@bp.renesas.com> > > Sent: Wednesday, September 6, 2023 10:44 AM > > Subject: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment > > in rzg2l_mipi_dsi_start_video() > > > > Add missing space in the comment in rzg2l_mipi_dsi_start_video(). > > > > Reported-by: Pavel Machek <pavel@denx.de> > > Closes: > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > This issue is noticed while backporting this driver to 6.1.y-cip [1]. > > > > [1] > > --- > > drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > index 10febea473cd..9b5cfdd3e1c5 100644 > > --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct > > rzg2l_mipi_dsi *dsi) > > u32 status; > > int ret; > > > > - /* Configuration for Blanking sequence and start video input*/ > > + /* Configuration for Blanking sequence and start video input */ > > vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP | > > VICH1SET0R_HSANOLP | VICH1SET0R_VSTART; > > rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
Hi Laurent, > Subject: Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the > comment in rzg2l_mipi_dsi_start_video() > > Hi Biju, > > On Thu, Nov 16, 2023 at 10:58:56AM +0000, Biju Das wrote: > > Hi All, > > > > Gentle ping. It is reviewed by both Laurent and Geert. > > > > Can it be applied to drm-misc-next, if everyone is happy with this > patch? > > Yes, now that v6.7-rc1 is out I'll send pull requests shortly. Looks like you missed this patch. Cheers, Biju > > > > From: Biju Das <biju.das.jz@bp.renesas.com> > > > Sent: Wednesday, September 6, 2023 10:44 AM > > > Subject: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the > > > comment in rzg2l_mipi_dsi_start_video() > > > > > > Add missing space in the comment in rzg2l_mipi_dsi_start_video(). > > > > > > Reported-by: Pavel Machek <pavel@denx.de> > > > Closes: > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > This issue is noticed while backporting this driver to 6.1.y-cip [1]. > > > > > > [1] > > > --- > > > drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > > b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > > index 10febea473cd..9b5cfdd3e1c5 100644 > > > --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > > +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > > > @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct > > > rzg2l_mipi_dsi *dsi) > > > u32 status; > > > int ret; > > > > > > - /* Configuration for Blanking sequence and start video input*/ > > > + /* Configuration for Blanking sequence and start video input */ > > > vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP | > > > VICH1SET0R_HSANOLP | VICH1SET0R_VSTART; > > > rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r); > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c index 10febea473cd..9b5cfdd3e1c5 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct rzg2l_mipi_dsi *dsi) u32 status; int ret; - /* Configuration for Blanking sequence and start video input*/ + /* Configuration for Blanking sequence and start video input */ vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP | VICH1SET0R_HSANOLP | VICH1SET0R_VSTART; rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
Add missing space in the comment in rzg2l_mipi_dsi_start_video(). Reported-by: Pavel Machek <pavel@denx.de> Closes: https://lore.kernel.org/all/ZPg7STHDn4LbLy7f@duo.ucw.cz/ Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- This issue is noticed while backporting this driver to 6.1.y-cip [1]. [1] https://lore.kernel.org/all/20230905160737.167877-1-biju.das.jz@bp.renesas.com/ --- drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)