| Message ID | 20230922065331.3806925-13-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | PCI: dwc: rcar-gen4: Add R-Car Gen4 PCIe support | expand |
On Fri, Sep 22, 2023 at 03:53:27PM +0900, Yoshihiro Shimoda wrote: > According to the PCI Express Card Electromechanical Specification, > Power stable to PERST# inactive interval is 100 ms as minimum. > So, add the macro to use PCIe controller drivers. > "Add a macro so that the PCIe controller drivers can make use of it." > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/pci.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h > index 39a8932dc340..5ecbcf041179 100644 > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -13,6 +13,9 @@ > > #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000 > > +/* Power stable to PERST# inactive from PCIe card Electromechanical Spec */ > +#define PCIE_T_PVPERL_MS 100 > + > /* > * PCIe r6.0, sec 5.3.3.2.1 <PME Synchronization> > * Recommends 1ms to 10ms timeout to check L2 ready. > -- > 2.25.1 >
Hello Manivannan, > From: Manivannan Sadhasivam, Sent: Tuesday, October 10, 2023 8:31 PM > > On Fri, Sep 22, 2023 at 03:53:27PM +0900, Yoshihiro Shimoda wrote: > > According to the PCI Express Card Electromechanical Specification, > > Power stable to PERST# inactive interval is 100 ms as minimum. > > So, add the macro to use PCIe controller drivers. > > > > "Add a macro so that the PCIe controller drivers can make use of it." I'll revise this. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thank you for your review! Best regards, Yoshihiro Shimoda > - Mani > > > --- > > drivers/pci/pci.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h > > index 39a8932dc340..5ecbcf041179 100644 > > --- a/drivers/pci/pci.h > > +++ b/drivers/pci/pci.h > > @@ -13,6 +13,9 @@ > > > > #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000 > > > > +/* Power stable to PERST# inactive from PCIe card Electromechanical Spec */ > > +#define PCIE_T_PVPERL_MS 100 > > + > > /* > > * PCIe r6.0, sec 5.3.3.2.1 <PME Synchronization> > > * Recommends 1ms to 10ms timeout to check L2 ready. > > -- > > 2.25.1 > > > > -- > மணிவண்ணன் சதாசிவம்
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 39a8932dc340..5ecbcf041179 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -13,6 +13,9 @@ #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000 +/* Power stable to PERST# inactive from PCIe card Electromechanical Spec */ +#define PCIE_T_PVPERL_MS 100 + /* * PCIe r6.0, sec 5.3.3.2.1 <PME Synchronization> * Recommends 1ms to 10ms timeout to check L2 ready.
According to the PCI Express Card Electromechanical Specification, Power stable to PERST# inactive interval is 100 ms as minimum. So, add the macro to use PCIe controller drivers. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/pci/pci.h | 3 +++ 1 file changed, 3 insertions(+)