| Message ID | 20231016054755.915155-6-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [01/12] riscv: RISCV_NONSTANDARD_CACHE_OPS shouldn't depend on RISCV_DMA_NONCOHERENT | expand |
On 16/10/2023 6:47 am, Christoph Hellwig wrote: > CONFIG_DMA_GLOBAL_POOL can't be combined with other DMA coherent > allocators. Add dependencies to Kconfig to document this, and make > kconfig complain about unment dependencies if someone tries. Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > kernel/dma/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > index f488997b071712..4524db877eba36 100644 > --- a/kernel/dma/Kconfig > +++ b/kernel/dma/Kconfig > @@ -135,6 +135,8 @@ config DMA_COHERENT_POOL > > config DMA_GLOBAL_POOL > select DMA_DECLARE_COHERENT > + depends on !ARCH_HAS_DMA_SET_UNCACHED > + depends on !DMA_DIRECT_REMAP > bool > > config DMA_DIRECT_REMAP
On Mon, Oct 16, 2023 at 6:48 AM Christoph Hellwig <hch@lst.de> wrote: > > CONFIG_DMA_GLOBAL_POOL can't be combined with other DMA coherent > allocators. Add dependencies to Kconfig to document this, and make > kconfig complain about unment dependencies if someone tries. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > kernel/dma/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > index f488997b071712..4524db877eba36 100644 > --- a/kernel/dma/Kconfig > +++ b/kernel/dma/Kconfig > @@ -135,6 +135,8 @@ config DMA_COHERENT_POOL > > config DMA_GLOBAL_POOL > select DMA_DECLARE_COHERENT > + depends on !ARCH_HAS_DMA_SET_UNCACHED > + depends on !DMA_DIRECT_REMAP > bool > > config DMA_DIRECT_REMAP > -- > 2.39.2 >
diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index f488997b071712..4524db877eba36 100644 --- a/kernel/dma/Kconfig +++ b/kernel/dma/Kconfig @@ -135,6 +135,8 @@ config DMA_COHERENT_POOL config DMA_GLOBAL_POOL select DMA_DECLARE_COHERENT + depends on !ARCH_HAS_DMA_SET_UNCACHED + depends on !DMA_DIRECT_REMAP bool config DMA_DIRECT_REMAP
CONFIG_DMA_GLOBAL_POOL can't be combined with other DMA coherent allocators. Add dependencies to Kconfig to document this, and make kconfig complain about unment dependencies if someone tries. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/dma/Kconfig | 2 ++ 1 file changed, 2 insertions(+)