| Message ID | 20231122051143.3660780-2-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 109b25d13e0054337860d44841b990d11b32d262 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | net: rswitch: Fix issues in rswitch_start_xmit() | expand |
On 22.11.2023 06:11, Yoshihiro Shimoda wrote: > The type of ret in rswitch_start_xmit() should be netdev_tx_t. So, > fix it. > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- Hi, Thanks for your patches! Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> > drivers/net/ethernet/renesas/rswitch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c > index 43a7795d6591..d53d90020904 100644 > --- a/drivers/net/ethernet/renesas/rswitch.c > +++ b/drivers/net/ethernet/renesas/rswitch.c > @@ -1504,8 +1504,8 @@ static netdev_tx_t rswitch_start_xmit(struct sk_buff *skb, struct net_device *nd > { > struct rswitch_device *rdev = netdev_priv(ndev); > struct rswitch_gwca_queue *gq = rdev->tx_queue; > + netdev_tx_t ret = NETDEV_TX_OK; > struct rswitch_ext_desc *desc; > - int ret = NETDEV_TX_OK; > dma_addr_t dma_addr; > > if (rswitch_get_num_cur_queues(gq) >= gq->ring_size - 1) {
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c index 43a7795d6591..d53d90020904 100644 --- a/drivers/net/ethernet/renesas/rswitch.c +++ b/drivers/net/ethernet/renesas/rswitch.c @@ -1504,8 +1504,8 @@ static netdev_tx_t rswitch_start_xmit(struct sk_buff *skb, struct net_device *nd { struct rswitch_device *rdev = netdev_priv(ndev); struct rswitch_gwca_queue *gq = rdev->tx_queue; + netdev_tx_t ret = NETDEV_TX_OK; struct rswitch_ext_desc *desc; - int ret = NETDEV_TX_OK; dma_addr_t dma_addr; if (rswitch_get_num_cur_queues(gq) >= gq->ring_size - 1) {
The type of ret in rswitch_start_xmit() should be netdev_tx_t. So, fix it. Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/net/ethernet/renesas/rswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)