| Message ID | 20231128080439.852467-5-claudiu.beznea.uj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 6f32c086602050fc11157adeafaa1c1eb393f0af |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | net: ravb: Fixes for the ravb driver | expand |
On Tue, Nov 28, 2023 at 1:35 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > ravb_phy_start() may fail. If that happens, the TX queues will remain > started. Thus, move the netif_tx_start_all_queues() after PHY is > successfully initialized. > > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > --- > > Changes in v2: > - none > > Changes since [1]: > - collected Rb tag > > [1] > https://lore.kernel.org/all/20231120084606.4083194-1-claudiu.beznea.uj@bp.renesas.com/ > > drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Looks good to me. Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > b/drivers/net/ethernet/renesas/ravb_main.c > index 62a986b5de41..2ef46c71f2bb 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -1812,13 +1812,13 @@ static int ravb_open(struct net_device *ndev) > if (info->gptp) > ravb_ptp_init(ndev, priv->pdev); > > - netif_tx_start_all_queues(ndev); > - > /* PHY control start */ > error = ravb_phy_start(ndev); > if (error) > goto out_ptp_stop; > > + netif_tx_start_all_queues(ndev); > + > return 0; > > out_ptp_stop: > -- > 2.39.2 > > >
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 62a986b5de41..2ef46c71f2bb 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1812,13 +1812,13 @@ static int ravb_open(struct net_device *ndev) if (info->gptp) ravb_ptp_init(ndev, priv->pdev); - netif_tx_start_all_queues(ndev); - /* PHY control start */ error = ravb_phy_start(ndev); if (error) goto out_ptp_stop; + netif_tx_start_all_queues(ndev); + return 0; out_ptp_stop: