diff mbox series

[v2] arm64: defconfig: Enable Renesas DA9062 PMIC

Message ID 20240226200157.428896-1-biju.das.jz@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series [v2] arm64: defconfig: Enable Renesas DA9062 PMIC | expand

Commit Message

Biju Das Feb. 26, 2024, 8:01 p.m. UTC 
Enable the config for the Renesas DA9062 PMIC and built-in RTC,
GPIO and ONKEY drivers as it is populated on RZ/{G2UL,Five}
SMARC EVK development boards.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v1->v2:
 * Enabled CONFIG_INPUT_DA9063_ONKEY and CONFIG_PINCTRL_DA9062
---
 arch/arm64/configs/defconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Geert Uytterhoeven Feb. 27, 2024, 8:29 a.m. UTC | #1 
Hi Biju,

Thanks for your patch!

On Mon, Feb 26, 2024 at 9:02 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Enable the config for the Renesas DA9062 PMIC and built-in RTC,
> GPIO and ONKEY drivers as it is populated on RZ/{G2UL,Five}
> SMARC EVK development boards.

RZ/Five is (in reality: should be) handled by a different defconfig.

>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
>  * Enabled CONFIG_INPUT_DA9063_ONKEY and CONFIG_PINCTRL_DA9062

> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -442,6 +442,7 @@ CONFIG_INPUT_TPS65219_PWRBUTTON=m
>  CONFIG_INPUT_PWM_BEEPER=m
>  CONFIG_INPUT_PWM_VIBRA=m
>  CONFIG_INPUT_RK805_PWRKEY=m
> +CONFIG_INPUT_DA9063_ONKEY=m
>  CONFIG_INPUT_HISI_POWERKEY=y
>  # CONFIG_SERIO_SERPORT is not set
>  CONFIG_SERIO_AMBAKMI=y
> @@ -559,6 +560,7 @@ CONFIG_SPI_TEGRA114=m
>  CONFIG_SPI_SPIDEV=m
>  CONFIG_SPMI=y
>  CONFIG_SPMI_MTK_PMIF=m
> +CONFIG_PINCTRL_DA9062=m
>  CONFIG_PINCTRL_MAX77620=y
>  CONFIG_PINCTRL_RK805=m
>  CONFIG_PINCTRL_SINGLE=y
> @@ -724,6 +726,7 @@ CONFIG_MFD_ALTERA_SYSMGR=y
>  CONFIG_MFD_BD9571MWV=y
>  CONFIG_MFD_AXP20X_I2C=y
>  CONFIG_MFD_AXP20X_RSB=y
> +CONFIG_MFD_DA9062=y

Given all other DA9062-related options are modular, shouldn't this be
modular, too?

>  CONFIG_MFD_EXYNOS_LPASS=m
>  CONFIG_MFD_HI6421_PMIC=y
>  CONFIG_MFD_HI655X_PMIC=y
> @@ -1166,6 +1169,7 @@ CONFIG_RTC_DRV_RV8803=m
>  CONFIG_RTC_DRV_S5M=y
>  CONFIG_RTC_DRV_DS3232=y
>  CONFIG_RTC_DRV_PCF2127=m
> +CONFIG_RTC_DRV_DA9063=m
>  CONFIG_RTC_DRV_EFI=y
>  CONFIG_RTC_DRV_CROS_EC=y
>  CONFIG_RTC_DRV_FSL_FTM_ALARM=m

Gr{oetje,eeting}s,

                        Geert
Biju Das Feb. 27, 2024, 12:13 p.m. UTC | #2 
Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Tuesday, February 27, 2024 8:30 AM
> Subject: Re: [PATCH v2] arm64: defconfig: Enable Renesas DA9062 PMIC
> 
> Hi Biju,
> 
> Thanks for your patch!
> 
> On Mon, Feb 26, 2024 at 9:02 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Enable the config for the Renesas DA9062 PMIC and built-in RTC, GPIO
> > and ONKEY drivers as it is populated on RZ/{G2UL,Five} SMARC EVK
> > development boards.
> 
> RZ/Five is (in reality: should be) handled by a different defconfig.

Oops, will update the commit description.

> 
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v1->v2:
> >  * Enabled CONFIG_INPUT_DA9063_ONKEY and CONFIG_PINCTRL_DA9062
> 
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -442,6 +442,7 @@ CONFIG_INPUT_TPS65219_PWRBUTTON=m
> > CONFIG_INPUT_PWM_BEEPER=m  CONFIG_INPUT_PWM_VIBRA=m
> > CONFIG_INPUT_RK805_PWRKEY=m
> > +CONFIG_INPUT_DA9063_ONKEY=m
> >  CONFIG_INPUT_HISI_POWERKEY=y
> >  # CONFIG_SERIO_SERPORT is not set
> >  CONFIG_SERIO_AMBAKMI=y
> > @@ -559,6 +560,7 @@ CONFIG_SPI_TEGRA114=m  CONFIG_SPI_SPIDEV=m
> > CONFIG_SPMI=y  CONFIG_SPMI_MTK_PMIF=m
> > +CONFIG_PINCTRL_DA9062=m
> >  CONFIG_PINCTRL_MAX77620=y
> >  CONFIG_PINCTRL_RK805=m
> >  CONFIG_PINCTRL_SINGLE=y
> > @@ -724,6 +726,7 @@ CONFIG_MFD_ALTERA_SYSMGR=y  CONFIG_MFD_BD9571MWV=y
> > CONFIG_MFD_AXP20X_I2C=y  CONFIG_MFD_AXP20X_RSB=y
> > +CONFIG_MFD_DA9062=y
> 
> Given all other DA9062-related options are modular, shouldn't this be
> modular, too?

OK, will make this as modular.

Cheers,
Biju

> 
> >  CONFIG_MFD_EXYNOS_LPASS=m
> >  CONFIG_MFD_HI6421_PMIC=y
> >  CONFIG_MFD_HI655X_PMIC=y
> > @@ -1166,6 +1169,7 @@ CONFIG_RTC_DRV_RV8803=m  CONFIG_RTC_DRV_S5M=y
> > CONFIG_RTC_DRV_DS3232=y  CONFIG_RTC_DRV_PCF2127=m
> > +CONFIG_RTC_DRV_DA9063=m
> >  CONFIG_RTC_DRV_EFI=y
> >  CONFIG_RTC_DRV_CROS_EC=y
> >  CONFIG_RTC_DRV_FSL_FTM_ALARM=m
>
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 34681284043f..0a9c3c0f6c47 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -442,6 +442,7 @@  CONFIG_INPUT_TPS65219_PWRBUTTON=m
 CONFIG_INPUT_PWM_BEEPER=m
 CONFIG_INPUT_PWM_VIBRA=m
 CONFIG_INPUT_RK805_PWRKEY=m
+CONFIG_INPUT_DA9063_ONKEY=m
 CONFIG_INPUT_HISI_POWERKEY=y
 # CONFIG_SERIO_SERPORT is not set
 CONFIG_SERIO_AMBAKMI=y
@@ -559,6 +560,7 @@  CONFIG_SPI_TEGRA114=m
 CONFIG_SPI_SPIDEV=m
 CONFIG_SPMI=y
 CONFIG_SPMI_MTK_PMIF=m
+CONFIG_PINCTRL_DA9062=m
 CONFIG_PINCTRL_MAX77620=y
 CONFIG_PINCTRL_RK805=m
 CONFIG_PINCTRL_SINGLE=y
@@ -724,6 +726,7 @@  CONFIG_MFD_ALTERA_SYSMGR=y
 CONFIG_MFD_BD9571MWV=y
 CONFIG_MFD_AXP20X_I2C=y
 CONFIG_MFD_AXP20X_RSB=y
+CONFIG_MFD_DA9062=y
 CONFIG_MFD_EXYNOS_LPASS=m
 CONFIG_MFD_HI6421_PMIC=y
 CONFIG_MFD_HI655X_PMIC=y
@@ -1166,6 +1169,7 @@  CONFIG_RTC_DRV_RV8803=m
 CONFIG_RTC_DRV_S5M=y
 CONFIG_RTC_DRV_DS3232=y
 CONFIG_RTC_DRV_PCF2127=m
+CONFIG_RTC_DRV_DA9063=m
 CONFIG_RTC_DRV_EFI=y
 CONFIG_RTC_DRV_CROS_EC=y
 CONFIG_RTC_DRV_FSL_FTM_ALARM=m