| Message ID | 20240410181521.269431-4-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v2,1/4] dt-bindings: PCI: cdns,cdns-pcie-host: drop redundant msi-parent and pci-bus.yaml | expand |
On Wed, 10 Apr 2024 20:15:21 +0200, Krzysztof Kozlowski wrote: > dtschema package with core schemas deprecated pci-bus.yaml schema in > favor of individual schemas per host, device and pci-pci. > > Switch Mediatek MT7621 PCIe host bridge binding to this new schema. > > This requires dtschema package newer than v2024.02 to work fully. > v2024.02 will partially work: with a warning. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Important: v2024.03 (said dtschema newer than v2024.02) was not yet > released, therefore this patch probably should wait a bit. Previous > patches do not depend anyhow on future release, so they can be taken as > is. > > Changes in v2: > 1. New patch > 2. Split mediatek,mt7621-pcie to separate patch as it uses > pci-pci-bridge schema. > --- > .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@1e140000: pcie@0,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@1e140000: pcie@1,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@1e140000: pcie@2,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410181521.269431-4-krzysztof.kozlowski@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml index 61d027239910..6fba42156db6 100644 --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml @@ -14,7 +14,7 @@ description: |+ with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link allOf: - - $ref: /schemas/pci/pci-bus.yaml# + - $ref: /schemas/pci/pci-host-bridge.yaml# properties: compatible: @@ -33,7 +33,7 @@ properties: patternProperties: '^pcie@[0-2],0$': type: object - $ref: /schemas/pci/pci-bus.yaml# + $ref: /schemas/pci/pci-pci-bridge.yaml# properties: reg:
dtschema package with core schemas deprecated pci-bus.yaml schema in favor of individual schemas per host, device and pci-pci. Switch Mediatek MT7621 PCIe host bridge binding to this new schema. This requires dtschema package newer than v2024.02 to work fully. v2024.02 will partially work: with a warning. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Important: v2024.03 (said dtschema newer than v2024.02) was not yet released, therefore this patch probably should wait a bit. Previous patches do not depend anyhow on future release, so they can be taken as is. Changes in v2: 1. New patch 2. Split mediatek,mt7621-pcie to separate patch as it uses pci-pci-bridge schema. --- .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)