| Message ID | 20240506175255.24394-3-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: v4l2-subdev: Support const-awareness in state accessors | expand |
Just passed by this one ... Le lundi 06 mai 2024 à 20:52 +0300, Laurent Pinchart a écrit : > Several subdev state pointers are used to access the state read-only. > Mark them as const. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 8 ++++---- > drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > index e45a213baf49..91301d17d356 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > @@ -173,7 +173,7 @@ static void rkisp1_gasket_disable(struct rkisp1_device *rkisp1) > * or at the frame end interrupt > */ > static void rkisp1_config_ism(struct rkisp1_isp *isp, > - struct v4l2_subdev_state *sd_state) > + const struct v4l2_subdev_state *sd_state) > { > const struct v4l2_rect *src_crop = > v4l2_subdev_state_get_crop(sd_state, > @@ -201,7 +201,7 @@ static void rkisp1_config_ism(struct rkisp1_isp *isp, > * configure ISP blocks with input format, size...... > */ > static int rkisp1_config_isp(struct rkisp1_isp *isp, > - struct v4l2_subdev_state *sd_state, > + const struct v4l2_subdev_state *sd_state, > enum v4l2_mbus_type mbus_type, u32 mbus_flags) > { > struct rkisp1_device *rkisp1 = isp->rkisp1; > @@ -309,7 +309,7 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp, > if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) { > rkisp1_params_disable(&rkisp1->params); > } else { > - struct v4l2_mbus_framefmt *src_frm; > + const struct v4l2_mbus_framefmt *src_frm; > > src_frm = v4l2_subdev_state_get_format(sd_state, > RKISP1_ISP_PAD_SOURCE_VIDEO); > @@ -429,7 +429,7 @@ static void rkisp1_config_clk(struct rkisp1_isp *isp) > } > > static int rkisp1_isp_start(struct rkisp1_isp *isp, > - struct v4l2_subdev_state *sd_state, > + const struct v4l2_subdev_state *sd_state, > struct media_pad *source) > { > struct rkisp1_device *rkisp1 = isp->rkisp1; > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > index 6f3931ca5b51..1fa991227fa9 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > @@ -135,11 +135,11 @@ static void rkisp1_dcrop_disable(struct rkisp1_resizer *rsz, > > /* configure dual-crop unit */ > static void rkisp1_dcrop_config(struct rkisp1_resizer *rsz, > - struct v4l2_subdev_state *sd_state) > + const struct v4l2_subdev_state *sd_state) > { > struct rkisp1_device *rkisp1 = rsz->rkisp1; > - struct v4l2_mbus_framefmt *sink_fmt; > - struct v4l2_rect *sink_crop; > + const struct v4l2_mbus_framefmt *sink_fmt; > + const struct v4l2_rect *sink_crop; > u32 dc_ctrl; > > sink_crop = v4l2_subdev_state_get_crop(sd_state, RKISP1_RSZ_PAD_SINK); > @@ -264,7 +264,7 @@ static void rkisp1_rsz_config_regs(struct rkisp1_resizer *rsz, > } > > static void rkisp1_rsz_config(struct rkisp1_resizer *rsz, > - struct v4l2_subdev_state *sd_state, > + const struct v4l2_subdev_state *sd_state, > enum rkisp1_shadow_regs_when when) > { > const struct rkisp1_rsz_yuv_mbus_info *sink_yuv_info, *src_yuv_info;
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c index e45a213baf49..91301d17d356 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -173,7 +173,7 @@ static void rkisp1_gasket_disable(struct rkisp1_device *rkisp1) * or at the frame end interrupt */ static void rkisp1_config_ism(struct rkisp1_isp *isp, - struct v4l2_subdev_state *sd_state) + const struct v4l2_subdev_state *sd_state) { const struct v4l2_rect *src_crop = v4l2_subdev_state_get_crop(sd_state, @@ -201,7 +201,7 @@ static void rkisp1_config_ism(struct rkisp1_isp *isp, * configure ISP blocks with input format, size...... */ static int rkisp1_config_isp(struct rkisp1_isp *isp, - struct v4l2_subdev_state *sd_state, + const struct v4l2_subdev_state *sd_state, enum v4l2_mbus_type mbus_type, u32 mbus_flags) { struct rkisp1_device *rkisp1 = isp->rkisp1; @@ -309,7 +309,7 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp, if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) { rkisp1_params_disable(&rkisp1->params); } else { - struct v4l2_mbus_framefmt *src_frm; + const struct v4l2_mbus_framefmt *src_frm; src_frm = v4l2_subdev_state_get_format(sd_state, RKISP1_ISP_PAD_SOURCE_VIDEO); @@ -429,7 +429,7 @@ static void rkisp1_config_clk(struct rkisp1_isp *isp) } static int rkisp1_isp_start(struct rkisp1_isp *isp, - struct v4l2_subdev_state *sd_state, + const struct v4l2_subdev_state *sd_state, struct media_pad *source) { struct rkisp1_device *rkisp1 = isp->rkisp1; diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c index 6f3931ca5b51..1fa991227fa9 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c @@ -135,11 +135,11 @@ static void rkisp1_dcrop_disable(struct rkisp1_resizer *rsz, /* configure dual-crop unit */ static void rkisp1_dcrop_config(struct rkisp1_resizer *rsz, - struct v4l2_subdev_state *sd_state) + const struct v4l2_subdev_state *sd_state) { struct rkisp1_device *rkisp1 = rsz->rkisp1; - struct v4l2_mbus_framefmt *sink_fmt; - struct v4l2_rect *sink_crop; + const struct v4l2_mbus_framefmt *sink_fmt; + const struct v4l2_rect *sink_crop; u32 dc_ctrl; sink_crop = v4l2_subdev_state_get_crop(sd_state, RKISP1_RSZ_PAD_SINK); @@ -264,7 +264,7 @@ static void rkisp1_rsz_config_regs(struct rkisp1_resizer *rsz, } static void rkisp1_rsz_config(struct rkisp1_resizer *rsz, - struct v4l2_subdev_state *sd_state, + const struct v4l2_subdev_state *sd_state, enum rkisp1_shadow_regs_when when) { const struct rkisp1_rsz_yuv_mbus_info *sink_yuv_info, *src_yuv_info;
Several subdev state pointers are used to access the state read-only. Mark them as const. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 8 ++++---- drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-)