[v9,2/9] watchdog: rzg2l_wdt: Make the driver depend on PM

Message ID	20240531065723.1085423-3-claudiu.beznea.uj@bp.renesas.com (mailing list archive)
State	Accepted
Delegated to:	Geert Uytterhoeven
Headers	show Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021E580C1F for <linux-renesas-soc@vger.kernel.org>; Fri, 31 May 2024 06:57:52 +0000 (UTC) From: Claudiu <claudiu.beznea@tuxon.dev> To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com Cc: biju.das.jz@bp.renesas.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, claudiu.beznea.uj@bp.renesas.com, kernel test robot <lkp@intel.com> Subject: [PATCH v9 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM Date: Fri, 31 May 2024 09:57:16 +0300 Message-Id: <20240531065723.1085423-3-claudiu.beznea.uj@bp.renesas.com> In-Reply-To: <20240531065723.1085423-1-claudiu.beznea.uj@bp.renesas.com> References: <20240531065723.1085423-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	watchdog: rzg2l_wdt: Add support for RZ/G3S \| expand [v9,0/9] watchdog: rzg2l_wdt: Add support for RZ/G3S [v9,1/9] watchdog: rzg2l_wdt: Restrict the driver to ARCH_RZG2L and ARCH_R9A09G011 [v9,2/9] watchdog: rzg2l_wdt: Make the driver depend on PM [v9,3/9] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() [v9,4/9] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() [v9,5/9] watchdog: rzg2l_wdt: Remove reset de-assert from probe [v9,6/9] watchdog: rzg2l_wdt: Remove comparison with zero [v9,7/9] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset [v9,8/9] watchdog: rzg2l_wdt: Add suspend/resume support [v9,9/9] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support

Message ID

20240531065723.1085423-3-claudiu.beznea.uj@bp.renesas.com (mailing list archive)

State

Accepted

Delegated to:

Geert Uytterhoeven

Headers

From: Claudiu <claudiu.beznea@tuxon.dev>
To: wim@linux-watchdog.org,
	linux@roeck-us.net,
	robh@kernel.org,
	krzk+dt@kernel.org,
	conor+dt@kernel.org,
	p.zabel@pengutronix.de,
	geert+renesas@glider.be,
	magnus.damm@gmail.com
Cc: biju.das.jz@bp.renesas.com,
	linux-watchdog@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	claudiu.beznea.uj@bp.renesas.com,
	kernel test robot <lkp@intel.com>
Subject: [PATCH v9 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM
Date: Fri, 31 May 2024 09:57:16 +0300
Message-Id: <20240531065723.1085423-3-claudiu.beznea.uj@bp.renesas.com>
In-Reply-To: <20240531065723.1085423-1-claudiu.beznea.uj@bp.renesas.com>
References: <20240531065723.1085423-1-claudiu.beznea.uj@bp.renesas.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

watchdog: rzg2l_wdt: Add support for RZ/G3S | expand

Commit Message

Claudiu Beznea May 31, 2024, 6:57 a.m. UTC

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
clocks are enabled though pm_runtime_* specific APIs). To avoid building
a driver that doesn't work make explicit the dependency on CONFIG_PM.

Suggested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---

Changes in v9:
- collected Guenter's Rb tag

Changes in v8:
- collected tags

Changes in v7:
- updated the dependency to PM || COMPILE_TEST to be able to
  compile-test the driver when compiling for a
  !(ARCH_RZG2L || ARCH_R9A09G011) platform and CONFIG_PM is disabled

Changes in v6:
- update patch description
- fixed the dependency on COMPILE_TEST previously introduced

Changes in v5:
- updated patch description
- added on a new line the dependency on PM and COMPILE_TEST

Changes in v4:
- s/ARCH_RENESAS/ARCH_RZG2L || ARCH_R9A09G011 due to patch 1/9

Changes in v3:
- make driver depend on PM; with that the "unmet direct dependency"
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/linux-devicetree/202402020445.TOBlFPcS-lkp@intel.com
  was also fixed
- adapt commit message

Changes in v2:
- this patch is new

 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index ecd025dd0fef..20c5f4a6f30d 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -933,6 +933,7 @@  config RENESAS_RZN1WDT
 config RENESAS_RZG2LWDT
 	tristate "Renesas RZ/G2L WDT Watchdog"
 	depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
+	depends on PM || COMPILE_TEST
 	select WATCHDOG_CORE
 	help
 	  This driver adds watchdog support for the integrated watchdogs in the

[v9,2/9] watchdog: rzg2l_wdt: Make the driver depend on PM

Commit Message

Patch