[RFC,v2,3/4] phy: renesas: phy-rcar-gen3-usb2: Control VBUSEN selection

Commit Message

Biju Das June 7, 2024, 11:37 a.m. UTC

Use regmap provided by the regulator driver to control VBUS for RZ/G2L
alike SoCs.

Signed-off-by: Biju Das <[e-mail]>
---
v1->v2:
 * Used regulator driver's regmap to handle VBUS.
---
 drivers/phy/renesas/phy-rcar-gen3-usb2.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Patch

diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
index fbab6ac0f0d1..90561b6f9597 100644
--- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
@@ -18,6 +18,7 @@ 
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 #include <linux/string.h>
 #include <linux/usb/of.h>
@@ -111,6 +112,7 @@  struct rcar_gen3_chan {
 	struct extcon_dev *extcon;
 	struct rcar_gen3_phy rphys[NUM_OF_PHYS];
 	struct regulator *vbus;
+	struct regmap *regmap;
 	struct work_struct work;
 	struct mutex lock;	/* protects rphys[...].powered */
 	enum usb_dr_mode dr_mode;
@@ -188,6 +190,10 @@  static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
 
 	dev_vdbg(ch->dev, "%s: %08x, %d\n", __func__, val, vbus);
 	if (ch->soc_no_adp_ctrl) {
+		if (vbus)
+			regmap_write(ch->regmap, 0, 0);
+		else
+			regmap_write(ch->regmap, 0, 1);
 		vbus_ctrl_reg = USB2_VBCTRL;
 		vbus_ctrl_val = USB2_VBCTRL_VBOUT;
 	}
@@ -718,7 +724,8 @@  static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
 		phy_set_drvdata(channel->rphys[i].phy, &channel->rphys[i]);
 	}
 
-	channel->vbus = devm_regulator_get_optional(dev, "vbus");
+	channel->vbus = devm_regulator_get(dev, channel->soc_no_adp_ctrl ?
+					   "usb_vbus" : "vbus");
 	if (IS_ERR(channel->vbus)) {
 		if (PTR_ERR(channel->vbus) == -EPROBE_DEFER) {
 			ret = PTR_ERR(channel->vbus);
@@ -727,6 +734,14 @@  static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
 		channel->vbus = NULL;
 	}
 
+	if (channel->soc_no_adp_ctrl && channel->vbus) {
+		channel->regmap = regulator_get_regmap(channel->vbus);
+		if (IS_ERR(channel->regmap)) {
+			ret = PTR_ERR(channel->vbus);
+			goto error;
+		}
+	}
+
 	platform_set_drvdata(pdev, channel);
 	channel->dev = dev;