| Message ID | 20240609095049.17193-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: r9a07g0{43,44,54}: Drop #address-cells/#size-cells from single child node 'endpoint@0' | expand |
Hi Biju, Thanks for your patch! On Sun, Jun 9, 2024 at 11:51 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Fix the below dtcheck_warnings reported by kernel test robot. > > dtcheck warnings: (new ones prefixed by >>) What is dtcheck? > >> arch/arm64/boot/dts/renesas/r9a07g043u.dtsi:85.11-94.6: Warning > >> (graph_child_address): /soc/video@10830000/ports/port@1: graph node > >> has single child node 'endpoint@0', #address-cells/#size-cells are > >> not necessary > >> arch/arm64/boot/dts/renesas/r9a07g043u.dtsi:120.11-129.6: Warning > >> (graph_child_address): /soc/csi2@10830400/ports/port@1: graph node > >> has single child node 'endpoint@0', #address-cells/#size-cells are > >> not necessary > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406081329.snoMrZsJ-lkp@intel.com > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi > @@ -79,12 +79,8 @@ ports { > #size-cells = <0>; > > port@1 { > - #address-cells = <1>; > - #size-cells = <0>; > - > reg = <1>; > - crucsi2: endpoint@0 { > - reg = <0>; > + crucsi2: endpoint { Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml does not document any endpoints under port@1, so I do not know which one is correct. Note that the example in the bindings also uses endpoint@0. > remote-endpoint = <&csi2cru>; > }; > }; > @@ -114,12 +110,8 @@ port@0 { > }; > > port@1 { > - #address-cells = <1>; > - #size-cells = <0>; > reg = <1>; > - > - csi2cru: endpoint@0 { > - reg = <0>; > + csi2cru: endpoint { Same comment here, instead using Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml The example in the bindings also uses endpoint@0. > remote-endpoint = <&crucsi2>; > }; > }; > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > index 88634ae43287..6a5496dbb05a 100644 > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > @@ -710,22 +710,14 @@ ports { > #size-cells = <0>; > > port@0 { > - #address-cells = <1>; > - #size-cells = <0>; > - > reg = <0>; > - cruparallel: endpoint@0 { > - reg = <0>; > + cruparallel: endpoint { This part is OK, as Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml documents that port@0 has a single endpoint without unit address. > }; > }; > > port@1 { > - #address-cells = <1>; > - #size-cells = <0>; > - > reg = <1>; > - crucsi2: endpoint@0 { > - reg = <0>; > + crucsi2: endpoint { Again, under port@1, so which one is correct? > remote-endpoint = <&csi2cru>; > }; > }; > @@ -755,12 +747,9 @@ port@0 { > }; > > port@1 { > - #address-cells = <1>; > - #size-cells = <0>; > reg = <1>; > > - csi2cru: endpoint@0 { > - reg = <0>; > + csi2cru: endpoint { Likewise. > remote-endpoint = <&crucsi2>; > }; > }; > diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > index e89bfe4085f5..f37034d136b2 100644 > --- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > @@ -715,22 +715,14 @@ ports { > #size-cells = <0>; > > port@0 { > - #address-cells = <1>; > - #size-cells = <0>; > - > reg = <0>; > - cruparallel: endpoint@0 { > - reg = <0>; > + cruparallel: endpoint { OK. > }; > }; > > port@1 { > - #address-cells = <1>; > - #size-cells = <0>; > - > reg = <1>; > - crucsi2: endpoint@0 { > - reg = <0>; > + crucsi2: endpoint { port@1, so is this correct? > remote-endpoint = <&csi2cru>; > }; > }; > @@ -760,12 +752,8 @@ port@0 { > }; > > port@1 { > - #address-cells = <1>; > - #size-cells = <0>; > reg = <1>; > - > - csi2cru: endpoint@0 { > - reg = <0>; > + csi2cru: endpoint { Likewise. > remote-endpoint = <&crucsi2>; > }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: Monday, June 10, 2024 12:57 PM > Subject: Re: [PATCH] arm64: dts: renesas: r9a07g0{43,44,54}: Drop #address-cells/#size-cells from > single child node 'endpoint@0' > > Hi Biju, > > Thanks for your patch! > > On Sun, Jun 9, 2024 at 11:51 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Fix the below dtcheck_warnings reported by kernel test robot. > > > > dtcheck warnings: (new ones prefixed by >>) > > What is dtcheck? From the report[1], it refers to make dtbs W=1 warnings. I will replace dtcheck-> make dtbs W=1 warnings to make it clear. [1] https://lore.kernel.org/oe-kbuild-all/202406081329.snoMrZsJ-lkp@intel.com/ > > > >> arch/arm64/boot/dts/renesas/r9a07g043u.dtsi:85.11-94.6: Warning > > >> (graph_child_address): /soc/video@10830000/ports/port@1: graph node > > >> has single child node 'endpoint@0', #address-cells/#size-cells are > > >> not necessary > > >> arch/arm64/boot/dts/renesas/r9a07g043u.dtsi:120.11-129.6: Warning > > >> (graph_child_address): /soc/csi2@10830400/ports/port@1: graph node > > >> has single child node 'endpoint@0', #address-cells/#size-cells are > > >> not necessary > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202406081329.snoMrZsJ-lkp@intel. > > com > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi > > @@ -79,12 +79,8 @@ ports { > > #size-cells = <0>; > > > > port@1 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > reg = <1>; > > - crucsi2: endpoint@0 { > > - reg = <0>; > > + crucsi2: endpoint { > > Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml > does not document any endpoints under port@1, so I do not know which one is correct. Will update the bindings describing missing endpoint. > Note that the example in the bindings also uses endpoint@0. will update the example. > > > remote-endpoint = <&csi2cru>; > > }; > > }; > > @@ -114,12 +110,8 @@ port@0 { > > }; > > > > port@1 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > reg = <1>; > > - > > - csi2cru: endpoint@0 { > > - reg = <0>; > > + csi2cru: endpoint { > > Same comment here, instead using > Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml > The example in the bindings also uses endpoint@0. Will update the example. > > > remote-endpoint = <&crucsi2>; > > }; > > }; > > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > > b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > > index 88634ae43287..6a5496dbb05a 100644 > > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > > @@ -710,22 +710,14 @@ ports { > > #size-cells = <0>; > > > > port@0 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > reg = <0>; > > - cruparallel: endpoint@0 { > > - reg = <0>; > > + cruparallel: endpoint { > > This part is OK, as > Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml > documents that port@0 has a single endpoint without unit address. > > > }; > > }; > > > > port@1 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > reg = <1>; > > - crucsi2: endpoint@0 { > > - reg = <0>; > > + crucsi2: endpoint { > > Again, under port@1, so which one is correct? Will update example/bindings/dts to use single endpoint. Same for below comments. Cheers, Biju > > > remote-endpoint = <&csi2cru>; > > }; > > }; > > @@ -755,12 +747,9 @@ port@0 { > > }; > > > > port@1 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > reg = <1>; > > > > - csi2cru: endpoint@0 { > > - reg = <0>; > > + csi2cru: endpoint { > > Likewise. > > > remote-endpoint = <&crucsi2>; > > }; > > }; > > diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > > b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > > index e89bfe4085f5..f37034d136b2 100644 > > --- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi > > @@ -715,22 +715,14 @@ ports { > > #size-cells = <0>; > > > > port@0 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > reg = <0>; > > - cruparallel: endpoint@0 { > > - reg = <0>; > > + cruparallel: endpoint { > > OK. > > > }; > > }; > > > > port@1 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > reg = <1>; > > - crucsi2: endpoint@0 { > > - reg = <0>; > > + crucsi2: endpoint { > > port@1, so is this correct? > > > remote-endpoint = <&csi2cru>; > > }; > > }; > > @@ -760,12 +752,8 @@ port@0 { > > }; > > > > port@1 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > reg = <1>; > > - > > - csi2cru: endpoint@0 { > > - reg = <0>; > > + csi2cru: endpoint { > > Likewise. > > > remote-endpoint = <&crucsi2>; > > }; > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But when I'm talking to > journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi index 165bfcfef3bc..e6a30a669c37 100644 --- a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi @@ -79,12 +79,8 @@ ports { #size-cells = <0>; port@1 { - #address-cells = <1>; - #size-cells = <0>; - reg = <1>; - crucsi2: endpoint@0 { - reg = <0>; + crucsi2: endpoint { remote-endpoint = <&csi2cru>; }; }; @@ -114,12 +110,8 @@ port@0 { }; port@1 { - #address-cells = <1>; - #size-cells = <0>; reg = <1>; - - csi2cru: endpoint@0 { - reg = <0>; + csi2cru: endpoint { remote-endpoint = <&crucsi2>; }; }; diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi index 88634ae43287..6a5496dbb05a 100644 --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi @@ -710,22 +710,14 @@ ports { #size-cells = <0>; port@0 { - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; - cruparallel: endpoint@0 { - reg = <0>; + cruparallel: endpoint { }; }; port@1 { - #address-cells = <1>; - #size-cells = <0>; - reg = <1>; - crucsi2: endpoint@0 { - reg = <0>; + crucsi2: endpoint { remote-endpoint = <&csi2cru>; }; }; @@ -755,12 +747,9 @@ port@0 { }; port@1 { - #address-cells = <1>; - #size-cells = <0>; reg = <1>; - csi2cru: endpoint@0 { - reg = <0>; + csi2cru: endpoint { remote-endpoint = <&crucsi2>; }; }; diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi index e89bfe4085f5..f37034d136b2 100644 --- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi @@ -715,22 +715,14 @@ ports { #size-cells = <0>; port@0 { - #address-cells = <1>; - #size-cells = <0>; - reg = <0>; - cruparallel: endpoint@0 { - reg = <0>; + cruparallel: endpoint { }; }; port@1 { - #address-cells = <1>; - #size-cells = <0>; - reg = <1>; - crucsi2: endpoint@0 { - reg = <0>; + crucsi2: endpoint { remote-endpoint = <&csi2cru>; }; }; @@ -760,12 +752,8 @@ port@0 { }; port@1 { - #address-cells = <1>; - #size-cells = <0>; reg = <1>; - - csi2cru: endpoint@0 { - reg = <0>; + csi2cru: endpoint { remote-endpoint = <&crucsi2>; }; };