| Message ID | 20240610195532.175942-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3f60497c658d2072714d097a177612d34b34aa3d |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | regulator: core: Fix modpost error "regulator_get_regmap" undefined | expand |
On Mon, Jun 10, 2024 at 08:55:32PM +0100, Biju Das wrote: > Fix the modpost error "regulator_get_regmap" undefined by adding export > symbol. > > Fixes: 04eca28cde52 ("regulator: Add helpers for low-level register access") This is fixing the user, not the initial commit...
Hi Mark Brown, > -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Monday, June 10, 2024 10:52 PM > Subject: Re: [PATCH] regulator: core: Fix modpost error "regulator_get_regmap" undefined > > On Mon, Jun 10, 2024 at 08:55:32PM +0100, Biju Das wrote: > > Fix the modpost error "regulator_get_regmap" undefined by adding > > export symbol. > > > > Fixes: 04eca28cde52 ("regulator: Add helpers for low-level register > > access") > > This is fixing the user, not the initial commit... The user(clk/tegra/clk-dfll.c) may have builtin driver and did not face this issue. So fixes tag not relevant to that user as well. Will drop the fixes tag?? If we build clk-dfll as a module we will hit the issue. But looks like this driver must be a builtin driver. Cheers, Biju
On Tue, Jun 11, 2024 at 07:16:04AM +0000, Biju Das wrote: > > This is fixing the user, not the initial commit... > The user(clk/tegra/clk-dfll.c) may have builtin driver and > did not face this issue. So fixes tag not relevant to that user as well. If you're seeing errors there must be some user? > Will drop the fixes tag?? If we build clk-dfll as a module we will hit the issue. > But looks like this driver must be a builtin driver. So that's what the fixes tag should have pointed at. It's fine, don't worry about respinning.
On Mon, 10 Jun 2024 20:55:32 +0100, Biju Das wrote: > Fix the modpost error "regulator_get_regmap" undefined by adding export > symbol. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: core: Fix modpost error "regulator_get_regmap" undefined commit: 3f60497c658d2072714d097a177612d34b34aa3d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f0379d8ad931..b0e07cac4f06 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -3396,6 +3396,7 @@ struct regmap *regulator_get_regmap(struct regulator *regulator) return map ? map : ERR_PTR(-EOPNOTSUPP); } +EXPORT_SYMBOL_GPL(regulator_get_regmap); /** * regulator_get_hardware_vsel_register - get the HW voltage selector register
Fix the modpost error "regulator_get_regmap" undefined by adding export symbol. Fixes: 04eca28cde52 ("regulator: Add helpers for low-level register access") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406110117.mk5UR3VZ-lkp@intel.com Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/regulator/core.c | 1 + 1 file changed, 1 insertion(+)