| Message ID | 20240611110402.58104-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add support for USB VBUS control for RZ/G2L SoCs | expand |
On 11/06/2024 13:03, Biju Das wrote: > The VBUS enable can be controlled by the VBOUT bit of the VBUS control > register. This register is part of usbphy-ctrl IP. > > Document the USB VBUS regulator object. > > > additionalProperties: false > > @@ -64,4 +71,9 @@ examples: > resets = <&cpg R9A07G044_USB_PRESETN>; > power-domains = <&cpg>; > #reset-cells = <1>; > + regulator-vbus { > + regulator-name = "vbus"; Messed indentation. What is the indentation of the rest? Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thanks for the feedback. > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Wednesday, June 12, 2024 7:37 AM > Subject: Re: [PATCH v3 1/6] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document USB VBUS > regulator > > On 11/06/2024 13:03, Biju Das wrote: > > The VBUS enable can be controlled by the VBOUT bit of the VBUS control > > register. This register is part of usbphy-ctrl IP. > > > > Document the USB VBUS regulator object. > > > > > > > > additionalProperties: false > > > > @@ -64,4 +71,9 @@ examples: > > resets = <&cpg R9A07G044_USB_PRESETN>; > > power-domains = <&cpg>; > > #reset-cells = <1>; > > + regulator-vbus { > > + regulator-name = "vbus"; > > Messed indentation. What is the indentation of the rest? OK, will indent with 4 spaces instead of 3. Others have indentation with 4 space chars. Cheers, Biju
diff --git a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml index 03c18611e42d..cfe479df0f41 100644 --- a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml +++ b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml @@ -42,6 +42,12 @@ properties: 0 = Port 1 Phy reset 1 = Port 2 Phy reset + regulator-vbus: + type: object + description: USB VBUS regulator + $ref: /schemas/regulator/regulator.yaml# + unevaluatedProperties: false + required: - compatible - reg @@ -49,6 +55,7 @@ required: - resets - power-domains - '#reset-cells' + - regulator-vbus additionalProperties: false @@ -64,4 +71,9 @@ examples: resets = <&cpg R9A07G044_USB_PRESETN>; power-domains = <&cpg>; #reset-cells = <1>; + regulator-vbus { + regulator-name = "vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; };
The VBUS enable can be controlled by the VBOUT bit of the VBUS control register. This register is part of usbphy-ctrl IP. Document the USB VBUS regulator object. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v3: * New patch --- .../bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)