| Message ID | 20240702094630.41485-4-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | Add support for RZ/G2UL DU IP | expand |
On Tue, Jul 02, 2024 at 10:46:13AM +0100, Biju Das wrote: > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > SoC, but has only DPI interface. > > While at it, add missing required property port@1 for RZ/G2L and RZ/V2L > SoCs. A new required property is an ABI break, it deserves more of an explanation than "in passing..." > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../bindings/display/renesas,rzg2l-du.yaml | 32 +++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > index 08e5b9478051..c0fec282fa45 100644 > --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > @@ -18,6 +18,7 @@ properties: > compatible: > oneOf: > - enum: > + - renesas,r9a07g043u-du # RZ/G2UL > - renesas,r9a07g044-du # RZ/G2{L,LC} > - items: > - enum: > @@ -60,9 +61,6 @@ properties: > $ref: /schemas/graph.yaml#/properties/port > unevaluatedProperties: false > > - required: > - - port@0 > - > unevaluatedProperties: false > > renesas,vsps: > @@ -88,6 +86,34 @@ required: > > additionalProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: renesas,r9a07g043u-du > + then: > + properties: > + ports: > + properties: > + port@0: false > + port@1: > + description: DPI > + > + required: > + - port@1 > + else: > + properties: > + ports: > + properties: > + port@0: > + description: DSI > + port@1: > + description: DPI > + > + required: > + - port@0 > + - port@1 > examples: > # RZ/G2L DU > - | > -- > 2.43.0 >
Hi Conor, Thanks for the feedback. > -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Tuesday, July 2, 2024 3:51 PM > Subject: Re: [PATCH 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > > On Tue, Jul 02, 2024 at 10:46:13AM +0100, Biju Das wrote: > > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > > SoC, but has only DPI interface. > > > > While at it, add missing required property port@1 for RZ/G2L and > > RZ/V2L SoCs. > > A new required property is an ABI break, it deserves more of an explanation than "in passing..." RZ/G2L LCDC documents both port@0 and port@1 that is described here in [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml?h=next-20240702#n59 Unfortunately missed to add port@1 as required property. Currently there is no user for the DPI interface and there is no DPI interface support in display driver. So, there is nothing for ABI breakage. I will mention in the commit description that "currently there is no user for the DPI interface and hence there won't be any ABI breakage for adding port@1 as required property for RZ/G2L and RZ/V2L SoCs". Cheers, Biju > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > .../bindings/display/renesas,rzg2l-du.yaml | 32 +++++++++++++++++-- > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > > b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > > index 08e5b9478051..c0fec282fa45 100644 > > --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > > +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > > @@ -18,6 +18,7 @@ properties: > > compatible: > > oneOf: > > - enum: > > + - renesas,r9a07g043u-du # RZ/G2UL > > - renesas,r9a07g044-du # RZ/G2{L,LC} > > - items: > > - enum: > > @@ -60,9 +61,6 @@ properties: > > $ref: /schemas/graph.yaml#/properties/port > > unevaluatedProperties: false > > > > - required: > > - - port@0 > > - > > unevaluatedProperties: false > > > > renesas,vsps: > > @@ -88,6 +86,34 @@ required: > > > > additionalProperties: false > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,r9a07g043u-du > > + then: > > + properties: > > + ports: > > + properties: > > + port@0: false > > + port@1: > > + description: DPI > > + > > + required: > > + - port@1 > > + else: > > + properties: > > + ports: > > + properties: > > + port@0: > > + description: DSI > > + port@1: > > + description: DPI > > + > > + required: > > + - port@0 > > + - port@1 > > examples: > > # RZ/G2L DU > > - | > > -- > > 2.43.0 > >
On Tue, Jul 02, 2024 at 03:33:17PM +0000, Biju Das wrote: > Hi Conor, > > Thanks for the feedback. > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Tuesday, July 2, 2024 3:51 PM > > Subject: Re: [PATCH 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > > > > On Tue, Jul 02, 2024 at 10:46:13AM +0100, Biju Das wrote: > > > Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L > > > SoC, but has only DPI interface. > > > > > > While at it, add missing required property port@1 for RZ/G2L and > > > RZ/V2L SoCs. > > > > A new required property is an ABI break, it deserves more of an explanation than "in passing..." > > RZ/G2L LCDC documents both port@0 and port@1 that is described here in [1] > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml?h=next-20240702#n59 > > Unfortunately missed to add port@1 as required property. > > Currently there is no user for the DPI interface and there is > no DPI interface support in display driver. So, there is nothing > for ABI breakage. > > I will mention in the commit description that > "currently there is no user for the DPI interface > and hence there won't be any ABI breakage for adding > port@1 as required property for RZ/G2L and RZ/V2L SoCs". That seems reasonable. You can add my Acked-by with that wording update. Thanks, Conor.
Hi Conor, > -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Tuesday, July 2, 2024 4:36 PM > To: Biju Das <biju.das.jz@bp.renesas.com> > Subject: Re: [PATCH 3/9] dt-bindings: display: renesas,rzg2l-du: Document RZ/G2UL DU bindings > > On Tue, Jul 02, 2024 at 03:33:17PM +0000, Biju Das wrote: > > Hi Conor, > > > > Thanks for the feedback. > > > > > -----Original Message----- > > > From: Conor Dooley <conor@kernel.org> > > > Sent: Tuesday, July 2, 2024 3:51 PM > > > Subject: Re: [PATCH 3/9] dt-bindings: display: renesas,rzg2l-du: > > > Document RZ/G2UL DU bindings > > > > > > On Tue, Jul 02, 2024 at 10:46:13AM +0100, Biju Das wrote: > > > > Document DU found in RZ/G2UL SoC. The DU block is identical to > > > > RZ/G2L SoC, but has only DPI interface. > > > > > > > > While at it, add missing required property port@1 for RZ/G2L and > > > > RZ/V2L SoCs. > > > > > > A new required property is an ABI break, it deserves more of an explanation than "in passing..." > > > > RZ/G2L LCDC documents both port@0 and port@1 that is described here in > > [1] > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tr > > ee/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml?h=n > > ext-20240702#n59 > > > > Unfortunately missed to add port@1 as required property. > > > > Currently there is no user for the DPI interface and there is no DPI > > interface support in display driver. So, there is nothing for ABI > > breakage. > > > > I will mention in the commit description that "currently there is no > > user for the DPI interface and hence there won't be any ABI breakage > > for adding > > port@1 as required property for RZ/G2L and RZ/V2L SoCs". > > That seems reasonable. You can add my Acked-by with that wording update. OK, will do. Thanks, Biju
diff --git a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml index 08e5b9478051..c0fec282fa45 100644 --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml @@ -18,6 +18,7 @@ properties: compatible: oneOf: - enum: + - renesas,r9a07g043u-du # RZ/G2UL - renesas,r9a07g044-du # RZ/G2{L,LC} - items: - enum: @@ -60,9 +61,6 @@ properties: $ref: /schemas/graph.yaml#/properties/port unevaluatedProperties: false - required: - - port@0 - unevaluatedProperties: false renesas,vsps: @@ -88,6 +86,34 @@ required: additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + const: renesas,r9a07g043u-du + then: + properties: + ports: + properties: + port@0: false + port@1: + description: DPI + + required: + - port@1 + else: + properties: + ports: + properties: + port@0: + description: DSI + port@1: + description: DPI + + required: + - port@0 + - port@1 examples: # RZ/G2L DU - |
Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L SoC, but has only DPI interface. While at it, add missing required property port@1 for RZ/G2L and RZ/V2L SoCs. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- .../bindings/display/renesas,rzg2l-du.yaml | 32 +++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-)