| Message ID | 20240731164935.308994-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE | expand |
Hi Biju, Thank you for the patch. On Wed, Jul 31, 2024 at 05:49:32PM +0100, Biju Das wrote: > The rzg2l-csi2 driver can be compiled as a module, but lacks > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > Fix this. > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > index e68fcdaea207..c7fdee347ac8 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > { .compatible = "renesas,rzg2l-csi2", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > static struct platform_driver rzg2l_csi2_pdrv = { > .remove_new = rzg2l_csi2_remove,
Hi Media folks, Gentle ping. Is this simple fix OK to everyone? Cheers, Biju > -----Original Message----- > From: Biju Das <biju.das.jz@bp.renesas.com> > Sent: Wednesday, July 31, 2024 5:50 PM > Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE > > The rzg2l-csi2 driver can be compiled as a module, but lacks > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > Fix this. > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > index e68fcdaea207..c7fdee347ac8 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > { .compatible = "renesas,rzg2l-csi2", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > static struct platform_driver rzg2l_csi2_pdrv = { > .remove_new = rzg2l_csi2_remove, > -- > 2.43.0
On Fri, Aug 23, 2024 at 08:58:09AM +0000, Biju Das wrote: > Hi Media folks, > > Gentle ping. Is this simple fix OK to everyone? I've added the patch to my tree and will include it in my next pull request. > > -----Original Message----- > > From: Biju Das <biju.das.jz@bp.renesas.com> > > Sent: Wednesday, July 31, 2024 5:50 PM > > Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE > > > > The rzg2l-csi2 driver can be compiled as a module, but lacks > > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > > Fix this. > > > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > index e68fcdaea207..c7fdee347ac8 100644 > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > > { .compatible = "renesas,rzg2l-csi2", }, > > { /* sentinel */ } > > }; > > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > > > static struct platform_driver rzg2l_csi2_pdrv = { > > .remove_new = rzg2l_csi2_remove,
> -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: Friday, August 23, 2024 1:20 PM > Subject: Re: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing MODULE_DEVICE_TABLE > > On Fri, Aug 23, 2024 at 08:58:09AM +0000, Biju Das wrote: > > Hi Media folks, > > > > Gentle ping. Is this simple fix OK to everyone? > > I've added the patch to my tree and will include it in my next pull request. Thank you. Cheers, Biju > > > > -----Original Message----- > > > From: Biju Das <biju.das.jz@bp.renesas.com> > > > Sent: Wednesday, July 31, 2024 5:50 PM > > > Subject: [PATCH] media: platform: rzg2l-cru: rzg2l-csi2: Add missing > > > MODULE_DEVICE_TABLE > > > > > > The rzg2l-csi2 driver can be compiled as a module, but lacks > > > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > > > Fix this. > > > > > > Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 > > > receiver driver") > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > index e68fcdaea207..c7fdee347ac8 100644 > > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > > @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { > > > { .compatible = "renesas,rzg2l-csi2", }, > > > { /* sentinel */ } > > > }; > > > +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); > > > > > > static struct platform_driver rzg2l_csi2_pdrv = { > > > .remove_new = rzg2l_csi2_remove, > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index e68fcdaea207..c7fdee347ac8 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -865,6 +865,7 @@ static const struct of_device_id rzg2l_csi2_of_table[] = { { .compatible = "renesas,rzg2l-csi2", }, { /* sentinel */ } }; +MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); static struct platform_driver rzg2l_csi2_pdrv = { .remove_new = rzg2l_csi2_remove,
The rzg2l-csi2 driver can be compiled as a module, but lacks MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. Fix this. Fixes: 51e8415e39a9 ("media: platform: Add Renesas RZ/G2L MIPI CSI-2 receiver driver") Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 1 + 1 file changed, 1 insertion(+)