diff mbox series

[v4,1/9] dt-bindings: soc: renesas: Document RZ/V2H EVK board

Message ID 20240828124134.188864-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Mainlined
Commit 15bba65c1927ec8fde95611f316146d0743f16d5
Delegated to: Geert Uytterhoeven
Headers show
Series Add support for Renesas RZ/V2H(P) SoC and RZV2H-EVK platform | expand

Commit Message

Lad, Prabhakar Aug. 28, 2024, 12:41 p.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
EVK board.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
Hi Rob, I have restored your Ack with the below change, I hope that's OK.

Cheers, Prabhakar

v1->v4
- Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
- Updated commit message

v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Aug. 28, 2024, 2:34 p.m. UTC | #1 
On 28/08/2024 14:41, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
> EVK board.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
> 
> Cheers, Prabhakar
> 
> v1->v4
> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
> - Updated commit message
> 
> v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index d582992aaf0e..b7acb65bdecd 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -527,6 +527,8 @@ properties:
>  
>        - description: RZ/V2H(P) (R9A09G057)
>          items:
> +          - enum:
> +              - renesas,rzv2h-evk # RZ/V2H EVK
>            - enum:

This is unusual pattern for me, but maybe I miss here something. Commit
message does not explain why EXISTING boards needs to be changed. What
does it mean "rzv2h-evk targets evk board"? How does this work?

You have EVK board and now it is not valid anymore?


Best regards,
Krzysztof
Lad, Prabhakar Aug. 28, 2024, 8:09 p.m. UTC | #2 
Hi Krzysztof,

On Wed, Aug 28, 2024 at 3:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 28/08/2024 14:41, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
> > EVK board.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Acked-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > Hi Rob, I have restored your Ack with the below change, I hope that's OK.
> >
> > Cheers, Prabhakar
> >
> > v1->v4
> > - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
> > - Updated commit message
> >
> > v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
> > ---
> >  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > index d582992aaf0e..b7acb65bdecd 100644
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -527,6 +527,8 @@ properties:
> >
> >        - description: RZ/V2H(P) (R9A09G057)
> >          items:
> > +          - enum:
> > +              - renesas,rzv2h-evk # RZ/V2H EVK
> >            - enum:
>
> This is unusual pattern for me, but maybe I miss here something. Commit
> message does not explain why EXISTING boards needs to be changed. What
> does it mean "rzv2h-evk targets evk board"? How does this work?
>
This commit is not changing the existing boards. The entries below the
addition are the RZ/V2H(P) SoC variants. Here we are just adding the
board entry which is based on RZ/V2H SoC [0].
In the board DTS file it will be used as "compatible =
"renesas,rzv2h-evk", "renesas,r9a09g057h44", "renesas,r9a09g057";",
see [1].

               ^^                              ^^
                 ^^

              Board variant             SoC  variant
    Generic RZ/V2H SoC

> You have EVK board and now it is not valid anymore?
>
No this is not the case.

[0] https://www.renesas.com/us/en/products/microcontrollers-microprocessors/rz-mpus/rzv2h-evk-rzv2h-quad-core-vision-ai-mpu-evaluation-kit
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240828124134.188864-4-prabhakar.mahadev-lad.rj@bp.renesas.com/

Cheers,
Prabhakar
Krzysztof Kozlowski Aug. 29, 2024, 5:59 a.m. UTC | #3 
On 28/08/2024 22:09, Lad, Prabhakar wrote:
> Hi Krzysztof,
> 
> On Wed, Aug 28, 2024 at 3:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 28/08/2024 14:41, Prabhakar wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>
>>> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
>>> EVK board.
>>>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
>>>
>>> Cheers, Prabhakar
>>>
>>> v1->v4
>>> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
>>> - Updated commit message
>>>
>>> v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
>>> ---
>>>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>> index d582992aaf0e..b7acb65bdecd 100644
>>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>> @@ -527,6 +527,8 @@ properties:
>>>
>>>        - description: RZ/V2H(P) (R9A09G057)
>>>          items:
>>> +          - enum:
>>> +              - renesas,rzv2h-evk # RZ/V2H EVK
>>>            - enum:
>>
>> This is unusual pattern for me, but maybe I miss here something. Commit
>> message does not explain why EXISTING boards needs to be changed. What
>> does it mean "rzv2h-evk targets evk board"? How does this work?
>>
> This commit is not changing the existing boards. The entries below the
> addition are the RZ/V2H(P) SoC variants. Here we are just adding the
> board entry which is based on RZ/V2H SoC [0].

Then it is even more surprising to see there entries which were not
boards. What's in this file in such case?

Which DTS file it matches?

> In the board DTS file it will be used as "compatible =
> "renesas,rzv2h-evk", "renesas,r9a09g057h44", "renesas,r9a09g057";",
> see [1].
> 
>                ^^                              ^^
>                  ^^
> 
>               Board variant             SoC  variant
>     Generic RZ/V2H SoC
> 
>> You have EVK board and now it is not valid anymore?
>>
> No this is not the case.
Krzysztof
Geert Uytterhoeven Aug. 29, 2024, 7:35 a.m. UTC | #4 
Good mornin' Krzysztof,

On Thu, Aug 29, 2024 at 8:00 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 28/08/2024 22:09, Lad, Prabhakar wrote:
> > On Wed, Aug 28, 2024 at 3:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >> On 28/08/2024 14:41, Prabhakar wrote:
> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
> >>> EVK board.
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> >>> ---
> >>> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
> >>>
> >>> Cheers, Prabhakar
> >>>
> >>> v1->v4
> >>> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
> >>> - Updated commit message
> >>>
> >>> v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
> >>> ---
> >>>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> >>> index d582992aaf0e..b7acb65bdecd 100644
> >>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> >>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> >>> @@ -527,6 +527,8 @@ properties:
> >>>
> >>>        - description: RZ/V2H(P) (R9A09G057)
> >>>          items:
> >>> +          - enum:
> >>> +              - renesas,rzv2h-evk # RZ/V2H EVK
> >>>            - enum:
> >>
> >> This is unusual pattern for me, but maybe I miss here something. Commit
> >> message does not explain why EXISTING boards needs to be changed. What
> >> does it mean "rzv2h-evk targets evk board"? How does this work?
> >>
> > This commit is not changing the existing boards. The entries below the
> > addition are the RZ/V2H(P) SoC variants. Here we are just adding the
> > board entry which is based on RZ/V2H SoC [0].
>
> Then it is even more surprising to see there entries which were not
> boards. What's in this file in such case?

Before this patch, the entry that is being modified just contained
SoC variants and a fallback SoC type.
This patch documents the compatible value for the first board based
on an SoC of this type.

> Which DTS file it matches?

The one that is introduced in patch 3/9  in this series.

> > In the board DTS file it will be used as "compatible =
> > "renesas,rzv2h-evk", "renesas,r9a09g057h44", "renesas,r9a09g057";",
> > see [1].
> >
> >                ^^                              ^^
> >                  ^^
> >
> >               Board variant             SoC  variant
> >     Generic RZ/V2H SoC
> >
> >> You have EVK board and now it is not valid anymore?
> >>
> > No this is not the case.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Aug. 29, 2024, 10:09 a.m. UTC | #5 
On Wed, Aug 28, 2024 at 2:41 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
> EVK board.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
>
> Cheers, Prabhakar
>
> v1->v4
> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
> - Updated commit message

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.12.

Gr{oetje,eeting}s,

                        Geert
Krzysztof Kozlowski Aug. 30, 2024, 10:04 a.m. UTC | #6 
On 29/08/2024 09:35, Geert Uytterhoeven wrote:
> Good mornin' Krzysztof,
> 
> On Thu, Aug 29, 2024 at 8:00 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 28/08/2024 22:09, Lad, Prabhakar wrote:
>>> On Wed, Aug 28, 2024 at 3:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> On 28/08/2024 14:41, Prabhakar wrote:
>>>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>>> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
>>>>> EVK board.
>>>>>
>>>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>>>> ---
>>>>> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
>>>>>
>>>>> Cheers, Prabhakar
>>>>>
>>>>> v1->v4
>>>>> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
>>>>> - Updated commit message
>>>>>
>>>>> v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20240724094707.569596-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
>>>>> ---
>>>>>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>>>> index d582992aaf0e..b7acb65bdecd 100644
>>>>> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>>>> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
>>>>> @@ -527,6 +527,8 @@ properties:
>>>>>
>>>>>        - description: RZ/V2H(P) (R9A09G057)
>>>>>          items:
>>>>> +          - enum:
>>>>> +              - renesas,rzv2h-evk # RZ/V2H EVK
>>>>>            - enum:
>>>>
>>>> This is unusual pattern for me, but maybe I miss here something. Commit
>>>> message does not explain why EXISTING boards needs to be changed. What
>>>> does it mean "rzv2h-evk targets evk board"? How does this work?
>>>>
>>> This commit is not changing the existing boards. The entries below the
>>> addition are the RZ/V2H(P) SoC variants. Here we are just adding the
>>> board entry which is based on RZ/V2H SoC [0].
>>
>> Then it is even more surprising to see there entries which were not
>> boards. What's in this file in such case?
> 
> Before this patch, the entry that is being modified just contained
> SoC variants and a fallback SoC type.
> This patch documents the compatible value for the first board based
> on an SoC of this type.
> 
>> Which DTS file it matches?
> 
> The one that is introduced in patch 3/9  in this series.

So the binding had compatibles without board-part and obviously there
were no board-DTS files with them.

That's a less usual, so short explanation in commit msg would be helpful.

Best regards,
Krzysztof
Krzysztof Kozlowski Aug. 30, 2024, 10:04 a.m. UTC | #7 
On 28/08/2024 14:41, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Add "renesas,rzv2h-evk" which targets the Renesas RZ/V2H ("R9A09G057")
> EVK board.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Hi Rob, I have restored your Ack with the below change, I hope that's OK.
> 
> Cheers, Prabhakar
> 
> v1->v4
> - Updated 'renesas,gp-evk # GP-EVK' -> 'renesas,rzv2h-evk # RZ/V2H EVK'
> - Updated commit message

To clarify I don't have objections:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index d582992aaf0e..b7acb65bdecd 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -527,6 +527,8 @@  properties:
 
       - description: RZ/V2H(P) (R9A09G057)
         items:
+          - enum:
+              - renesas,rzv2h-evk # RZ/V2H EVK
           - enum:
               - renesas,r9a09g057h41 # RZ/V2H
               - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support