diff mbox series

[1/4] ARM: dts: renesas: marzen: use interrupts-extended for gpio-keys

Message ID 20240927095414.10241-7-wsa+renesas@sang-engineering.com (mailing list archive)
State Mainlined
Commit 17882dea8cb853e657d63512fcaef09fe3ac674f
Delegated to: Geert Uytterhoeven
Headers show
Series ARM: dts: renesas: use interrupts-extended for gpio-keys | expand

Commit Message

Wolfram Sang Sept. 27, 2024, 9:54 a.m. UTC 
Using the inherited interrupt-parent is discouraged. Use
interrupts-extended to fully describe the interrupt.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r8a7779-marzen.dts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Sept. 27, 2024, 12:29 p.m. UTC | #1 
On 27/09/2024 11:54, Wolfram Sang wrote:
> Using the inherited interrupt-parent is discouraged. Use
> interrupts-extended to fully describe the interrupt.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  arch/arm/boot/dts/renesas/r8a7779-marzen.dts | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Geert Uytterhoeven Sept. 30, 2024, 2:27 p.m. UTC | #2 
On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Using the inherited interrupt-parent is discouraged. Use
> interrupts-extended to fully describe the interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/renesas/r8a7779-marzen.dts b/arch/arm/boot/dts/renesas/r8a7779-marzen.dts
index 9b13e8d1538b..b1715bf04d84 100644
--- a/arch/arm/boot/dts/renesas/r8a7779-marzen.dts
+++ b/arch/arm/boot/dts/renesas/r8a7779-marzen.dts
@@ -58,17 +58,15 @@  keypad-0 {
 		pinctrl-0 = <&keypad0_pins>;
 		pinctrl-names = "default";
 
-		interrupt-parent = <&gpio0>;
-
 		key-1 {
-			interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
+			interrupts-extended = <&gpio0 17 IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_1>;
 			label = "SW1-1";
 			wakeup-source;
 			debounce-interval = <20>;
 		};
 		key-2 {
-			interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
+			interrupts-extended = <&gpio0 18 IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_2>;
 			label = "SW1-2";
 			wakeup-source;