| Message ID | 20240930160845.8520-8-paul@pbarker.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Extend GbEth checksum offload support to VLAN/IPv6 packets | expand |
On 9/30/24 19:08, Paul Barker wrote: > From: Paul Barker <paul.barker.ct@bp.renesas.com> > > The GbEth IP will pass through a null UDP checksum without asserting any s/null/zero/, perhaps? > error flags so we do not need to resort to software checksum calculation > in this case. > > Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 9350ca10ab22..ae0268f2eb04 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -2075,20 +2075,12 @@ static bool ravb_can_tx_csum_gbeth(struct sk_buff *skb) > > switch (ip->protocol) { > case IPPROTO_TCP: > - break; > case IPPROTO_UDP: > - /* If the checksum value in the UDP header field is 0, TOE does > - * not calculate checksum for UDP part of this frame as it is > - * optional function as per standards. > - */ > - if (udp_hdr(skb)->check == 0) > - return false; > - break; > + return true; > + No need for an empty line here, it's not used elsewhere in the *switch* statements... > default: > return false; > } [...] MBR, Sergey
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 9350ca10ab22..ae0268f2eb04 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -2075,20 +2075,12 @@ static bool ravb_can_tx_csum_gbeth(struct sk_buff *skb) switch (ip->protocol) { case IPPROTO_TCP: - break; case IPPROTO_UDP: - /* If the checksum value in the UDP header field is 0, TOE does - * not calculate checksum for UDP part of this frame as it is - * optional function as per standards. - */ - if (udp_hdr(skb)->check == 0) - return false; - break; + return true; + default: return false; } - - return true; } /* Packet transmit function for Ethernet AVB */