diff mbox series

[net-next,08/11] net: ravb: Support ICMP TX checksum offload for GbEth

Message ID 20240930160845.8520-9-paul@pbarker.dev (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series Extend GbEth checksum offload support to VLAN/IPv6 packets | expand

Commit Message

Paul Barker Sept. 30, 2024, 4:08 p.m. UTC 
From: Paul Barker <paul.barker.ct@bp.renesas.com>

This aligns TX capabilities with RX capabilities.

Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
---
 drivers/net/ethernet/renesas/ravb.h      | 2 +-
 drivers/net/ethernet/renesas/ravb_main.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Sergey Shtylyov Sept. 30, 2024, 7:48 p.m. UTC | #1 
On 9/30/24 19:08, Paul Barker wrote:

> From: Paul Barker <paul.barker.ct@bp.renesas.com>
> 
> This aligns TX capabilities with RX capabilities.

   I suspect the ICMP TX checksums aren't offloaded anywway...

> Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

MBR, Sergey
diff mbox series

Patch

diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index a5b4f4fe77b1..ef24d9f26a2e 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -998,7 +998,7 @@  enum CSR1_BIT {
 	CSR1_TDHD	= 0x08000000,
 };
 
-#define CSR1_CSUM_ENABLE (CSR1_TTCP4 | CSR1_TUDP4)
+#define CSR1_CSUM_ENABLE (CSR1_TTCP4 | CSR1_TUDP4 | CSR1_TICMP4)
 
 enum CSR2_BIT {
 	CSR2_RIP4	= 0x00000001,
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index ae0268f2eb04..69d71fbf3e02 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2076,6 +2076,7 @@  static bool ravb_can_tx_csum_gbeth(struct sk_buff *skb)
 	switch (ip->protocol) {
 	case IPPROTO_TCP:
 	case IPPROTO_UDP:
+	case IPPROTO_ICMP:
 		return true;
 
 	default: