| Message ID | 20241010135332.710648-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 603728c857a307e1c5530c24b446d875d90138dc |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: hihope: Drop #sound-dai-cells | expand |
CC morimoto-san On Thu, Oct 10, 2024 at 3:53 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > `#sound-dai-cells` is required if board is using "simple-card", and on > the hihope board we are using "audio-graph" thus remove the unneeded > `#sound-dai-cells`. > > Commit 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when > simple-card") updated the comment regarding usage of `#sound-dai-cells` > in SoC DTSI but missed to remove the `#sound-dai-cells` from board DTS > files. > > Fixes: 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when simple-card") > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.13, unless Morimoto-san objects. > diff --git a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi > index 8e2db1d6ca81..25c55b32aafe 100644 > --- a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi > @@ -69,9 +69,6 @@ &rcar_sound { > > status = "okay"; > > - /* Single DAI */ > - #sound-dai-cells = <0>; > - > rsnd_port: port { > rsnd_endpoint: endpoint { > remote-endpoint = <&dw_hdmi0_snd_in>; > diff --git a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi > index 66f3affe0469..deb69c272775 100644 > --- a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi > @@ -84,9 +84,6 @@ &rcar_sound { > pinctrl-names = "default"; > status = "okay"; > > - /* Single DAI */ > - #sound-dai-cells = <0>; > - > /* audio_clkout0/1/2/3 */ > #clock-cells = <1>; > clock-frequency = <12288000 11289600>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > `#sound-dai-cells` is required if board is using "simple-card", and on > > the hihope board we are using "audio-graph" thus remove the unneeded > > `#sound-dai-cells`. > > > > Commit 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when > > simple-card") updated the comment regarding usage of `#sound-dai-cells` > > in SoC DTSI but missed to remove the `#sound-dai-cells` from board DTS > > files. > > > > Fixes: 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when simple-card") > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v6.13, unless Morimoto-san objects. Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi index 8e2db1d6ca81..25c55b32aafe 100644 --- a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi +++ b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi @@ -69,9 +69,6 @@ &rcar_sound { status = "okay"; - /* Single DAI */ - #sound-dai-cells = <0>; - rsnd_port: port { rsnd_endpoint: endpoint { remote-endpoint = <&dw_hdmi0_snd_in>; diff --git a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi index 66f3affe0469..deb69c272775 100644 --- a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi +++ b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi @@ -84,9 +84,6 @@ &rcar_sound { pinctrl-names = "default"; status = "okay"; - /* Single DAI */ - #sound-dai-cells = <0>; - /* audio_clkout0/1/2/3 */ #clock-cells = <1>; clock-frequency = <12288000 11289600>;