| Message ID | 20241106184935.294513-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: adv7511: ADV7535 fixes | expand |
Hi Biju, On Wed, Nov 6, 2024 at 7:49 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > unsupported 1-lane from bindings. > > [1] > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf The above is for ADV7535. Fortunately https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf agrees ;-) > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > Cc: stable@vger.kernel.org > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> With the description updated: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Biju, Thank you for the patch. On Wed, Nov 06, 2024 at 06:49:29PM +0000, Biju Das wrote: > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > unsupported 1-lane from bindings. > > [1] > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf No need for a line break, you can write [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf > > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > Cc: stable@vger.kernel.org > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > v3: > * New patch. > --- > .../devicetree/bindings/display/bridge/adi,adv7533.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > index df20a3c9c744..ec89115c74e4 100644 > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > @@ -90,7 +90,7 @@ properties: > adi,dsi-lanes: > description: Number of DSI data lanes connected to the DSI host. > $ref: /schemas/types.yaml#/definitions/uint32 > - enum: [ 1, 2, 3, 4 ] > + enum: [ 2, 3, 4 ] > > "#sound-dai-cells": > const: 0
On Wed, Nov 06, 2024 at 06:49:29PM +0000, Biju Das wrote: > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > unsupported 1-lane from bindings. > > [1] > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf > > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > Cc: stable@vger.kernel.org > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v3: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 06 November 2024 19:07 > Subject: Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support > > Hi Biju, > > On Wed, Nov 6, 2024 at 7:49 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > > unsupported 1-lane from bindings. > > > > [1] > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD > > V7535.pdf > > The above is for ADV7535. Fortunately > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf > agrees ;-) > > > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > > Cc: stable@vger.kernel.org > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > With the description updated: OK, I will add the links to both devices in the escription. Cheers, Biju > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But when I'm talking to > journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Laurent, Thanks for the feedback. > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: 06 November 2024 19:31 > Subject: Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support > > Hi Biju, > > Thank you for the patch. > > On Wed, Nov 06, 2024 at 06:49:29PM +0000, Biju Das wrote: > > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > > unsupported 1-lane from bindings. > > > > [1] > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD > > V7535.pdf > > No need for a line break, you can write > > [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf Agreed. Will add the missing link for ADV7533 as well. Cheers, Biju > > > > > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > > Cc: stable@vger.kernel.org > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > --- > > v3: > > * New patch. > > --- > > .../devicetree/bindings/display/bridge/adi,adv7533.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > > b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > > index df20a3c9c744..ec89115c74e4 100644 > > --- > > a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yam > > +++ l > > @@ -90,7 +90,7 @@ properties: > > adi,dsi-lanes: > > description: Number of DSI data lanes connected to the DSI host. > > $ref: /schemas/types.yaml#/definitions/uint32 > > - enum: [ 1, 2, 3, 4 ] > > + enum: [ 2, 3, 4 ] > > > > "#sound-dai-cells": > > const: 0 > > -- > Regards, > > Laurent Pinchart
diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml index df20a3c9c744..ec89115c74e4 100644 --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml @@ -90,7 +90,7 @@ properties: adi,dsi-lanes: description: Number of DSI data lanes connected to the DSI host. $ref: /schemas/types.yaml#/definitions/uint32 - enum: [ 1, 2, 3, 4 ] + enum: [ 2, 3, 4 ] "#sound-dai-cells": const: 0
As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop unsupported 1-lane from bindings. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Cc: stable@vger.kernel.org Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v3: * New patch. --- .../devicetree/bindings/display/bridge/adi,adv7533.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)