| Message ID | 20241113225742.1784723-2-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode" | expand |
Hi Rob, On Wed, Nov 13, 2024 at 11:58 PM Rob Herring (Arm) <robh@kernel.org> wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to Not anymore ;-) https://lore.kernel.org/943cb31d01d0da3a63911326e24fbf9b328f7206.1731580776.git.geert+renesas@glider.be > the example, so just drop it. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Regardless Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On 11/14/24 1:57 AM, Rob Herring (Arm) wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to It's documented by Documentation/devicetree/bindings/net/micrel.txt... Do you mean this one should be converted to .yaml? > the example, so just drop it. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml > index 29355ab98569..ced1471c6484 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml > +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml > @@ -123,7 +123,6 @@ examples: > reg = <1>; > interrupt-parent = <&irqc0>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > - micrel,led-mode = <1>; > reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; > }; > }; MBR, Sergey
On Wed, Nov 13, 2024 at 04:57:42PM -0600, Rob Herring (Arm) wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to > the example, so just drop it. Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Wed, Nov 13, 2024 at 4:58 PM Rob Herring (Arm) <robh@kernel.org> wrote: > > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to > the example, so just drop it. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 - > 1 file changed, 1 deletion(-) I see this is marked rejected in PW. While there was some discussion, there aren't any objections to it. While micrel.txt binding is being converted now, there are some issues (with it and phy bindings in general). Keeping this property in this example will eventually require some changes to it. What phy is connected to this ethernet controller is beyond the scope of this binding, so having a specific phy is not necessary. Rob pw-bot: new
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 13 Nov 2024 16:57:42 -0600 you wrote: > "micrel,led-mode" is not yet documented by a schema. It's irrelevant to > the example, so just drop it. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next] dt-bindings: net: renesas,ether: Drop undocumented "micrel,led-mode" https://git.kernel.org/netdev/net-next/c/5bf99baefb3e You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml index 29355ab98569..ced1471c6484 100644 --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml @@ -123,7 +123,6 @@ examples: reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; - micrel,led-mode = <1>; reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; }; };
"micrel,led-mode" is not yet documented by a schema. It's irrelevant to the example, so just drop it. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- Documentation/devicetree/bindings/net/renesas,ether.yaml | 1 - 1 file changed, 1 deletion(-)