diff mbox series

[v2,11/13] arm64: dts: renesas: Add initial support for RZ/G3E SMARC SoM

Message ID 20241203105005.103927-12-biju.das.jz@bp.renesas.com (mailing list archive)
State Mainlined
Commit e0379695728b0d79c20bc1a904bb4168d4f117c0
Delegated to: Geert Uytterhoeven
Headers show
Series Add support for Renesas RZ/G3E SoC and SMARC-EVK platform | expand

Commit Message

Biju Das Dec. 3, 2024, 10:49 a.m. UTC
Add initial support for the RZ/G3E SMARC SoM with 4GB memory,
audio_extal, qextal and rtxin clks.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v1->v2:
 * No change.
---
 .../boot/dts/renesas/rzg3e-smarc-som.dtsi     | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi

Comments

Paul Barker Dec. 3, 2024, 11:28 a.m. UTC | #1
Hi Biju,

On 03/12/2024 10:49, Biju Das wrote:
> Add initial support for the RZ/G3E SMARC SoM with 4GB memory,
> audio_extal, qextal and rtxin clks.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
>  * No change.
> ---
>  .../boot/dts/renesas/rzg3e-smarc-som.dtsi     | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> 
> diff --git a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> new file mode 100644
> index 000000000000..c8cf61545a5f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Device Tree Source for the R9A09G047E57 SMARC SoM board.
> + *
> + * Copyright (C) 2024 Renesas Electronics Corp.
> + */
> +
> +/ {
> +	compatible = "renesas,rzg3e-smarc", "renesas,r9a09g047e57", "renesas,r9a09g047";

Should the first entry here be "renesas,rzg3e-smarcm" (with 'm' at the
end) to match the binding in patch 3/13?

Thanks,
Geert Uytterhoeven Dec. 12, 2024, 3:36 p.m. UTC | #2
On Tue, Dec 3, 2024 at 11:50 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add initial support for the RZ/G3E SMARC SoM with 4GB memory,
> audio_extal, qextal and rtxin clks.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
>  * No change.
> ---
>  .../boot/dts/renesas/rzg3e-smarc-som.dtsi     | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
>
> diff --git a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> new file mode 100644
> index 000000000000..c8cf61545a5f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Device Tree Source for the R9A09G047E57 SMARC SoM board.
> + *
> + * Copyright (C) 2024 Renesas Electronics Corp.
> + */
> +
> +/ {
> +       compatible = "renesas,rzg3e-smarc", "renesas,r9a09g047e57", "renesas,r9a09g047";

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.14, with s/smarc/smarcm/,
as pointed out by Paul.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Biju Das Dec. 13, 2024, 8:53 a.m. UTC | #3
Hi Geert and Paul,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 12 December 2024 15:36
> Subject: Re: [PATCH v2 11/13] arm64: dts: renesas: Add initial support for RZ/G3E SMARC SoM
> 
> On Tue, Dec 3, 2024 at 11:50 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Add initial support for the RZ/G3E SMARC SoM with 4GB memory,
> > audio_extal, qextal and rtxin clks.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v1->v2:
> >  * No change.
> > ---
> >  .../boot/dts/renesas/rzg3e-smarc-som.dtsi     | 28 +++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > new file mode 100644
> > index 000000000000..c8cf61545a5f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +/*
> > + * Device Tree Source for the R9A09G047E57 SMARC SoM board.
> > + *
> > + * Copyright (C) 2024 Renesas Electronics Corp.
> > + */
> > +
> > +/ {
> > +       compatible = "renesas,rzg3e-smarc", "renesas,r9a09g047e57",
> > +"renesas,r9a09g047";
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.14,
> with s/smarc/smarcm/, as pointed out by Paul.

Paul: Thanks for pointing out.
Geert: Thanks for fixing this.

Cheers,
Biju
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
new file mode 100644
index 000000000000..c8cf61545a5f
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
@@ -0,0 +1,28 @@ 
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/*
+ * Device Tree Source for the R9A09G047E57 SMARC SoM board.
+ *
+ * Copyright (C) 2024 Renesas Electronics Corp.
+ */
+
+/ {
+	compatible = "renesas,rzg3e-smarc", "renesas,r9a09g047e57", "renesas,r9a09g047";
+
+	memory@48000000 {
+		device_type = "memory";
+		/* First 128MB is reserved for secure area. */
+		reg = <0x0 0x48000000 0x0 0xf8000000>;
+	};
+};
+
+&audio_extal_clk {
+	clock-frequency = <48000000>;
+};
+
+&qextal_clk {
+	clock-frequency = <24000000>;
+};
+
+&rtxin_clk {
+	clock-frequency = <32768>;
+};