| Message ID | 20241206192140.1714-1-nikita.yoush@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next,1/2] net: renesas: rswitch: do not deinit disabled ports | expand |
On Sat, Dec 07, 2024 at 12:21:39AM +0500, Nikita Yushchenko wrote: > In rswitch_ether_port_init_all(), only enabled ports are initialized. > Then, rswitch_ether_port_deinit_all() shall also only deinitialize > enabled ports. > > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > --- > drivers/net/ethernet/renesas/rswitch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c > index 3b57abada200..cba80ccc3ce2 100644 > --- a/drivers/net/ethernet/renesas/rswitch.c > +++ b/drivers/net/ethernet/renesas/rswitch.c > @@ -1527,7 +1527,7 @@ static void rswitch_ether_port_deinit_all(struct rswitch_private *priv) > { > unsigned int i; > > - for (i = 0; i < RSWITCH_NUM_PORTS; i++) { > + rswitch_for_each_enabled_port(priv, i) { > phy_exit(priv->rdev[i]->serdes); > rswitch_ether_port_deinit_one(priv->rdev[i]); > } Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > -- > 2.39.5
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 7 Dec 2024 00:21:39 +0500 you wrote: > In rswitch_ether_port_init_all(), only enabled ports are initialized. > Then, rswitch_ether_port_deinit_all() shall also only deinitialize > enabled ports. > > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > --- > drivers/net/ethernet/renesas/rswitch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next,1/2] net: renesas: rswitch: do not deinit disabled ports https://git.kernel.org/netdev/net-next/c/070927427d82 - [net-next,2/2] net: renesas: rswitch: remove speed from gwca structure https://git.kernel.org/netdev/net-next/c/32fd46f5b69e You are awesome, thank you!
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c index 3b57abada200..cba80ccc3ce2 100644 --- a/drivers/net/ethernet/renesas/rswitch.c +++ b/drivers/net/ethernet/renesas/rswitch.c @@ -1527,7 +1527,7 @@ static void rswitch_ether_port_deinit_all(struct rswitch_private *priv) { unsigned int i; - for (i = 0; i < RSWITCH_NUM_PORTS; i++) { + rswitch_for_each_enabled_port(priv, i) { phy_exit(priv->rdev[i]->serdes); rswitch_ether_port_deinit_one(priv->rdev[i]); }
In rswitch_ether_port_init_all(), only enabled ports are initialized. Then, rswitch_ether_port_deinit_all() shall also only deinitialize enabled ports. Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> --- drivers/net/ethernet/renesas/rswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)