| Message ID | 20241206192140.1714-2-nikita.yoush@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next,1/2] net: renesas: rswitch: do not deinit disabled ports | expand |
On Sat, Dec 07, 2024 at 12:21:40AM +0500, Nikita Yushchenko wrote: > This field is set but never used. > > GWCA is rswitch CPU interface module which connects rswitch to the > host over AXI bus. Speed of the switch ports is not anyhow related to > GWCA operation. > > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > --- > drivers/net/ethernet/renesas/rswitch.c | 3 --- > drivers/net/ethernet/renesas/rswitch.h | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c > index cba80ccc3ce2..8ac6ef532c6a 100644 > --- a/drivers/net/ethernet/renesas/rswitch.c > +++ b/drivers/net/ethernet/renesas/rswitch.c > @@ -1902,9 +1902,6 @@ static int rswitch_device_alloc(struct rswitch_private *priv, unsigned int index > if (err < 0) > goto out_get_params; > > - if (rdev->priv->gwca.speed < rdev->etha->speed) > - rdev->priv->gwca.speed = rdev->etha->speed; > - > err = rswitch_rxdmac_alloc(ndev); > if (err < 0) > goto out_rxdmac; > diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h > index 72e3ff596d31..303883369b94 100644 > --- a/drivers/net/ethernet/renesas/rswitch.h > +++ b/drivers/net/ethernet/renesas/rswitch.h > @@ -993,7 +993,6 @@ struct rswitch_gwca { > DECLARE_BITMAP(used, RSWITCH_MAX_NUM_QUEUES); > u32 tx_irq_bits[RSWITCH_NUM_IRQ_REGS]; > u32 rx_irq_bits[RSWITCH_NUM_IRQ_REGS]; > - int speed; > }; > Nice cleanup Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> > #define NUM_QUEUES_PER_NDEV 2 > -- > 2.39.5
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c index cba80ccc3ce2..8ac6ef532c6a 100644 --- a/drivers/net/ethernet/renesas/rswitch.c +++ b/drivers/net/ethernet/renesas/rswitch.c @@ -1902,9 +1902,6 @@ static int rswitch_device_alloc(struct rswitch_private *priv, unsigned int index if (err < 0) goto out_get_params; - if (rdev->priv->gwca.speed < rdev->etha->speed) - rdev->priv->gwca.speed = rdev->etha->speed; - err = rswitch_rxdmac_alloc(ndev); if (err < 0) goto out_rxdmac; diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h index 72e3ff596d31..303883369b94 100644 --- a/drivers/net/ethernet/renesas/rswitch.h +++ b/drivers/net/ethernet/renesas/rswitch.h @@ -993,7 +993,6 @@ struct rswitch_gwca { DECLARE_BITMAP(used, RSWITCH_MAX_NUM_QUEUES); u32 tx_irq_bits[RSWITCH_NUM_IRQ_REGS]; u32 rx_irq_bits[RSWITCH_NUM_IRQ_REGS]; - int speed; }; #define NUM_QUEUES_PER_NDEV 2
This field is set but never used. GWCA is rswitch CPU interface module which connects rswitch to the host over AXI bus. Speed of the switch ports is not anyhow related to GWCA operation. Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> --- drivers/net/ethernet/renesas/rswitch.c | 3 --- drivers/net/ethernet/renesas/rswitch.h | 1 - 2 files changed, 4 deletions(-)