From patchwork Tue Feb 25 10:59:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 13989789 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29FA2267B0D for ; Tue, 25 Feb 2025 10:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740481164; cv=none; b=MXZM8BXp0/qFdOdaDkktEZ3JZBZNVs/DQXeRGuVf5JAFE6GgOZ/UL5BPDBM5CrN5xvBQgexRp+xeOSWDbL6CtR8CSqmWQUNQh7kSA/uMZ9aAvk3oLmzjQHbfuljGT1gXLuViS/aPoOGTC7wzf+px869fDyR+BxwZOBJE3OauEE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740481164; c=relaxed/simple; bh=y651O+anxjWjbDnEXvCcVWHQZHRy4LozMZWKz+3pUNc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dT0F5mz4vHxR/e8f4NwpIkcSBVMxwNz6fXy+Vhp0kdz13jSLj4YnpOfs/CmBHD0xdEIYE3IaJBlsti7h/BHy3AIm7yyBe7Wl3QTzhTTVlbhPvyIQeXcFWzRAnydtRqnE+Vc4nnLUIcQVAhOmEqhRYz6IslGH9/VLMDGD6DeCzOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=ObSs2RLa; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="ObSs2RLa" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43995b907cfso33572185e9.3 for ; Tue, 25 Feb 2025 02:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1740481160; x=1741085960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gvELEwWWQBEiORRake36OoQXvOrT2uHpRxrgYMRnO6c=; b=ObSs2RLaSgSSHKZMiGnoxHB9p0S/lH1Y5LQW5wV7NtkXcrxrPOhIYIgsl7Fm1Zzr+V iYIhjJlqTrb8CcaUiOW0By0MLacCQYbtOtW+kX0D2w72Fk90o2k9XTPtlCP+ooPzIX+N ggK8ZrrXZ4oZI3Jnx77wy09ujasS1kIYT92NynJG6agjrYWIHyvLoUT6bd98nKgWCMZN CL0T4YHdjGk0MM/0GgtQ0ui8CbvgneaE7r1EdsoVpShy72sAhwtPE9+o0BOqpH0/SX1h DArO3nc4xJWkWaYRFmZXbkoTYgTXUcxkljA87kutaoBExceFKShwnj237R0ve+OmmkEE LGYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740481160; x=1741085960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gvELEwWWQBEiORRake36OoQXvOrT2uHpRxrgYMRnO6c=; b=NMB6k71imUKIlqZazolwsiWbktjDolwcTZUn4F1OgwXw+5Rnu0YIdfx4LDz6bjtirS x1uGq4dXAyPX1S2ad1gZnxHeLYcryj1ktGjBhv68asnLub7MXw0YjcZqKFoz5HwL/+iu G9Ou22NNkCoQC9fffH5SbbX068qqvN8CiAIVoIunAv8WiqVgRDaLOEZsBiZpXi2lAQMI VkRyofVL5vb+mzQfo59jxBEDwKeMiVFMFS5gc+f/aLCJq5E3JNTQajx3/PUYyiURvtz1 RraT0FLJVHaY6uBkb/1U91Osr++xgKNy5k8+AO/u3fyeIHUUWae0ZoZs28BwebO1nz2C /Wsw== X-Forwarded-Encrypted: i=1; AJvYcCXJ6LklpA/QEeHKs4hLYwD5XI4V7TfpbGxmxX4b0fFKfE0wWAzQUgUPqyfivrAePmDLDfBZ/0yhQJTTGnuQRNaPXQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxWawsTRVUT4ANvRCE9RfTpurRwbRLEykG9FEuxMhBXWNhiPnvU k4Q42GAqWSk68xVDIsGwAyKKZ7qfJ9VPl4q5bkjQTmjSy8vNX5U0HtGBRYwH11o= X-Gm-Gg: ASbGncvVgv3E36wr69FJR/QbTsuMWeP19BHnWZoHBSUXY2F11/5UW0gt6DiQiHVzzd5 nGC46gJSxTus3nXYf2GsG2AwxS9DbzGln4YxEm57Ma+0aYDn5ViFVh7wncND1mB7+RM6uubMt6k YibN6fVEBLRQZ2P7wIs5UTI7tVzs5D3nOf3PrzPSA32lDHad0in2/855qT7xbWTjq9f7Hv6GAL7 cnV48Iq5H3mFtT3socJ3NpZtBGIfoOXjBEMkoiUgp8ImS6VjARHfLzr2WVO08hh2B4RT5CpKd8s tNBVdwGozbPHM2XMBe3kouKAjr5E9HHZ/pc6PQQPLUxyABVp23LjzX8= X-Google-Smtp-Source: AGHT+IHtRIhZcnRthP8uOU/cg1Oi5cOCbCc+gYuPmxUUUX5BgUtaRXrGdvBE+71WlZEL5TaXm3qZ/w== X-Received: by 2002:a05:600c:3111:b0:439:9f42:c137 with SMTP id 5b1f17b1804b1-43ab0f31010mr26280405e9.11.1740481160397; Tue, 25 Feb 2025 02:59:20 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.25]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ab2c50dcfsm12588815e9.0.2025.02.25.02.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 02:59:19 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: yoshihiro.shimoda.uh@renesas.com, vkoul@kernel.org, kishon@kernel.org, horms+renesas@verge.net.au, fabrizio.castro.jz@renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH v2 4/5] phy: renesas: rcar-gen3-usb2: Assert PLL reset on PHY power off Date: Tue, 25 Feb 2025 12:59:06 +0200 Message-ID: <20250225105907.845347-5-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250225105907.845347-1-claudiu.beznea.uj@bp.renesas.com> References: <20250225105907.845347-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Claudiu Beznea Assert PLL reset on PHY power off. This saves power. Fixes: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver") Cc: stable@vger.kernel.org Reviewed-by: Yoshihiro Shimoda Tested-by: Yoshihiro Shimoda Signed-off-by: Claudiu Beznea Reviewed-by: Lad Prabhakar --- Changes in v2: - collected tags - add an empty line after definition of val to get rid of the checkpatch.pl warning drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 5c0ceba09b67..21cf14ea3437 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -537,9 +537,17 @@ static int rcar_gen3_phy_usb2_power_off(struct phy *p) struct rcar_gen3_chan *channel = rphy->ch; int ret = 0; - scoped_guard(spinlock_irqsave, &channel->lock) + scoped_guard(spinlock_irqsave, &channel->lock) { rphy->powered = false; + if (rcar_gen3_are_all_rphys_power_off(channel)) { + u32 val = readl(channel->base + USB2_USBCTR); + + val |= USB2_USBCTR_PLL_RST; + writel(val, channel->base + USB2_USBCTR); + } + } + if (channel->vbus) ret = regulator_disable(channel->vbus);