| Message ID | 20250313102546.27335-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | rtc: rzn1: support XTAL clk and SCMP method | expand |
On Thu, Mar 13, 2025 at 11:25:42AM +0100, Wolfram Sang wrote: > The external crystal can be a second clock input. It is needed for the > SCMP counting method which allows using crystals different than 32768Hz. > It is also needed for an upcoming SoC which only supports the SCMP > method. > Probably the binding was incomplete and you always had external crystal connected. I assume you want to keep old DTS, so it is fine for me: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
> Probably the binding was incomplete and you always had external crystal > connected. I assume you want to keep old DTS, so it is fine for me: The documentation explicitly mentions how to wire clock lines if you are not using the RTC and have no oscillator. But yeah, then the RTC DT node should be disabled. And yes, I want to be backwards compatible. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks!
diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml index f6e0c613af67..f6fdcc7090b6 100644 --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml @@ -33,10 +33,14 @@ properties: - const: pps clocks: - maxItems: 1 + minItems: 1 + maxItems: 2 clock-names: - const: hclk + minItems: 1 + items: + - const: hclk + - const: xtal power-domains: maxItems: 1
The external crystal can be a second clock input. It is needed for the SCMP counting method which allows using crystals different than 32768Hz. It is also needed for an upcoming SoC which only supports the SCMP method. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- .../devicetree/bindings/rtc/renesas,rzn1-rtc.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)