From patchwork Sat Feb 6 14:46:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 8242611 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-renesas-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A79BD9F1C0 for ; Sat, 6 Feb 2016 14:46:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0E15A20211 for ; Sat, 6 Feb 2016 14:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CA5A20204 for ; Sat, 6 Feb 2016 14:46:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbcBFOqk (ORCPT ); Sat, 6 Feb 2016 09:46:40 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:33560 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbcBFOqi (ORCPT ); Sat, 6 Feb 2016 09:46:38 -0500 Received: by mail-lf0-f48.google.com with SMTP id m1so74406571lfg.0 for ; Sat, 06 Feb 2016 06:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=4FkZYi9P8vwWHpW6cnF7OdAE21mfMsF7axzIsU8K8/U=; b=umTyoauhOLwd7nRhG8vRkPZJajyZLV1kr6Z2M2SkCfugTBCqwYoezhK8QFFYQOELPT ybdPKUtFMbhX/WlUSzsGJaImURydJw9zscBpZV1Y5lGzLB8OFTesJqv9jSyBqSonrfID DI9BkqnF6KOC+h+a5Mb5Z0kPlq/0CELKyGhRhenoqKZtqifU6zNoBVvlhaMY/9DfNTRq W2ULPtRtHYUth/9a9yRKuNAwuSQ+RLlqLv+yM9fJEkbSSt1T1qp5fZuhEdVW9U63H+uN 3Xt9sjirgaFGIGjxEKG5rot86Ow572u5dnXG/SeyE/BvLiX8i531+sckvJ8sgn05gFa/ Gp6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4FkZYi9P8vwWHpW6cnF7OdAE21mfMsF7axzIsU8K8/U=; b=G96rCgkmHQhCTwlHeIwn+ahwH7Kuuf3bsq+VS1YC+9llQvbNMry7UUVHPvztMZs1Ii 6YlI410DBPwDVQpkZ7Brl551G75kvR/n51Wj5kW5rbdBrk/Ebq9X84Tk5/lvf7SiFKxS JettztCEGktX7ZdBIXLCKqLz/6anH+ICzpQtzXdwMFamKyTZUbZZS0EsavwDUeRlwvXz srR8PlmcstGhqJtKCQxnL/VfURxY38T+qGnMJWppYYm4jSiKUxGx9dJXxfivJjTCzCaG PfX787dIBCdQB+T93GhUl06qpQdq0qDdYG5H0ldeHs9nHHloRceF5UJEjN9PRXcihy8e Yv0g== X-Gm-Message-State: AG10YOQ8ksyYggH5ztHncV0jVqpdy7QnOxfmNdVBquGmxW6Iq5lCdlb9YF+Fjs7LhrCuhA== X-Received: by 10.25.89.73 with SMTP id n70mr8244544lfb.40.1454769997524; Sat, 06 Feb 2016 06:46:37 -0800 (PST) Received: from wasted.cogentembedded.com ([195.16.111.103]) by smtp.gmail.com with ESMTPSA id xo4sm2846292lbb.27.2016.02.06.06.46.36 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Feb 2016 06:46:36 -0800 (PST) From: Sergei Shtylyov To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Subject: [PATCH 1/2] ravb: kill duplicate setting of CCC.CSEL Date: Sat, 06 Feb 2016 17:46:35 +0300 Message-ID: <2078080.3mtuat95A1@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.10 (Linux/4.2.8-200.fc22.x86_64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <15000430.RmSAhz5Ejy@wasted.cogentembedded.com> References: <15000430.RmSAhz5Ejy@wasted.cogentembedded.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When adding support for the R-Car gen3 gPTP active in configuration mode, the code setting the CCC.CSEL field was duplicated due to an oversight. For R-Car gen 2 it's just redundant and for R-Car gen3 the write at this time is probably ignored due to CCC.GAC bit being already set... Fixes: f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support") Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/ravb_main.c | 4 ---- 1 file changed, 4 deletions(-) Index: net/drivers/net/ethernet/renesas/ravb_main.c =================================================================== --- net.orig/drivers/net/ethernet/renesas/ravb_main.c +++ net/drivers/net/ethernet/renesas/ravb_main.c @@ -1814,10 +1814,6 @@ static int ravb_probe(struct platform_de CCC_OPC_CONFIG | CCC_GAC | CCC_CSEL_HPB, CCC); } - /* Set CSEL value */ - ravb_write(ndev, (ravb_read(ndev, CCC) & ~CCC_CSEL) | CCC_CSEL_HPB, - CCC); - /* Set GTI value */ error = ravb_set_gti(ndev); if (error)