From patchwork Thu Apr 2 18:34:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Riesen X-Patchwork-Id: 11471237 X-Patchwork-Delegate: kieran@bingham.xyz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE6F514DD for ; Thu, 2 Apr 2020 18:39:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC5FD20719 for ; Thu, 2 Apr 2020 18:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387726AbgDBSj7 (ORCPT ); Thu, 2 Apr 2020 14:39:59 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:33417 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727439AbgDBSj7 (ORCPT ); Thu, 2 Apr 2020 14:39:59 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M9ZRc-1jNMXQ41PY-005X3o for ; Thu, 02 Apr 2020 20:39:56 +0200 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id B3258650AA6 for ; Thu, 2 Apr 2020 18:39:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0-uv8k-Ai-ho for ; Thu, 2 Apr 2020 20:39:56 +0200 (CEST) Received: from pfwsexchange.corp.cetitec.com (unknown [10.10.1.99]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 1DCCE64F7EA for ; Thu, 2 Apr 2020 20:39:56 +0200 (CEST) Received: from pflmari.corp.cetitec.com (10.8.5.12) by PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Apr 2020 20:39:56 +0200 Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 81892804FD; Thu, 2 Apr 2020 20:34:00 +0200 (CEST) Date: Thu, 2 Apr 2020 20:34:00 +0200 From: Alex Riesen To: Kieran Bingham CC: Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , "Laurent Pinchart" , Rob Herring , Mark Rutland , Kuninori Morimoto , , , , , Subject: [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements Message-ID: <2f2460435afa594ef417e70068b125af97ddca39.1585852001.git.alexander.riesen@cetitec.com> Mail-Followup-To: Alex Riesen , Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.8.5.12] X-ClientProxiedBy: PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) To PFWSEXCHANGE.corp.cetitec.com (10.10.1.99) X-EsetResult: clean, is OK X-EsetId: 37303A290D7F536A6C7266 X-Provags-ID: V03:K1:4ql6TV7KKWRJgAD5jjIU+eHdnNO/G47oomRgMQtXvYMTJOZTzS6 lpE2+1eUM5ULTyX4gGDANT1aq24IOX9UOncQtE6WHRRdgVV9lRFDmnTXDLqs5C7KwN7AD/n 2DYBkfgz37ossgFynAQIeZA7SSJYum20D85DsIjIcGfZcWqAh1LtijdUAzl1vbQgeqnpUj0 hCo6G1N0Uo8o0sWQSdKCQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6XbgG97zn1g=:XLPQXb5es7obwEF8B5mZAt mw7Snekxq4ba9DdK3VqUdZ2243x2FJfLjoHt6Hodg7OP/5xQx3Lr+NhGYmrTIkj1wxFbkjaqf OXLnCcsu5tlN9M6e+fozVccYDY4ka5aWDaIFktvWWtdA5oQJeU+pB9gqrB4BjxtkXyaaRPFWp W1TnidsEhaAJ54sOJ2EEH2QqJqbwS5QSmjfZteVdq8gMw6CBtcmLs6aDcBLuo0NTwMnv47alV 4FDCSPK43FPgQcwcmt+Uz+2N1rAZoXV4D3jAngHKOrlFxq8lQOclPkZK55fpi5X5lXN/7YWLt Rz59HFWoK1MrbLfUziYMlyeYvu1kG2jNDOo6N5PSFsn4AyK6kfdmKJOsO4O87S+xKNkpZ+YRG W9O8y6XyWqKijFqz6DgIq1fwNfy1Y2/4Hnzi+JolWbqh3moSsiOWonGQDTlqWdL+1pNBBvV4z Xb5Y1mj8zcKhk+jCkHd8k38grk0BcKr+d+tJk2tnr2hIaID/14aUsYKyv4mNR5pOUKuKr6ZUA zqogUAjNeqMEhoV0eEOzJUU4nWSWTl898Jcz1HKShjjuYaRkc6NfFNMuQWisuU7PhTQrYA7jb zChzp/eWxFF//RKT8EQAauo/1+0mCfsMiNJ/8eX6Gr39qjuS+58BTJq0PrqN+RRBy8aV7zVoW YQYo4NpS2OIHCwOrosJPaAJiuGefTwsRJKjlTaucuF+tp2BOKq2dfvjraZf2BClh5/vUfLnY7 jw50Pgnqp8HeH4/bBzjTVzyR9e1KyfWVQa8Gc5i05SubxhRI3R+D4MgxnxVc8XCxJD2lLcKtn sjtMuO3EWdjOz5y9KJ9LTagFRncsItSVgoFeMpeqIIOwBPJO2t/XiMr8t0LtSvi4LulGOcd Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Signed-off-by: Alexander Riesen Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- drivers/media/i2c/adv748x/adv748x-core.c | 24 ++++++++++++------------ drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index 23e02ff27b17..c3fb113cef62 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -623,11 +623,11 @@ static int adv748x_parse_dt(struct adv748x_state *state) for_each_endpoint_of_node(state->dev->of_node, ep_np) { of_graph_parse_endpoint(ep_np, &ep); - adv_info(state, "Endpoint %pOF on port %d", ep.local_node, + adv_info(state, "Endpoint %pOF on port %d\n", ep.local_node, ep.port); if (ep.port >= ADV748X_PORT_MAX) { - adv_err(state, "Invalid endpoint %pOF on port %d", + adv_err(state, "Invalid endpoint %pOF on port %d\n", ep.local_node, ep.port); continue; @@ -635,7 +635,7 @@ static int adv748x_parse_dt(struct adv748x_state *state) if (state->endpoints[ep.port]) { adv_err(state, - "Multiple port endpoints are not supported"); + "Multiple port endpoints are not supported\n"); continue; } @@ -702,62 +702,62 @@ static int adv748x_probe(struct i2c_client *client) /* Discover and process ports declared by the Device tree endpoints */ ret = adv748x_parse_dt(state); if (ret) { - adv_err(state, "Failed to parse device tree"); + adv_err(state, "Failed to parse device tree\n"); goto err_free_mutex; } /* Configure IO Regmap region */ ret = adv748x_configure_regmap(state, ADV748X_PAGE_IO); if (ret) { - adv_err(state, "Error configuring IO regmap region"); + adv_err(state, "Error configuring IO regmap region\n"); goto err_cleanup_dt; } ret = adv748x_identify_chip(state); if (ret) { - adv_err(state, "Failed to identify chip"); + adv_err(state, "Failed to identify chip\n"); goto err_cleanup_dt; } /* Configure remaining pages as I2C clients with regmap access */ ret = adv748x_initialise_clients(state); if (ret) { - adv_err(state, "Failed to setup client regmap pages"); + adv_err(state, "Failed to setup client regmap pages\n"); goto err_cleanup_clients; } /* SW reset ADV748X to its default values */ ret = adv748x_reset(state); if (ret) { - adv_err(state, "Failed to reset hardware"); + adv_err(state, "Failed to reset hardware\n"); goto err_cleanup_clients; } /* Initialise HDMI */ ret = adv748x_hdmi_init(&state->hdmi); if (ret) { - adv_err(state, "Failed to probe HDMI"); + adv_err(state, "Failed to probe HDMI\n"); goto err_cleanup_clients; } /* Initialise AFE */ ret = adv748x_afe_init(&state->afe); if (ret) { - adv_err(state, "Failed to probe AFE"); + adv_err(state, "Failed to probe AFE\n"); goto err_cleanup_hdmi; } /* Initialise TXA */ ret = adv748x_csi2_init(state, &state->txa); if (ret) { - adv_err(state, "Failed to probe TXA"); + adv_err(state, "Failed to probe TXA\n"); goto err_cleanup_afe; } /* Initialise TXB */ ret = adv748x_csi2_init(state, &state->txb); if (ret) { - adv_err(state, "Failed to probe TXB"); + adv_err(state, "Failed to probe TXB\n"); goto err_cleanup_txa; } diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c index 2091cda50935..c43ce5d78723 100644 --- a/drivers/media/i2c/adv748x/adv748x-csi2.c +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c @@ -72,7 +72,7 @@ static int adv748x_csi2_registered(struct v4l2_subdev *sd) struct adv748x_state *state = tx->state; int ret; - adv_dbg(state, "Registered %s (%s)", is_txa(tx) ? "TXA":"TXB", + adv_dbg(state, "Registered %s (%s)\n", is_txa(tx) ? "TXA":"TXB", sd->name); /*