| Message ID | 309b5211-bab6-53de-b8a8-6e1049e1705e@cogentembedded.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
On Sat, Apr 14, 2018 at 10:28:29PM +0300, Sergei Shtylyov wrote: > Define the Condor board dependent part of the MMC0 (connected to eMMC chip) > device node along with the necessary voltage regulators... > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 43 ++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts > =================================================================== > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-condor.dts > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts > @@ -27,6 +27,24 @@ > /* first 128MB is reserved for secure area. */ > reg = <0 0x48000000 0 0x78000000>; > }; > + > + d3_3v: regulator-0 { Please use reg_3p3v: regulator1 for consistency with salvator-common.dtsi > + compatible = "regulator-fixed"; > + regulator-name = "D3.3V"; And "fixed-3.3V" > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + vddq_vin01: regulator-1 { And reg_1p8v: regulator0 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDQ_VIN01"; And "fixed-1.8V" > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > &avb { > @@ -52,6 +70,19 @@ > clock-frequency = <32768>; > }; > > +&mmc0 { > + pinctrl-0 = <&mmc_3_3v_pins>; > + pinctrl-1 = <&mmc_1_8v_pins>; > + pinctrl-names = "default", "state_uhs"; > + > + vmmc-supply = <&d3_3v>; > + vqmmc-supply = <&vddq_vin01>; > + mmc-hs200-1_8v; > + bus-width = <8>; > + non-removable; > + status = "okay"; > +}; > + > &pciec { > status = "okay"; > }; > @@ -70,6 +101,18 @@ > function = "avb"; > }; > > + mmc_1_8v_pins: mmc_1_8v { > + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; > + function = "mmc"; > + power-source = <1800>; > + }; > + > + mmc_3_3v_pins: mmc_3_3v { > + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; > + function = "mmc"; > + power-source = <3300>; > + }; Again please make this more consistent with salvator-common.dtsi. > + > scif0_pins: scif0 { > groups = "scif0_data"; > function = "scif0"; >
On 04/20/2018 01:03 PM, Simon Horman wrote: >> Define the Condor board dependent part of the MMC0 (connected to eMMC chip) >> device node along with the necessary voltage regulators... >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> --- >> arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 43 ++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts >> =================================================================== >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-condor.dts >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts >> @@ -27,6 +27,24 @@ >> /* first 128MB is reserved for secure area. */ >> reg = <0 0x48000000 0 0x78000000>; >> }; >> + >> + d3_3v: regulator-0 { > > Please use reg_3p3v: regulator1 for consistency with salvator-common.dtsi Hm, not sure why I have to copy what I consider a bad example... the SoCs are not pin compatible anyway. >> + compatible = "regulator-fixed"; >> + regulator-name = "D3.3V"; > > And "fixed-3.3V" Ugh. That's pretty poor name I think. My names do correspond to the schematics and these only muddle things up, I think... [...] >> @@ -70,6 +101,18 @@ >> function = "avb"; >> }; >> >> + mmc_1_8v_pins: mmc_1_8v { >> + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; >> + function = "mmc"; >> + power-source = <1800>; >> + }; >> + >> + mmc_3_3v_pins: mmc_3_3v { >> + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; >> + function = "mmc"; >> + power-source = <3300>; >> + }; > > Again please make this more consistent with salvator-common.dtsi. Ah, you mean the _uhs label name postfix? OK... [...] MBR, Sergei
On Fri, Apr 20, 2018 at 09:51:06PM +0300, Sergei Shtylyov wrote: > On 04/20/2018 01:03 PM, Simon Horman wrote: > > >> Define the Condor board dependent part of the MMC0 (connected to eMMC chip) > >> device node along with the necessary voltage regulators... > >> > >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > >> --- > >> arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 43 ++++++++++++++++++++++++ > >> 1 file changed, 43 insertions(+) > >> > >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts > >> =================================================================== > >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-condor.dts > >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts > >> @@ -27,6 +27,24 @@ > >> /* first 128MB is reserved for secure area. */ > >> reg = <0 0x48000000 0 0x78000000>; > >> }; > >> + > >> + d3_3v: regulator-0 { > > > > Please use reg_3p3v: regulator1 for consistency with salvator-common.dtsi > > Hm, not sure why I have to copy what I consider a bad example... the SoCs are > not pin compatible anyway. > > >> + compatible = "regulator-fixed"; > >> + regulator-name = "D3.3V"; > > > > And "fixed-3.3V" > > Ugh. That's pretty poor name I think. My names do correspond to the schematics > and these only muddle things up, I think... > > [...] > >> @@ -70,6 +101,18 @@ > >> function = "avb"; > >> }; > >> > >> + mmc_1_8v_pins: mmc_1_8v { > >> + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; > >> + function = "mmc"; > >> + power-source = <1800>; > >> + }; > >> + > >> + mmc_3_3v_pins: mmc_3_3v { > >> + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; > >> + function = "mmc"; > >> + power-source = <3300>; > >> + }; > > > > Again please make this more consistent with salvator-common.dtsi. > > Ah, you mean the _uhs label name postfix? OK... Thanks, could you send a v2?
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts =================================================================== --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-condor.dts +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts @@ -27,6 +27,24 @@ /* first 128MB is reserved for secure area. */ reg = <0 0x48000000 0 0x78000000>; }; + + d3_3v: regulator-0 { + compatible = "regulator-fixed"; + regulator-name = "D3.3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + vddq_vin01: regulator-1 { + compatible = "regulator-fixed"; + regulator-name = "VDDQ_VIN01"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + }; }; &avb { @@ -52,6 +70,19 @@ clock-frequency = <32768>; }; +&mmc0 { + pinctrl-0 = <&mmc_3_3v_pins>; + pinctrl-1 = <&mmc_1_8v_pins>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&d3_3v>; + vqmmc-supply = <&vddq_vin01>; + mmc-hs200-1_8v; + bus-width = <8>; + non-removable; + status = "okay"; +}; + &pciec { status = "okay"; }; @@ -70,6 +101,18 @@ function = "avb"; }; + mmc_1_8v_pins: mmc_1_8v { + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; + function = "mmc"; + power-source = <1800>; + }; + + mmc_3_3v_pins: mmc_3_3v { + groups = "mmc_data8", "mmc_ctrl", "mmc_ds"; + function = "mmc"; + power-source = <3300>; + }; + scif0_pins: scif0 { groups = "scif0_data"; function = "scif0";
Define the Condor board dependent part of the MMC0 (connected to eMMC chip) device node along with the necessary voltage regulators... Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 43 ++++++++++++++++++++++++ 1 file changed, 43 insertions(+)