diff mbox

[08/39,v2] ASoC: simple-card-utils: add asoc_simple_card_parse_card_prefix()

Message ID 874m9esj22.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State Changes Requested
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Kuninori Morimoto May 31, 2016, 9:01 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

DPCM might need audio prefix for route matching.
This patch makes this method simple style standard.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 include/sound/simple_card_utils.h     |  4 ++++
 sound/soc/generic/simple-card-utils.c | 17 +++++++++++++++++
 2 files changed, 21 insertions(+)

Comments

Mark Brown June 29, 2016, 6:17 p.m. UTC | #1 
On Tue, May 31, 2016 at 09:01:58AM +0000, Kuninori Morimoto wrote:

> +int asoc_simple_card_parse_card_prefix(struct snd_soc_card *card,
> +				       struct snd_soc_dai_link *dai_link,
> +				       struct snd_soc_codec_conf *codec_conf,
> +				       char *prefix)
> +{
> +	char prop[128];
> +
> +	snprintf(prop, sizeof(prop), "%sprefix", prefix);
> +
> +	snd_soc_of_parse_audio_prefix(card, codec_conf,
> +				      dai_link->codec_of_node,
> +				      prop);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_prefix);

Similar thin wrapper comment as before: what is this offering over the
underlying function?
diff mbox

Patch

diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
index 2f991da..89172aa 100644
--- a/include/sound/simple_card_utils.h
+++ b/include/sound/simple_card_utils.h
@@ -33,5 +33,9 @@  int asoc_simple_card_parse_dailink_name(struct device *dev,
 					struct snd_soc_dai_link *dai_link);
 int asoc_simple_card_parse_card_name(struct snd_soc_card *card,
 				     char *prefix);
+int asoc_simple_card_parse_card_prefix(struct snd_soc_card *card,
+				       struct snd_soc_dai_link *dai_link,
+				       struct snd_soc_codec_conf *codec_conf,
+				       char *prefix);
 
 #endif /* __SIMPLE_CARD_CORE_H */
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index c782b3a..439fc01 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -125,3 +125,20 @@  int asoc_simple_card_parse_card_name(struct snd_soc_card *card,
 	return 0;
 }
 EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_name);
+
+int asoc_simple_card_parse_card_prefix(struct snd_soc_card *card,
+				       struct snd_soc_dai_link *dai_link,
+				       struct snd_soc_codec_conf *codec_conf,
+				       char *prefix)
+{
+	char prop[128];
+
+	snprintf(prop, sizeof(prop), "%sprefix", prefix);
+
+	snd_soc_of_parse_audio_prefix(card, codec_conf,
+				      dai_link->codec_of_node,
+				      prop);
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_prefix);