diff mbox series

arm64: dts: renesas: r8a7795: add missing dma-names on hscif2

Message ID 87bm8itkta.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Commit aab7a2414ba0d5c3d0571a90031b535adba7146a
Delegated to: Simon Horman
Headers show
Series arm64: dts: renesas: r8a7795: add missing dma-names on hscif2 | expand

Commit Message

Kuninori Morimoto Sept. 28, 2018, 2:38 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

hscif2 has 4 dmas, but has only 2 dma-names.
This patch add missing dma-names.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
Hi Simon, Geert

I think this is bugfix, but I'm not sure detail of scif...

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Sept. 28, 2018, 6:48 a.m. UTC | #1 
On Fri, Sep 28, 2018 at 4:38 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> hscif2 has 4 dmas, but has only 2 dma-names.
> This patch add missing dma-names.

Nice catch!

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Fixes: e0f0bda79337701a ("arm64: dts: renesas: r8a7795: sort subnodes
of the soc node")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Simon Horman Oct. 1, 2018, 1:09 p.m. UTC | #2 
On Fri, Sep 28, 2018 at 08:48:47AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 28, 2018 at 4:38 AM Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > hscif2 has 4 dmas, but has only 2 dma-names.
> > This patch add missing dma-names.
> 
> Nice catch!
> 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Fixes: e0f0bda79337701a ("arm64: dts: renesas: r8a7795: sort subnodes
> of the soc node")
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, I have tentatively applied this as a fix for v4.20.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index b5f2273..a79c8d3 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -652,7 +652,7 @@ 
 			clock-names = "fck", "brg_int", "scif_clk";
 			dmas = <&dmac1 0x35>, <&dmac1 0x34>,
 			       <&dmac2 0x35>, <&dmac2 0x34>;
-			dma-names = "tx", "rx";
+			dma-names = "tx", "rx", "tx", "rx";
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
 			resets = <&cpg 518>;
 			status = "disabled";