diff mbox series

[v3,2/4] dt-bindings: soc: renesas: renesas.yaml: Add renesas,s4sk compatible

Message ID 87cyxxeff8.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series arm64: dts: renesas: Add R-Car S4 Starter Kit support | expand

Commit Message

Kuninori Morimoto Oct. 2, 2023, 5:55 a.m. UTC
This patch adds "renesas,s4sk" which target the R-Car S4 Starter Kit
board.

Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Yoshihiro Shimoda Oct. 2, 2023, 6:45 a.m. UTC | #1
Hello Morimoto-san,

> From: Kuninori Morimoto, Sent: Monday, October 2, 2023 2:56 PM
> 
> This patch adds "renesas,s4sk" which target the R-Car S4 Starter Kit
> board.
> 
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index 53b95f348f8e..b2bdc26e8329 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -335,6 +335,13 @@ properties:
>            - const: renesas,spider-cpu
>            - const: renesas,r8a779f0
> 
> +      - description: R-Car S4-8 (R8A779F4)
> +        items:
> +          - enum:
> +              - renesas,s4sk       # R-Car S4 Starter Kit board (Y-ASK-RCAR-S4-1000BASE-T#WS12)
> +          - const: renesas,r8a779f4
> +          - const: renesas,r8a779f0
> +
>        - description: R-Car V4H (R8A779G0)
>          items:
>            - enum:
> --
> 2.25.1
Krzysztof Kozlowski Oct. 2, 2023, 2:09 p.m. UTC | #2
On 02/10/2023 07:55, Kuninori Morimoto wrote:
> This patch adds "renesas,s4sk" which target the R-Car S4 Starter Kit
> board.
> 
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index 53b95f348f8e..b2bdc26e8329 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -335,6 +335,13 @@  properties:
           - const: renesas,spider-cpu
           - const: renesas,r8a779f0
 
+      - description: R-Car S4-8 (R8A779F4)
+        items:
+          - enum:
+              - renesas,s4sk       # R-Car S4 Starter Kit board (Y-ASK-RCAR-S4-1000BASE-T#WS12)
+          - const: renesas,r8a779f4
+          - const: renesas,r8a779f0
+
       - description: R-Car V4H (R8A779G0)
         items:
           - enum: