| Message ID | 87ed8nkxeq.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 6ade6513832d21599bdcaca59c715f23dde026a8 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: V4M GrayHawk Sound support | expand |
Hi Morimoto-san, Thanks for your patch! On Mon, Jun 24, 2024 at 2:16 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > Add sound support for R-Car V4M. > > Signed-off-by: Khanh Le <khanh.le.xr@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> The Sob-chain does not match the From:. Either there should be a "From: Khanh Le ..." at the top, or a "Co-developed-by: Khanh Le ..." before the "Signed-off-by: Khanh Le ...". https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi > @@ -1464,6 +1471,67 @@ dmac2: dma-controller@e7351000 { > <&ipmmu_ds0 22>, <&ipmmu_ds0 23>; > }; > > + rcar_sound: sound@ec400000 { > + compatible = "renesas,rcar_sound-r8a779h0", "renesas,rcar_sound-gen4"; > + reg = <0 0xec400000 0 0x40000>, /* SSI_SDMC */ > + <0 0xec540000 0 0x1000>, /* SSIU */ > + <0 0xec541000 0 0x050>, /* SSI */ > + <0 0xec5a0000 0 0x020>; /* ADG */ No need for the comments, we have "reg-names" below... > + reg-names = "sdmc", "ssiu", "ssi", "adg"; > + clocks = <&cpg CPG_MOD 2926>, <&cpg CPG_MOD 2927>, <&audio_clkin>; > + clock-names = "ssiu.0", "ssi.0", "clkin"; > + /* #clock-cells is fixed */ > + #clock-cells = <0>; > + /* #sound-dai-cells is fixed */ > + #sound-dai-cells = <0>; The rest LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> If you tell me the correct author-chain, I can make these changes while queuing in renesas-devel for v6.11. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert Thank you for reviewing > > Signed-off-by: Khanh Le <khanh.le.xr@renesas.com> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > The Sob-chain does not match the From:. > > Either there should be a "From: Khanh Le ..." at the top, or > a "Co-developed-by: Khanh Le ..." before the "Signed-off-by: Khanh Le ...". (snip) > If you tell me the correct author-chain, I can make these changes > while queuing in renesas-devel for v6.11. The original code which written by Khanh was for old kernel, and based on BSP kernel, not upstream kernel. I have adjusted it to upstream code, so From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> [Kuninori: adjusted to latest upstream kernel] Co-developed-by: Khanh Le <khanh.le.xr@renesas.com> Signed-off-by: Khanh Le <khanh.le.xr@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi index 400169fe4a1a6..d3c8093bc0d9e 100644 --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi @@ -14,6 +14,13 @@ / { #address-cells = <2>; #size-cells = <2>; + /* External Audio clock - to be overridden by boards that provide it */ + audio_clkin: audio_clkin { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + cluster0_opp: opp-table-0 { compatible = "operating-points-v2"; opp-shared; @@ -1464,6 +1471,67 @@ dmac2: dma-controller@e7351000 { <&ipmmu_ds0 22>, <&ipmmu_ds0 23>; }; + rcar_sound: sound@ec400000 { + compatible = "renesas,rcar_sound-r8a779h0", "renesas,rcar_sound-gen4"; + reg = <0 0xec400000 0 0x40000>, /* SSI_SDMC */ + <0 0xec540000 0 0x1000>, /* SSIU */ + <0 0xec541000 0 0x050>, /* SSI */ + <0 0xec5a0000 0 0x020>; /* ADG */ + reg-names = "sdmc", "ssiu", "ssi", "adg"; + clocks = <&cpg CPG_MOD 2926>, <&cpg CPG_MOD 2927>, <&audio_clkin>; + clock-names = "ssiu.0", "ssi.0", "clkin"; + /* #clock-cells is fixed */ + #clock-cells = <0>; + /* #sound-dai-cells is fixed */ + #sound-dai-cells = <0>; + + power-domains = <&sysc R8A779H0_PD_ALWAYS_ON>; + resets = <&cpg 2926>, <&cpg 2927>; + reset-names = "ssiu.0", "ssi.0"; + status = "disabled"; + + rcar_sound,ssiu { + ssiu00: ssiu-0 { + dmas = <&dmac1 0x6e>, <&dmac1 0x6f>; + dma-names = "tx", "rx"; + }; + ssiu01: ssiu-1 { + dmas = <&dmac1 0x6c>, <&dmac1 0x6d>; + dma-names = "tx", "rx"; + }; + ssiu02: ssiu-2 { + dmas = <&dmac1 0x6a>, <&dmac1 0x6b>; + dma-names = "tx", "rx"; + }; + ssiu03: ssiu-3 { + dmas = <&dmac1 0x68>, <&dmac1 0x69>; + dma-names = "tx", "rx"; + }; + ssiu04: ssiu-4 { + dmas = <&dmac1 0x66>, <&dmac1 0x67>; + dma-names = "tx", "rx"; + }; + ssiu05: ssiu-5 { + dmas = <&dmac1 0x64>, <&dmac1 0x65>; + dma-names = "tx", "rx"; + }; + ssiu06: ssiu-6 { + dmas = <&dmac1 0x62>, <&dmac1 0x63>; + dma-names = "tx", "rx"; + }; + ssiu07: ssiu-7 { + dmas = <&dmac1 0x60>, <&dmac1 0x61>; + dma-names = "tx", "rx"; + }; + }; + + rcar_sound,ssi { + ssi0: ssi-0 { + interrupts = <GIC_SPI 258 IRQ_TYPE_LEVEL_HIGH>; + }; + }; + }; + mmc0: mmc@ee140000 { compatible = "renesas,sdhi-r8a779h0", "renesas,rcar-gen4-sdhi";