| Message ID | 87edidefft.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: Add R-Car S4 Starter Kit support | expand |
Hello Morimoto-san, > From: Kuninori Morimoto, Sent: Monday, October 2, 2023 2:56 PM Thank you for the patch! This patch looks good to me. So, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> However, I have some nits like below... > Document support for the Interrupt Controller for External Devices > (INT-EX) in the Renesas R-Car S4 (R8A779F0) SoC. nit: s/INT-EX/INTC-EX/ > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/interrupt-controller/renesas,irqc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > index 95033cb514fb..b1f3e7d7b88c 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml > @@ -37,6 +37,7 @@ properties: > - renesas,intc-ex-r8a77990 # R-Car E3 > - renesas,intc-ex-r8a77995 # R-Car D3 > - renesas,intc-ex-r8a779a0 # R-Car V3U > + - renesas,intc-ex-r8a779f0 # R-Car S4 nit: s/R-Car S4/R-Car S4-8/ Best regards, Yoshihiro Shimoda > - renesas,intc-ex-r8a779g0 # R-Car V4H > - const: renesas,irqc > > -- > 2.25.1
Hi Shimoda-san > > Document support for the Interrupt Controller for External Devices > > (INT-EX) in the Renesas R-Car S4 (R8A779F0) SoC. > > nit: > s/INT-EX/INTC-EX/ Thank you for the review. I have copy-and-pasted the log message. It seems original log hadwas nit :) Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Morimoto-san, On Tue, Oct 3, 2023 at 4:12 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > > Document support for the Interrupt Controller for External Devices > > > (INT-EX) in the Renesas R-Car S4 (R8A779F0) SoC. > > > > nit: > > s/INT-EX/INTC-EX/ > > Thank you for the review. > I have copy-and-pasted the log message. > It seems original log hadwas nit :) /me is hiding behind a rock labeled with two different misspellings of INTC-EX... Gr{oetje,eeting}s, Geert
diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml index 95033cb514fb..b1f3e7d7b88c 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml @@ -37,6 +37,7 @@ properties: - renesas,intc-ex-r8a77990 # R-Car E3 - renesas,intc-ex-r8a77995 # R-Car D3 - renesas,intc-ex-r8a779a0 # R-Car V3U + - renesas,intc-ex-r8a779f0 # R-Car S4 - renesas,intc-ex-r8a779g0 # R-Car V4H - const: renesas,irqc