diff mbox series

[v2,07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

Message ID 87eendrtv1.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series arm64: renesas: enable HDMI Display/Sound on R-Car M3-W+ Salvator-XS | expand

Commit Message

Kuninori Morimoto Sept. 8, 2020, 12:35 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
This patch was tested on R-Car M3-W+ Salvator-XS board.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart Sept. 8, 2020, 6:02 a.m. UTC | #1 
Hi Morimoto-san,

Thank you for the patch.

On Tue, Sep 08, 2020 at 09:35:10AM +0900, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
> This patch was tested on R-Car M3-W+ Salvator-XS board.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index 423808b6cd58..c7fabd9e875b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2165,8 +2165,19 @@ port@2 {
>  		};
>  
>  		du: display@feb00000 {
> +			compatible = "renesas,du-r8a77961";
>  			reg = <0 0xfeb00000 0 0x70000>;
> -			/* placeholder */
> +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> +				 <&cpg CPG_MOD 722>;
> +			clock-names = "du.0", "du.1", "du.2";
> +			resets = <&cpg 724>, <&cpg 722>;
> +			reset-names = "du.0", "du.2";
> +
> +			renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> +			status = "disabled";
>  
>  			ports {
>  				#address-cells = <1>;
Kieran Bingham Sept. 8, 2020, 3:11 p.m. UTC | #2 
Hi Morimoto-san,

On 08/09/2020 01:35, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
> This patch was tested on R-Car M3-W+ Salvator-XS board.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>


> ---
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index 423808b6cd58..c7fabd9e875b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2165,8 +2165,19 @@ port@2 {
>  		};
>  
>  		du: display@feb00000 {
> +			compatible = "renesas,du-r8a77961";
>  			reg = <0 0xfeb00000 0 0x70000>;
> -			/* placeholder */
> +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> +				 <&cpg CPG_MOD 722>;
> +			clock-names = "du.0", "du.1", "du.2";
> +			resets = <&cpg 724>, <&cpg 722>;
> +			reset-names = "du.0", "du.2";
> +
> +			renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> +			status = "disabled";
>  
>  			ports {
>  				#address-cells = <1>;
>
Geert Uytterhoeven Sept. 10, 2020, 9:49 a.m. UTC | #3 
On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
> This patch was tested on R-Car M3-W+ Salvator-XS board.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Sept. 10, 2020, 9:50 a.m. UTC | #4 
Hi Morimoto-san,

On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
> This patch was tested on R-Car M3-W+ Salvator-XS board.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index 423808b6cd58..c7fabd9e875b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2165,8 +2165,19 @@ port@2 {
>                 };
>
>                 du: display@feb00000 {
> +                       compatible = "renesas,du-r8a77961";
>                         reg = <0 0xfeb00000 0 0x70000>;
> -                       /* placeholder */
> +                       interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> +                                <&cpg CPG_MOD 722>;
> +                       clock-names = "du.0", "du.1", "du.2";
> +                       resets = <&cpg 724>, <&cpg 722>;
> +                       reset-names = "du.0", "du.2";
> +
> +                       renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> +                       status = "disabled";

Do you want support for CMMs?

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Sept. 10, 2020, 11:20 p.m. UTC | #5 
Hi Geert

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
> > This patch was tested on R-Car M3-W+ Salvator-XS board.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
(snip)
> >                 du: display@feb00000 {
> > +                       compatible = "renesas,du-r8a77961";
> >                         reg = <0 0xfeb00000 0 0x70000>;
> > -                       /* placeholder */
> > +                       interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> > +                                <&cpg CPG_MOD 722>;
> > +                       clock-names = "du.0", "du.1", "du.2";
> > +                       resets = <&cpg 724>, <&cpg 722>;
> > +                       reset-names = "du.0", "du.2";
> > +
> > +                       renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> > +                       status = "disabled";
> 
> Do you want support for CMMs?

I'm not sure how it works.
Thus I dropped such features from initial support.

I hope Laurent or Kieran will support it
when he received physical board.
Some comment for iommu.

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Laurent Pinchart Sept. 10, 2020, 11:22 p.m. UTC | #6 
Hi Morimoto-san,

On Fri, Sep 11, 2020 at 08:20:56AM +0900, Kuninori Morimoto wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC.
> > > This patch was tested on R-Car M3-W+ Salvator-XS board.
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
>
> (snip)
>
> > >                 du: display@feb00000 {
> > > +                       compatible = "renesas,du-r8a77961";
> > >                         reg = <0 0xfeb00000 0 0x70000>;
> > > -                       /* placeholder */
> > > +                       interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                    <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                    <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
> > > +                       clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
> > > +                                <&cpg CPG_MOD 722>;
> > > +                       clock-names = "du.0", "du.1", "du.2";
> > > +                       resets = <&cpg 724>, <&cpg 722>;
> > > +                       reset-names = "du.0", "du.2";
> > > +
> > > +                       renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
> > > +                       status = "disabled";
> > 
> > Do you want support for CMMs?
> 
> I'm not sure how it works.
> Thus I dropped such features from initial support.
> 
> I hope Laurent or Kieran will support it
> when he received physical board.

I'll be happy to do so :-)

> Some comment for iommu.
> 
> Thank you for your help !!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
index 423808b6cd58..c7fabd9e875b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -2165,8 +2165,19 @@  port@2 {
 		};
 
 		du: display@feb00000 {
+			compatible = "renesas,du-r8a77961";
 			reg = <0 0xfeb00000 0 0x70000>;
-			/* placeholder */
+			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>,
+				 <&cpg CPG_MOD 722>;
+			clock-names = "du.0", "du.1", "du.2";
+			resets = <&cpg 724>, <&cpg 722>;
+			reset-names = "du.0", "du.2";
+
+			renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>;
+			status = "disabled";
 
 			ports {
 				#address-cells = <1>;