diff mbox series

[v4,3/4] pinctrl: sh-pfc: align driver description title

Message ID 87imd8y4r2.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series pinctrl: sh-pfc: collect Renesas related CONFIGs in one place | expand

Commit Message

Kuninori Morimoto Aug. 24, 2020, 5:49 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now, Renesas Pin Control drivers are under menu,
but current description are not aligned.
This patch align these.

	- Emma Mobile EV2 pin control support
	- R-Mobile APE6 pin control support
	- R-Mobile A1 pin control support
	- RZ/N1 pin control support
	- RZ/G1H pin control support
	- RZ/G1M pin control support

	+ pin control support for Emma Mobile EV2
	+ pin control support for R-Mobile APE6
	+ pin control support for R-Mobile A1
	+ pin control support for RZ/N1
	+ pin control support for RZ/G1H
	+ pin control support for RZ/G1M

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/sh-pfc/Kconfig | 88 +++++++++++++++++-----------------
 1 file changed, 44 insertions(+), 44 deletions(-)

Comments

Geert Uytterhoeven Aug. 31, 2020, 2:08 p.m. UTC | #1 
Hi Morimoto-san,

On Mon, Aug 24, 2020 at 7:49 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Now, Renesas Pin Control drivers are under menu,
> but current description are not aligned.
> This patch align these.
>
>         - Emma Mobile EV2 pin control support
>         - R-Mobile APE6 pin control support
>         - R-Mobile A1 pin control support
>         - RZ/N1 pin control support
>         - RZ/G1H pin control support
>         - RZ/G1M pin control support
>
>         + pin control support for Emma Mobile EV2
>         + pin control support for R-Mobile APE6
>         + pin control support for R-Mobile A1
>         + pin control support for RZ/N1
>         + pin control support for RZ/G1H
>         + pin control support for RZ/G1M
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/pinctrl/sh-pfc/Kconfig
> +++ b/drivers/pinctrl/sh-pfc/Kconfig
> @@ -56,7 +56,7 @@ config PINCTRL_SH_PFC
>           This enables pin control drivers for Renesas SuperH and ARM platforms
>
>  config PINCTRL_RZA1
> -       bool "RZ/A1 gpio and pinctrl driver"
> +       bool "gpio and pinctrl driver for RZ/A1"

Do you mind if I change this to "pinctrl support for RZ/A1" (and fix up
the sorting in 4/4), or do you insist on keeping the separation between
"gpio and pinctrl" and "pure" pinctrl drivers?

In reality, all SH, SH-Mobile, and R-Mobile pinctrl drivers are GPIO
controller drivers, too, but this is currently no reflected by their
description.

>         depends on OF
>         depends on ARCH_R7S72100 || COMPILE_TEST
>         select GPIOLIB
> @@ -67,7 +67,7 @@ config PINCTRL_RZA1
>           This selects pinctrl driver for Renesas RZ/A1 platforms.
>
>  config PINCTRL_RZA2
> -       bool "RZ/A2 gpio and pinctrl driver"
> +       bool "gpio and pinctrl driver for RZ/A2"

Likewise.

>         depends on OF
>         depends on ARCH_R7S9210 || COMPILE_TEST
>         select GPIOLIB

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Aug. 31, 2020, 10:57 p.m. UTC | #2 
Hi Geert

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Now, Renesas Pin Control drivers are under menu,
> > but current description are not aligned.
> > This patch align these.
> >
> >         - Emma Mobile EV2 pin control support
> >         - R-Mobile APE6 pin control support
> >         - R-Mobile A1 pin control support
> >         - RZ/N1 pin control support
> >         - RZ/G1H pin control support
> >         - RZ/G1M pin control support
> >
> >         + pin control support for Emma Mobile EV2
> >         + pin control support for R-Mobile APE6
> >         + pin control support for R-Mobile A1
> >         + pin control support for RZ/N1
> >         + pin control support for RZ/G1H
> >         + pin control support for RZ/G1M
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > --- a/drivers/pinctrl/sh-pfc/Kconfig
> > +++ b/drivers/pinctrl/sh-pfc/Kconfig
> > @@ -56,7 +56,7 @@ config PINCTRL_SH_PFC
> >           This enables pin control drivers for Renesas SuperH and ARM platforms
> >
> >  config PINCTRL_RZA1
> > -       bool "RZ/A1 gpio and pinctrl driver"
> > +       bool "gpio and pinctrl driver for RZ/A1"
> 
> Do you mind if I change this to "pinctrl support for RZ/A1" (and fix up
> the sorting in 4/4), or do you insist on keeping the separation between
> "gpio and pinctrl" and "pure" pinctrl drivers?

I don't mind :)
Please update it


Thank you for your help !!

Best regards
---
Kuninori Morimoto
diff mbox series

Patch

diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
index ff10bb2ed497..c27861fa557d 100644
--- a/drivers/pinctrl/sh-pfc/Kconfig
+++ b/drivers/pinctrl/sh-pfc/Kconfig
@@ -56,7 +56,7 @@  config PINCTRL_SH_PFC
 	  This enables pin control drivers for Renesas SuperH and ARM platforms
 
 config PINCTRL_RZA1
-	bool "RZ/A1 gpio and pinctrl driver"
+	bool "gpio and pinctrl driver for RZ/A1"
 	depends on OF
 	depends on ARCH_R7S72100 || COMPILE_TEST
 	select GPIOLIB
@@ -67,7 +67,7 @@  config PINCTRL_RZA1
 	  This selects pinctrl driver for Renesas RZ/A1 platforms.
 
 config PINCTRL_RZA2
-	bool "RZ/A2 gpio and pinctrl driver"
+	bool "gpio and pinctrl driver for RZ/A2"
 	depends on OF
 	depends on ARCH_R7S9210 || COMPILE_TEST
 	select GPIOLIB
@@ -78,7 +78,7 @@  config PINCTRL_RZA2
 	  This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
 
 config PINCTRL_RZN1
-	bool "RZ/N1 pinctrl driver"
+	bool "pin control support for RZ/N1"
 	depends on OF
 	depends on ARCH_RZN1 || COMPILE_TEST
 	select GENERIC_PINCTRL_GROUPS
@@ -100,142 +100,142 @@  config PINCTRL_SH_FUNC_GPIO
 	  This enables legacy function GPIOs for SH platforms
 
 config PINCTRL_PFC_EMEV2
-	bool "Emma Mobile EV2 pin control support" if COMPILE_TEST
+	bool "pin control support for Emma Mobile EV2" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A73A4
-	bool "R-Mobile APE6 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Mobile APE6" if COMPILE_TEST
 	select PINCTRL_SH_PFC_GPIO
 
 config PINCTRL_PFC_R8A7740
-	bool "R-Mobile A1 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Mobile A1" if COMPILE_TEST
 	select PINCTRL_SH_PFC_GPIO
 
 config PINCTRL_PFC_R8A7742
-	bool "RZ/G1H pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G1H" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7743
-	bool "RZ/G1M pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G1M" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7744
-	bool "RZ/G1N pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G1N" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7745
-	bool "RZ/G1E pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G1E" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77470
-	bool "RZ/G1C pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G1C" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A774A1
-	bool "RZ/G2M pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G2M" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A774B1
-	bool "RZ/G2N pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G2N" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A774C0
-	bool "RZ/G2E pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G2E" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A774E1
-	bool "RZ/G2H pin control support" if COMPILE_TEST
+	bool "pin control support for RZ/G2H" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7778
-	bool "R-Car M1A pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car M1A" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7779
-	bool "R-Car H1 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car H1" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7790
-	bool "R-Car H2 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car H2" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7791
-	bool "R-Car M2-W pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car M2-W" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7792
-	bool "R-Car V2H pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car V2H" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7793
-	bool "R-Car M2-N pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car M2-N" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A7794
-	bool "R-Car E2 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car E2" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77950
-	bool "R-Car H3 ES1.x pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car H3 ES1.x" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77951
-	bool "R-Car H3 ES2.0+ pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car H3 ES2.0+" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77960
-	bool "R-Car M3-W pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car M3-W" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77961
-	bool "R-Car M3-W+ pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car M3-W+" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77965
-	bool "R-Car M3-N pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car M3-N" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77970
-	bool "R-Car V3M pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car V3M" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77980
-	bool "R-Car V3H pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car V3H" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77990
-	bool "R-Car E3 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car E3" if COMPILE_TEST
 
 config PINCTRL_PFC_R8A77995
-	bool "R-Car D3 pin control support" if COMPILE_TEST
+	bool "pin control support for R-Car D3" if COMPILE_TEST
 
 config PINCTRL_PFC_SH7203
-	bool "SH7203 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7203" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7264
-	bool "SH7264 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7264" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7269
-	bool "SH7269 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7269" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH73A0
-	bool "SH-Mobile AG5 pin control support" if COMPILE_TEST
+	bool "pin control support for SH-Mobile AG5" if COMPILE_TEST
 	select PINCTRL_SH_PFC_GPIO
 	select REGULATOR
 
 config PINCTRL_PFC_SH7720
-	bool "SH7720 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7720" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7722
-	bool "SH7722 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7722" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7723
-	bool "SH-Mobile R2 pin control support" if COMPILE_TEST
+	bool "pin control support for SH-Mobile R2" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7724
-	bool "SH-Mobile R2R pin control support" if COMPILE_TEST
+	bool "pin control support for SH-Mobile R2R" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7734
-	bool "SH7734 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7734" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7757
-	bool "SH7757 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7757" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7785
-	bool "SH7785 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7785" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SH7786
-	bool "SH7786 pin control support" if COMPILE_TEST
+	bool "pin control support for SH7786" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 config PINCTRL_PFC_SHX3
-	bool "SH-X3 pin control support" if COMPILE_TEST
+	bool "pin control support for SH-X3" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
 
 endmenu