diff mbox series

[v2,2/3] soc: renesas: align driver description title

Message ID 87imdhho6o.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series soc: renesas: use menu for Renesas SoC | expand

Commit Message

Kuninori Morimoto Aug. 17, 2020, 4:51 a.m. UTC 
Now, Renesas SoC drivers are under menu,
but current description are not aligned.
This patch align these.

	- R-Car H2 System Controller support                                                                    │ │
	- R-Car M2-W/N System Controller support                                                                │ │
	- R-Car V2H System Controller support                                                                   │ │
	- R-Car E2 System Controller support                                                                    │ │
	- R-Car H3 System Controller support                                                                    │ │
	- R-Car M3-W System Controller support                                                                  │ │
	- R-Car M3-W+ System Controller support                                                                 │ │
	- R-Car M3-N System Controller support                                                                  │ │

	+ System Controller support for R-Car H2                                                                │ │
	+ System Controller support for R-Car M2-W/N                                                            │ │
	+ System Controller support for R-Car V2H                                                               │ │
	+ System Controller support for R-Car E2                                                                │ │
	+ System Controller support for R-Car H3                                                                │ │
	+ System Controller support for R-Car M3-W                                                              │ │
	+ System Controller support for R-Car M3-W+                                                             │ │
	+ System Controller support for R-Car M3-N                                                              │ │

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/soc/renesas/Kconfig | 74 ++++++++++++++++++-------------------
 1 file changed, 37 insertions(+), 37 deletions(-)

Comments

Geert Uytterhoeven Aug. 21, 2020, 2:19 p.m. UTC | #1 
Hi Morimoto-san,

On Mon, Aug 17, 2020 at 6:51 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Now, Renesas SoC drivers are under menu,
> but current description are not aligned.
> This patch align these.
>
>         - R-Car H2 System Controller support                                                                    │ │
>         - R-Car M2-W/N System Controller support                                                                │ │
>         - R-Car V2H System Controller support                                                                   │ │
>         - R-Car E2 System Controller support                                                                    │ │
>         - R-Car H3 System Controller support                                                                    │ │
>         - R-Car M3-W System Controller support                                                                  │ │
>         - R-Car M3-W+ System Controller support                                                                 │ │
>         - R-Car M3-N System Controller support                                                                  │ │
>
>         + System Controller support for R-Car H2                                                                │ │
>         + System Controller support for R-Car M2-W/N                                                            │ │
>         + System Controller support for R-Car V2H                                                               │ │
>         + System Controller support for R-Car E2                                                                │ │
>         + System Controller support for R-Car H3                                                                │ │
>         + System Controller support for R-Car M3-W                                                              │ │
>         + System Controller support for R-Car M3-W+                                                             │ │
>         + System Controller support for R-Car M3-N                                                              │ │
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -276,97 +276,97 @@ endif # ARM64
>
>  # SoC
>  config SYSC_R8A7742
> -       bool "RZ/G1H System Controller support" if COMPILE_TEST
> +       bool "System Controller support for RZ/G1H" if COMPILE_TEST
>         select SYSC_RCAR

[...]

>  config SYSC_R8A77995
> -       bool "R-Car D3 System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Car D3" if COMPILE_TEST
>         select SYSC_RCAR
>
>  # Family
>  config RST_RCAR
> -       bool "R-Car Reset Controller support" if COMPILE_TEST
> +       bool "Reset  Controller support for R-Car" if COMPILE_TEST

This one looks a bit strange, in between SoC-specific and family-specific
System Controller support.

It could be moved up (breaking the separation between SoC-specific
and family-specific options), or down (breaking alphabetical sort order).
Any other options?

>
>  config SYSC_RCAR
> -       bool "R-Car System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Car" if COMPILE_TEST
>
>  config SYSC_RMOBILE
> -       bool "R-Mobile System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Mobile" if COMPILE_TEST
>
>  endif # SOC_RENESAS

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Aug. 24, 2020, 12:03 a.m. UTC | #2 
Hi Geert

> >  # Family
> >  config RST_RCAR
> > -       bool "R-Car Reset Controller support" if COMPILE_TEST
> > +       bool "Reset  Controller support for R-Car" if COMPILE_TEST
> 
> This one looks a bit strange, in between SoC-specific and family-specific
> System Controller support.
> 
> It could be moved up (breaking the separation between SoC-specific
> and family-specific options), or down (breaking alphabetical sort order).
> Any other options?

OK will do in v3

Thank you for your help !!

Best regards
---
Kuninori Morimoto
diff mbox series

Patch

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 265a59345909..bd9a9ab10d21 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -181,42 +181,42 @@  endif # ARM
 if ARM64
 
 config ARCH_R8A774A1
-	bool "Renesas RZ/G2M SoC Platform"
+	bool "SoC Platform support for RZ/G2M"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774A1
 	help
 	  This enables support for the Renesas RZ/G2M SoC.
 
 config ARCH_R8A774B1
-	bool "Renesas RZ/G2N SoC Platform"
+	bool "SoC Platform support for RZ/G2N"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774B1
 	help
 	  This enables support for the Renesas RZ/G2N SoC.
 
 config ARCH_R8A774C0
-	bool "Renesas RZ/G2E SoC Platform"
+	bool "SoC Platform support for RZ/G2E"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774C0
 	help
 	  This enables support for the Renesas RZ/G2E SoC.
 
 config ARCH_R8A774E1
-	bool "Renesas RZ/G2H SoC Platform"
+	bool "SoC Platform support for RZ/G2H"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774E1
 	help
 	  This enables support for the Renesas RZ/G2H SoC.
 
 config ARCH_R8A77950
-	bool "Renesas R-Car H3 ES1.x SoC Platform"
+	bool "SoC Platform support for R-Car H3 ES1.x"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A7795
 	help
 	  This enables support for the Renesas R-Car H3 SoC (revision 1.x).
 
 config ARCH_R8A77951
-	bool "Renesas R-Car H3 ES2.0+ SoC Platform"
+	bool "SoC Platform support for R-Car H3 ES2.0+"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A7795
 	help
@@ -224,49 +224,49 @@  config ARCH_R8A77951
 	  later).
 
 config ARCH_R8A77960
-	bool "Renesas R-Car M3-W SoC Platform"
+	bool "SoC Platform support for R-Car M3-W"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77960
 	help
 	  This enables support for the Renesas R-Car M3-W SoC.
 
 config ARCH_R8A77961
-	bool "Renesas R-Car M3-W+ SoC Platform"
+	bool "SoC Platform support for R-Car M3-W+"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77961
 	help
 	  This enables support for the Renesas R-Car M3-W+ SoC.
 
 config ARCH_R8A77965
-	bool "Renesas R-Car M3-N SoC Platform"
+	bool "SoC Platform support for R-Car M3-N"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77965
 	help
 	  This enables support for the Renesas R-Car M3-N SoC.
 
 config ARCH_R8A77970
-	bool "Renesas R-Car V3M SoC Platform"
+	bool "SoC Platform support for R-Car V3M"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77970
 	help
 	  This enables support for the Renesas R-Car V3M SoC.
 
 config ARCH_R8A77980
-	bool "Renesas R-Car V3H SoC Platform"
+	bool "SoC Platform support for R-Car V3H"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77980
 	help
 	  This enables support for the Renesas R-Car V3H SoC.
 
 config ARCH_R8A77990
-	bool "Renesas R-Car E3 SoC Platform"
+	bool "SoC Platform support for R-Car E3"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77990
 	help
 	  This enables support for the Renesas R-Car E3 SoC.
 
 config ARCH_R8A77995
-	bool "Renesas R-Car D3 SoC Platform"
+	bool "SoC Platform support for R-Car D3"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77995
 	help
@@ -276,97 +276,97 @@  endif # ARM64
 
 # SoC
 config SYSC_R8A7742
-	bool "RZ/G1H System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7743
-	bool "RZ/G1M System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7745
-	bool "RZ/G1E System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1E" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77470
-	bool "RZ/G1C System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1C" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774A1
-	bool "RZ/G2M System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774B1
-	bool "RZ/G2N System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774C0
-	bool "RZ/G2E System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2E" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774E1
-	bool "RZ/G2H System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7779
-	bool "R-Car H1 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H1" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7790
-	bool "R-Car H2 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H2" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7791
-	bool "R-Car M2-W/N System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M2-W/N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7792
-	bool "R-Car V2H System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V2H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7794
-	bool "R-Car E2 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car E2" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7795
-	bool "R-Car H3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77960
-	bool "R-Car M3-W System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-W" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77961
-	bool "R-Car M3-W+ System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-W+" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77965
-	bool "R-Car M3-N System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77970
-	bool "R-Car V3M System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V3M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77980
-	bool "R-Car V3H System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V3H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77990
-	bool "R-Car E3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car E3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77995
-	bool "R-Car D3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car D3" if COMPILE_TEST
 	select SYSC_RCAR
 
 # Family
 config RST_RCAR
-	bool "R-Car Reset Controller support" if COMPILE_TEST
+	bool "Reset  Controller support for R-Car" if COMPILE_TEST
 
 config SYSC_RCAR
-	bool "R-Car System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car" if COMPILE_TEST
 
 config SYSC_RMOBILE
-	bool "R-Mobile System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Mobile" if COMPILE_TEST
 
 endif # SOC_RENESAS