arm64: renesas: r8a77990-ebisu: remove clkout-lr-synchronous from rcar_sound

Commit Message

Kuninori Morimoto Dec. 16, 2019, 2:08 a.m. UTC

From: Kuninori Morimoto <[e-mail]>

rcar_sound doesn't support clkout-lr-synchronous in upstream.
It was supported under out-of-tree rcar_sound.
upstream rcar_sound is supporting
	- clkout-lr-synchronous
	+ clkout-lr-asynchronous

Signed-off-by: Kuninori Morimoto <[e-mail]>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Geert Uytterhoeven Dec. 16, 2019, 8:10 a.m. UTC | #1

Hi Morimoto-san,

On Mon, Dec 16, 2019 at 3:08 AM Kuninori Morimoto
<[e-mail]> wrote:
> From: Kuninori Morimoto <[e-mail]>
>
> rcar_sound doesn't support clkout-lr-synchronous in upstream.
> It was supported under out-of-tree rcar_sound.
> upstream rcar_sound is supporting
>         - clkout-lr-synchronous
>         + clkout-lr-asynchronous
>
> Signed-off-by: Kuninori Morimoto <[e-mail]>

Thanks for your patch!

IIUIC, as no upstream code looks at this property, there is no need to
apply this as a fix for v5.5, and it is safe to queue this for v5.6?

Nevertheless, I think it is good to add
Fixes: 56629fcba94c698d ("arm64: dts: renesas: ebisu: Enable Audio")
No need to resend, I can add that while applying.

Thank you!

> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -636,7 +636,6 @@
>         /* audio_clkout0/1/2/3 */
>         #clock-cells = <1>;
>         clock-frequency = <12288000 11289600>;
> -       clkout-lr-synchronous;
>
>         status = "okay";

Gr{oetje,eeting}s,

                        Geert

Kuninori Morimoto Dec. 16, 2019, 8:19 a.m. UTC | #2

Hi Geert

Thank you for your feedback

> > From: Kuninori Morimoto <[e-mail]>
> >
> > rcar_sound doesn't support clkout-lr-synchronous in upstream.
> > It was supported under out-of-tree rcar_sound.
> > upstream rcar_sound is supporting
> >         - clkout-lr-synchronous
> >         + clkout-lr-asynchronous
> >
> > Signed-off-by: Kuninori Morimoto <[e-mail]>
(snip)
> IIUIC, as no upstream code looks at this property, there is no need to
> apply this as a fix for v5.5, and it is safe to queue this for v5.6?

Yes, I think so.
Driver never use/check it.
This is just for cleanup.

> Nevertheless, I think it is good to add
> Fixes: 56629fcba94c698d ("arm64: dts: renesas: ebisu: Enable Audio")
> No need to resend, I can add that while applying.

Ah, yes please.
Thank you for your help

Thank you for your help !!
Best regards
---
Kuninori Morimoto

[e-mail] Dec. 20, 2019, 5:40 p.m. UTC | #3

Hello:

The following patches were marked "accepted", because they were applied to
geert/renesas-devel (refs/heads/next):

Patch: arm64: renesas: r8a77990-ebisu: remove clkout-lr-synchronous from rcar_sound
  Submitter: Kuninori Morimoto <[e-mail]>
  Patchwork: https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=217187

Total patches: 1

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index b38f9d4..e6d700f 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -636,7 +636,6 @@ 
 	/* audio_clkout0/1/2/3 */
 	#clock-cells = <1>;
 	clock-frequency = <12288000 11289600>;
-	clkout-lr-synchronous;
 
 	status = "okay";