diff mbox series

[v2,1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place

Message ID 87pn7phofb.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series pinctrl: sh-pfc: collect Renesas related CONFIGs in one place | expand

Commit Message

Kuninori Morimoto Aug. 17, 2020, 4:46 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Renesas related pinctrl CONFIGs are located many places,
and it is confusable.
This patch collects these into same place,
and group into "Renesas pinctrl drivers" menu.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/pinctrl/Kconfig        | 32 ------------------------------
 drivers/pinctrl/sh-pfc/Kconfig | 36 ++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 32 deletions(-)

Comments

Geert Uytterhoeven Aug. 21, 2020, 1:56 p.m. UTC | #1 
On Mon, Aug 17, 2020 at 6:46 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Renesas related pinctrl CONFIGs are located many places,
> and it is confusable.
> This patch collects these into same place,
> and group into "Renesas pinctrl drivers" menu.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
into drivers/pinctrl/sh-pfc/, too.

> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -213,38 +213,6 @@ config PINCTRL_ROCKCHIP
>         select GENERIC_IRQ_CHIP
>         select MFD_SYSCON
>
> -config PINCTRL_RZA1
> -       bool "Renesas RZ/A1 gpio and pinctrl driver"
> -       depends on OF
> -       depends on ARCH_R7S72100 || COMPILE_TEST
> -       select GPIOLIB
> -       select GENERIC_PINCTRL_GROUPS
> -       select GENERIC_PINMUX_FUNCTIONS
> -       select GENERIC_PINCONF
> -       help
> -         This selects pinctrl driver for Renesas RZ/A1 platforms.
> -
> -config PINCTRL_RZA2
> -       bool "Renesas RZ/A2 gpio and pinctrl driver"
> -       depends on OF
> -       depends on ARCH_R7S9210 || COMPILE_TEST
> -       select GPIOLIB
> -       select GENERIC_PINCTRL_GROUPS
> -       select GENERIC_PINMUX_FUNCTIONS
> -       select GENERIC_PINCONF
> -       help
> -         This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
> -
> -config PINCTRL_RZN1
> -       bool "Renesas RZ/N1 pinctrl driver"
> -       depends on OF
> -       depends on ARCH_RZN1 || COMPILE_TEST
> -       select GENERIC_PINCTRL_GROUPS
> -       select GENERIC_PINMUX_FUNCTIONS
> -       select GENERIC_PINCONF
> -       help
> -         This selects pinctrl driver for Renesas RZ/N1 devices.
> -
>  config PINCTRL_SINGLE
>         tristate "One-register-per-pin type device tree based pinctrl driver"
>         depends on OF
> diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
> index c461a2f1927a..a16393e6b9c2 100644
> --- a/drivers/pinctrl/sh-pfc/Kconfig
> +++ b/drivers/pinctrl/sh-pfc/Kconfig
> @@ -3,6 +3,8 @@
>  # Renesas SH and SH Mobile PINCTRL drivers
>  #
>
> +menu "Renesas pinctrl drivers"
> +
>  config PINCTRL_SH_PFC
>         bool "Renesas SoC pin control support" if COMPILE_TEST && !(ARCH_RENESAS || SUPERH)
>         default y if ARCH_RENESAS || SUPERH
> @@ -52,6 +54,38 @@ config PINCTRL_SH_PFC
>         help
>           This enables pin control drivers for Renesas SuperH and ARM platforms
>
> +config PINCTRL_RZA1
> +       bool "RZ/A1 gpio and pinctrl driver"
> +       depends on OF
> +       depends on ARCH_R7S72100 || COMPILE_TEST
> +       select GPIOLIB
> +       select GENERIC_PINCTRL_GROUPS
> +       select GENERIC_PINMUX_FUNCTIONS
> +       select GENERIC_PINCONF
> +       help
> +         This selects pinctrl driver for Renesas RZ/A1 platforms.
> +
> +config PINCTRL_RZA2
> +       bool "RZ/A2 gpio and pinctrl driver"
> +       depends on OF
> +       depends on ARCH_R7S9210 || COMPILE_TEST
> +       select GPIOLIB
> +       select GENERIC_PINCTRL_GROUPS
> +       select GENERIC_PINMUX_FUNCTIONS
> +       select GENERIC_PINCONF
> +       help
> +         This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
> +
> +config PINCTRL_RZN1
> +       bool "RZ/N1 pinctrl driver"
> +       depends on OF
> +       depends on ARCH_RZN1 || COMPILE_TEST
> +       select GENERIC_PINCTRL_GROUPS
> +       select GENERIC_PINMUX_FUNCTIONS
> +       select GENERIC_PINCONF
> +       help
> +         This selects pinctrl driver for Renesas RZ/N1 devices.
> +
>  config PINCTRL_SH_PFC_GPIO
>         select GPIOLIB
>         bool
> @@ -199,3 +233,5 @@ config PINCTRL_PFC_SH7786
>  config PINCTRL_PFC_SHX3
>         bool "SH-X3 pin control support" if COMPILE_TEST
>         select PINCTRL_SH_FUNC_GPIO
> +
> +endmenu

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Aug. 24, 2020, 12:04 a.m. UTC | #2 
Hi Geert

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Renesas related pinctrl CONFIGs are located many places,
> > and it is confusable.
> > This patch collects these into same place,
> > and group into "Renesas pinctrl drivers" menu.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> into drivers/pinctrl/sh-pfc/, too.

As I mentioned before, I'm waiting Linus's opinion.
But will move these in v3 without waiting him.

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Linus Walleij Aug. 28, 2020, 9:47 a.m. UTC | #3 
On Mon, Aug 24, 2020 at 2:04 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Renesas related pinctrl CONFIGs are located many places,
> > > and it is confusable.
> > > This patch collects these into same place,
> > > and group into "Renesas pinctrl drivers" menu.
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> > into drivers/pinctrl/sh-pfc/, too.
>
> As I mentioned before, I'm waiting Linus's opinion.
> But will move these in v3 without waiting him.

Sorry for slowness. I agree with this move, let's collect all the Renesas
stuff in one place.

Renaming it drivers/pinctrl/renesas may be a good idea too, but I'd let
Geert decide and execute that, it mainly affects him and his maintenance
work, not me.

Yours,
Linus Walleij
Kuninori Morimoto Aug. 30, 2020, 11:14 p.m. UTC | #4 
Hi Linus
Cc Geert

Thank you for your feedback

> > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > Renesas related pinctrl CONFIGs are located many places,
> > > > and it is confusable.
> > > > This patch collects these into same place,
> > > > and group into "Renesas pinctrl drivers" menu.
> > > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> > > into drivers/pinctrl/sh-pfc/, too.
> >
> > As I mentioned before, I'm waiting Linus's opinion.
> > But will move these in v3 without waiting him.
> 
> Sorry for slowness. I agree with this move, let's collect all the Renesas
> stuff in one place.

Thanks !

> Renaming it drivers/pinctrl/renesas may be a good idea too, but I'd let
> Geert decide and execute that, it mainly affects him and his maintenance
> work, not me.

Geert, my patch moves files, but do nothing to folder names.
I agree to Linus's opinion, please execute it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto
Geert Uytterhoeven Aug. 31, 2020, 1:56 p.m. UTC | #5 
Hi Morimoto-san,

On Mon, Aug 31, 2020 at 1:14 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > >
> > > > > Renesas related pinctrl CONFIGs are located many places,
> > > > > and it is confusable.
> > > > > This patch collects these into same place,
> > > > > and group into "Renesas pinctrl drivers" menu.
> > > > >
> > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> > > > into drivers/pinctrl/sh-pfc/, too.
> > >
> > > As I mentioned before, I'm waiting Linus's opinion.
> > > But will move these in v3 without waiting him.
> >
> > Sorry for slowness. I agree with this move, let's collect all the Renesas
> > stuff in one place.
>
> Thanks !
>
> > Renaming it drivers/pinctrl/renesas may be a good idea too, but I'd let
> > Geert decide and execute that, it mainly affects him and his maintenance
> > work, not me.
>
> Geert, my patch moves files, but do nothing to folder names.
> I agree to Linus's opinion, please execute it.

Thanks, I will take care of the rename.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 8828613c4e0e..f63c5a04a3f7 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -213,38 +213,6 @@  config PINCTRL_ROCKCHIP
 	select GENERIC_IRQ_CHIP
 	select MFD_SYSCON
 
-config PINCTRL_RZA1
-	bool "Renesas RZ/A1 gpio and pinctrl driver"
-	depends on OF
-	depends on ARCH_R7S72100 || COMPILE_TEST
-	select GPIOLIB
-	select GENERIC_PINCTRL_GROUPS
-	select GENERIC_PINMUX_FUNCTIONS
-	select GENERIC_PINCONF
-	help
-	  This selects pinctrl driver for Renesas RZ/A1 platforms.
-
-config PINCTRL_RZA2
-	bool "Renesas RZ/A2 gpio and pinctrl driver"
-	depends on OF
-	depends on ARCH_R7S9210 || COMPILE_TEST
-	select GPIOLIB
-	select GENERIC_PINCTRL_GROUPS
-	select GENERIC_PINMUX_FUNCTIONS
-	select GENERIC_PINCONF
-	help
-	  This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
-
-config PINCTRL_RZN1
-	bool "Renesas RZ/N1 pinctrl driver"
-	depends on OF
-	depends on ARCH_RZN1 || COMPILE_TEST
-	select GENERIC_PINCTRL_GROUPS
-	select GENERIC_PINMUX_FUNCTIONS
-	select GENERIC_PINCONF
-	help
-	  This selects pinctrl driver for Renesas RZ/N1 devices.
-
 config PINCTRL_SINGLE
 	tristate "One-register-per-pin type device tree based pinctrl driver"
 	depends on OF
diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
index c461a2f1927a..a16393e6b9c2 100644
--- a/drivers/pinctrl/sh-pfc/Kconfig
+++ b/drivers/pinctrl/sh-pfc/Kconfig
@@ -3,6 +3,8 @@ 
 # Renesas SH and SH Mobile PINCTRL drivers
 #
 
+menu "Renesas pinctrl drivers"
+
 config PINCTRL_SH_PFC
 	bool "Renesas SoC pin control support" if COMPILE_TEST && !(ARCH_RENESAS || SUPERH)
 	default y if ARCH_RENESAS || SUPERH
@@ -52,6 +54,38 @@  config PINCTRL_SH_PFC
 	help
 	  This enables pin control drivers for Renesas SuperH and ARM platforms
 
+config PINCTRL_RZA1
+	bool "RZ/A1 gpio and pinctrl driver"
+	depends on OF
+	depends on ARCH_R7S72100 || COMPILE_TEST
+	select GPIOLIB
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
+	select GENERIC_PINCONF
+	help
+	  This selects pinctrl driver for Renesas RZ/A1 platforms.
+
+config PINCTRL_RZA2
+	bool "RZ/A2 gpio and pinctrl driver"
+	depends on OF
+	depends on ARCH_R7S9210 || COMPILE_TEST
+	select GPIOLIB
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
+	select GENERIC_PINCONF
+	help
+	  This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
+
+config PINCTRL_RZN1
+	bool "RZ/N1 pinctrl driver"
+	depends on OF
+	depends on ARCH_RZN1 || COMPILE_TEST
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
+	select GENERIC_PINCONF
+	help
+	  This selects pinctrl driver for Renesas RZ/N1 devices.
+
 config PINCTRL_SH_PFC_GPIO
 	select GPIOLIB
 	bool
@@ -199,3 +233,5 @@  config PINCTRL_PFC_SH7786
 config PINCTRL_PFC_SHX3
 	bool "SH-X3 pin control support" if COMPILE_TEST
 	select PINCTRL_SH_FUNC_GPIO
+
+endmenu