diff mbox series

[v2] pmdomain: renesas: Adjust the waiting time to cover the worst case

Message ID 87sf22a4sp.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series [v2] pmdomain: renesas: Adjust the waiting time to cover the worst case | expand

Commit Message

Kuninori Morimoto Feb. 8, 2024, 11:56 p.m. UTC 
From: Dien Pham <dien.pham.ry@renesas.com>

Description in HWM rev0.51E, 9.4 Usage notes, page 455 tells

	"It takes several hundreds of microseconds to shutting off and
	 resuming power domain. Because actual time required for
	 shutting off and resuming depends on the status of on-board
	 power line, shutoff/resume time is not guaranteed by
	 electrical specification"

Let's assume the safe value of waiting is about 1000us.

Signed-off-by: Dien Pham <dien.pham.ry@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Tho Vu <tho.vu.wh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
	- Dien Pham <dien.pham.ry@rvc.renesas.com>
	+ Dien Pham <dien.pham.ry@renesas.com>

 drivers/pmdomain/renesas/rcar-sysc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Geert Uytterhoeven Feb. 11, 2024, 3:28 p.m. UTC | #1 
On Fri, Feb 9, 2024 at 12:56 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Dien Pham <dien.pham.ry@renesas.com>
>
> Description in HWM rev0.51E, 9.4 Usage notes, page 455 tells
>
>         "It takes several hundreds of microseconds to shutting off and
>          resuming power domain. Because actual time required for
>          shutting off and resuming depends on the status of on-board
>          power line, shutoff/resume time is not guaranteed by
>          electrical specification"
>
> Let's assume the safe value of waiting is about 1000us.
>
> Signed-off-by: Dien Pham <dien.pham.ry@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Tho Vu <tho.vu.wh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I think you can drop that line ;-)

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/pmdomain/renesas/rcar-sysc.c b/drivers/pmdomain/renesas/rcar-sysc.c
index eed47696e825..35d9aa0dfab8 100644
--- a/drivers/pmdomain/renesas/rcar-sysc.c
+++ b/drivers/pmdomain/renesas/rcar-sysc.c
@@ -45,10 +45,10 @@ 
 #define PWRER_OFFS		0x14	/* Power Shutoff/Resume Error */
 
 
-#define SYSCSR_TIMEOUT		100
+#define SYSCSR_TIMEOUT		1000
 #define SYSCSR_DELAY_US		1
 
-#define PWRER_RETRIES		100
+#define PWRER_RETRIES		1000
 #define PWRER_DELAY_US		1
 
 #define SYSCISR_TIMEOUT		1000